From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: designware: Print clock freq on invalid clock freq error
Date: Sat, 08 Jul 2017 16:54:29 +0300 [thread overview]
Message-ID: <1499522069.22624.305.camel@linux.intel.com> (raw)
In-Reply-To: <20170708131052.13524-1-hdegoede@redhat.com>
On Sat, 2017-07-08 at 15:10 +0200, Hans de Goede wrote:
> When we refuse to probe due to an invalid clock frequency, log
> the frequency which is causing this error.
Shouldn't it have \n as well?
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> b/drivers/i2c/busses/i2c-designware-platdrv.c
> index d1263b82d646..d5acaf8d65bf 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -275,7 +275,8 @@ static int dw_i2c_plat_probe(struct
> platform_device *pdev)
> if (dev->clk_freq != 100000 && dev->clk_freq != 400000
> && dev->clk_freq != 1000000 && dev->clk_freq != 3400000)
> {
> dev_err(&pdev->dev,
> - "Only 100kHz, 400kHz, 1MHz and 3.4MHz
> supported");
> + "%d Hz is unsupported, only 100kHz, 400kHz,
> 1MHz and 3.4MHz are supported",
> + dev->clk_freq);
> r = -EINVAL;
> goto exit_reset;
> }
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-07-08 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 13:10 [PATCH 1/2] i2c: designware: Print clock freq on invalid clock freq error Hans de Goede
2017-07-08 13:10 ` [PATCH 2/2] i2c: designware: Some broken DSTDs use 1MiHz instead of 1MHz Hans de Goede
2017-07-08 13:55 ` Andy Shevchenko
2017-07-09 18:54 ` Hans de Goede
2017-07-08 13:54 ` Andy Shevchenko [this message]
2017-07-09 18:53 ` [PATCH 1/2] i2c: designware: Print clock freq on invalid clock freq error Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499522069.22624.305.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.