From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 Date: Tue, 11 Jul 2017 15:17:46 +0000 Message-ID: <1499786264.1520.22.camel@toradex.com> References: <20170709163614.6746-1-contact@paulk.fr> <1499763009.1340.11.camel@paulk.fr> <1499784841.1520.20.camel@toradex.com> <1499785555.1340.15.camel@paulk.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1499785555.1340.15.camel@paulk.fr> Content-Language: en-US Content-ID: <2499C23F2F43614BB3C460FD949086DA@eurprd05.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "contact@paulk.fr" , "linux-tegra@vger.kernel.org" Cc: "jonathanh@nvidia.com" , "mperttunen@nvidia.com" , "treding@nvidia.com" , "swarren@nvidia.com" List-Id: linux-tegra@vger.kernel.org T24gVHVlLCAyMDE3LTA3LTExIGF0IDE4OjA1ICswMzAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90 ZToNCj4gT24gVHVlLCAyMDE3LTA3LTExIGF0IDE0OjU0ICswMDAwLCBNYXJjZWwgWmlzd2lsZXIg d3JvdGU6DQo+ID4gT24gVHVlLCAyMDE3LTA3LTExIGF0IDExOjUwICswMzAwLCBQYXVsIEtvY2lh bGtvd3NraSB3cm90ZToNCj4gPiA+IE9uIFN1biwgMjAxNy0wNy0wOSBhdCAxOTozNiArMDMwMCwg UGF1bCBLb2NpYWxrb3dza2kgd3JvdGU6DQo+ID4gPiA+IFRoaXMgcmVnaXN0ZXJzIHRoZSBob3N0 MXggbm9kZSB3aXRoIHRoZSBTTU1VIChhcyBIQyBzd2dyb3VwKSB0bw0KPiA+ID4gPiBhbGxvdw0K PiA+ID4gPiB0aGUgaG9zdDF4IGNvZGUgdG8gYXR0YWNoIHRvIGl0LiBJdCBhdm9pZCBmYWlsaW5n IHRoZSBwcm9iZQ0KPiA+ID4gPiBzZXF1ZW5jZSwNCj4gPiA+ID4gd2hpY2ggcmVzdWx0ZWQgaW4g dGhlIHRlZ3JhIGRybSBkcml2ZXIgbm90IHByb2JpbmcgYW5kIHRodXMNCj4gPiA+ID4gbm90aGlu Zw0KPiA+ID4gPiBiZWluZyBkaXNwbGF5ZWQgb24tc2NyZWVuLg0KPiA+ID4gDQo+ID4gPiBGaXhl czogNDA0YmZiNzhkYWYzICgiZ3B1OiBob3N0MXg6IEFkZCBJT01NVSBzdXBwb3J0IikNCj4gPiA+ IA0KPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8Y29udGFjdC0NCj4g PiA+ID4gVzlwcGVuZWVDVFlAcHVibGljLmdtYW5lLm9yZz4NCj4gPiANCj4gPiBUZXN0ZWQtYnk6 IE1hcmNlbCBaaXN3aWxlciA8bWFyY2VsLnppc3dpbGVyQHRvcmFkZXguY29tPg0KPiA+IFRlc3Rl ZC1vbjogQXBhbGlzIFRLMSwgSmV0c29uLVRLMQ0KPiA+IA0KPiA+ID4gPiAtLS0NCj4gPiA+ID4g wqBhcmNoL2FybS9ib290L2R0cy90ZWdyYTEyNC5kdHNpIHwgMSArDQo+ID4gPiA+IMKgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspDQo+ID4gPiA+IA0KPiA+ID4gPiBkaWZmIC0tZ2l0IGEv YXJjaC9hcm0vYm9vdC9kdHMvdGVncmExMjQuZHRzaQ0KPiA+ID4gPiBiL2FyY2gvYXJtL2Jvb3Qv ZHRzL3RlZ3JhMTI0LmR0c2kNCj4gPiA+ID4gaW5kZXggMTg3YTM2YzZkMGZjLi5iM2I4OWJlZmZm ZWIgMTAwNjQ0DQo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL3RlZ3JhMTI0LmR0c2kN Cj4gPiA+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvdGVncmExMjQuZHRzaQ0KPiA+ID4gPiBA QCAtODUsNiArODUsNyBAQA0KPiA+ID4gPiDCoAkJY2xvY2tzID0gPCZ0ZWdyYV9jYXIgVEVHUkEx MjRfQ0xLX0hPU1QxWD47DQo+ID4gPiA+IMKgCQlyZXNldHMgPSA8JnRlZ3JhX2NhciAyOD47DQo+ ID4gPiA+IMKgCQlyZXNldC1uYW1lcyA9ICJob3N0MXgiOw0KPiA+ID4gPiArCQlpb21tdXMgPSA8 Jm1jIFRFR1JBX1NXR1JPVVBfSEM+Ow0KPiA+ID4gPiDCoA0KPiA+ID4gPiDCoAkJI2FkZHJlc3Mt Y2VsbHMgPSA8Mj47DQo+ID4gPiA+IMKgCQkjc2l6ZS1jZWxscyA9IDwyPjsNCj4gPiANCj4gPiBT byBJIHRha2UgaXQgd2Ugc3RpbGwgd2lsbCBuZWVkIHRoaXMgb25lIG1vdmluZyBmb3J3YXJkLCBj b3JyZWN0Pw0KPiANCj4gWWVzLCB0aGlzIG9uZSBhY3R1YWxseSBlbmFibGVzIHRoZSBJT01NVSB3 aGlsZSB0aGUgb3RoZXIgb25lIGhhbmRsZXMNCj4gdGhlDQo+IGZhaWx1cmUgdG8gYXR0YWNoIHRo ZSBJT01NVSB3aXRob3V0IGJyaW5kaW5nIHRoZSB3aG9sZSBkcm0gZHJpdmVyDQo+IGRvd24uDQo+ IA0KPiBTbyBpdCdzIGJlc3QgdG8gYWN0dWFsbHkgbWFrZSB1c2Ugb2YgdGhlIGZlYXR1cmUhDQo+ IA0KPiA+IEhvdyBhYm91dCB0ZWdyYTMwLCBJIGd1ZXNzIHRoZSBzYW1lIGFwcGxpZXMgdGhlcmUs IGlzbid0IGl0PyBTaG91bGQNCj4gPiBJDQo+ID4gc2VuZCBhIHBhdGNoIG9yIGFyZSB5b3UgZ3V5 cyBkb2luZyB0aGF0Pw0KPiANCj4gSSBkb24ndCBoYXZlIGFueSB0ZWdyYSBoYXJkd2FyZSBhc2lk ZSBvZiB0ZWdyYTEyNCwgc28gdGhhdCdzIGFsbCBJDQo+IGNhbg0KPiBjb250cmlidXRlIHRvLiBJ IGRvbid0IGtub3cgaWYgb3RoZXJzIGhhdmUgbG9va2VkIGludG8gdGhlIHNhbWUgdHlwZQ0KPiBv Zg0KPiBpc3N1ZSBoYXBwZW5pbmcgb24gZWl0aGVyIG5ld2VyIG9yIG9sZGVyIHBsYXRmb3Jtcy4N Cg0KT0ssIGFzIHdlIGhhcHBlbiB0byBzdGlsbCBzZWxsaW5nIEFwYWxpcy9Db2xpYnJpIFQzMCBh bmQgbWUgaGF2aW5nDQpCZWF2ZXIgYXMgd2VsbCBhcyBDYXJkaHUgYXZhaWxhYmxlIGZvciB0ZXN0 aW5nIEkgY2FuIGNvb2sgc29tZXRoaW5nIHVwLA0KdGVzdCBhbmQgc2VuZCBpdCBhbG9uZy4gRmly c3QgdHJpZXMgaW5kaWNhdGUgaXQgd29ya2luZyBvbiA0LjEyIGJ1dA0Kc29tZWhvdyBjcmFzaGlu ZyBkdXJpbmcgbWVtb3J5IGFsbG9jYXRpb24gb24gLW5leHQuIFdlJ2xsIHNlZS4NCg0KPiBDaGVl cnMs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933389AbdGKPR5 (ORCPT ); Tue, 11 Jul 2017 11:17:57 -0400 Received: from mail-eopbgr00126.outbound.protection.outlook.com ([40.107.0.126]:21088 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933157AbdGKPRw (ORCPT ); Tue, 11 Jul 2017 11:17:52 -0400 From: Marcel Ziswiler To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "contact@paulk.fr" , "linux-tegra@vger.kernel.org" CC: "jonathanh@nvidia.com" , "mperttunen@nvidia.com" , "treding@nvidia.com" , "swarren@nvidia.com" Subject: Re: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 Thread-Topic: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 Thread-Index: AQHS+lWK79IETD7mPUijO21AjmqbN6JOubiAgAADTQA= Date: Tue, 11 Jul 2017 15:17:46 +0000 Message-ID: <1499786264.1520.22.camel@toradex.com> References: <20170709163614.6746-1-contact@paulk.fr> <1499763009.1340.11.camel@paulk.fr> <1499784841.1520.20.camel@toradex.com> <1499785555.1340.15.camel@paulk.fr> In-Reply-To: <1499785555.1340.15.camel@paulk.fr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=toradex.com; x-originating-ip: [46.140.72.82] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB1883;7:L1oYBArKd7B/cCReJLNidmcLDTqmD6y2KSTAFwst+or1U7RjZqNAAuCPPi5AAsN4Pg29HT301GRGCJJm5wVp0/A4fwwDJNo3hnAskqyFMjxcs+rc3IuZ+knY7GMpaxoP+sLRizJlTGsCRCFep0IdgN75HUtsNvKBm+5N1ac3eQB1lzWckfvTyj5Dwi8FrUPRNu58ygRJfCnCNXpxyB2lMcHtz1NhusHEGKnZ0LyZQqQ5CZVaC4OtlCpwrrI8BK7mXqM7UUq5nyBKMhNXQIJreSe27JGi11QcpTj8n9L8iNWlVKctuksmlFz9L8Xsp2WpUsV/hxETNPArFJzxhiJmDRsC58ibDPKT7ahKje/vdDDpwK4BLgkCaW7Ghr4xTMpexTdtp5JwoWg8GMgKmtVkil6XFTdRUcTGsrwOdLdMqegY/267XLSdiUNJTtAXaroHyJWDtsV8+LiFObvNnY6/AfToqIiYbjl7ZJAITyK84xK8LAIJ9EPTxhznbKKy71Xhi4x3nT6m/aQRMs+MVKuGteoJyDEIhvBaw62v+3KjlUjfvZ5ibX6WiDSYM/Hppr+J7MCIUAb6hr793qOYjc0GFOafZDlxLr/L4lYg5Dwk9MEYCZ9uPCLvzktAkuX0yyHTnVFIJCvWzb/QduGqRA74k/nIBTGMSy9Nmkgu0epI6KOWvJHZBq11j4Zg2nPbmakDwv4awx36bvkGK1RzedbHMWI3Of5PGdMhlhCwpVMqPZeH5nZ0YsGlW7gH9cl9xLzeoFCzmnr36C5+Aa1iDhJwTRWHsQi7zQcSMBGXHR9fEZg= x-ms-office365-filtering-correlation-id: 8a9f8be7-3be7-4cf8-8668-08d4c86ffc59 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:HE1PR05MB1883; x-ms-traffictypediagnostic: HE1PR05MB1883: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(133145235818549)(236129657087228)(247924648384137); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR05MB1883;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR05MB1883; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39830400002)(39410400002)(39400400002)(377424004)(24454002)(33646002)(5890100001)(2906002)(25786009)(8676002)(305945005)(86362001)(81166006)(8936002)(5250100002)(4326008)(14454004)(2501003)(575784001)(6436002)(5660300001)(6506006)(7736002)(478600001)(3660700001)(103116003)(38730400002)(6512007)(6246003)(66066001)(189998001)(3846002)(2201001)(50986999)(93886004)(54906002)(99286003)(53936002)(102836003)(6116002)(229853002)(54356999)(76176999)(6486002)(3280700002)(2950100002)(36756003)(2900100001)(32563001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1883;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <2499C23F2F43614BB3C460FD949086DA@eurprd05.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2017 15:17:46.5639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1883 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6BFI9sa017262 On Tue, 2017-07-11 at 18:05 +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-11 at 14:54 +0000, Marcel Ziswiler wrote: > > On Tue, 2017-07-11 at 11:50 +0300, Paul Kocialkowski wrote: > > > On Sun, 2017-07-09 at 19:36 +0300, Paul Kocialkowski wrote: > > > > This registers the host1x node with the SMMU (as HC swgroup) to > > > > allow > > > > the host1x code to attach to it. It avoid failing the probe > > > > sequence, > > > > which resulted in the tegra drm driver not probing and thus > > > > nothing > > > > being displayed on-screen. > > > > > > Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support") > > > > > > > Signed-off-by: Paul Kocialkowski > > > W9ppeneeCTY@public.gmane.org> > > > > Tested-by: Marcel Ziswiler > > Tested-on: Apalis TK1, Jetson-TK1 > > > > > > --- > > > >  arch/arm/boot/dts/tegra124.dtsi | 1 + > > > >  1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm/boot/dts/tegra124.dtsi > > > > b/arch/arm/boot/dts/tegra124.dtsi > > > > index 187a36c6d0fc..b3b89befffeb 100644 > > > > --- a/arch/arm/boot/dts/tegra124.dtsi > > > > +++ b/arch/arm/boot/dts/tegra124.dtsi > > > > @@ -85,6 +85,7 @@ > > > >   clocks = <&tegra_car TEGRA124_CLK_HOST1X>; > > > >   resets = <&tegra_car 28>; > > > >   reset-names = "host1x"; > > > > + iommus = <&mc TEGRA_SWGROUP_HC>; > > > >   > > > >   #address-cells = <2>; > > > >   #size-cells = <2>; > > > > So I take it we still will need this one moving forward, correct? > > Yes, this one actually enables the IOMMU while the other one handles > the > failure to attach the IOMMU without brinding the whole drm driver > down. > > So it's best to actually make use of the feature! > > > How about tegra30, I guess the same applies there, isn't it? Should > > I > > send a patch or are you guys doing that? > > I don't have any tegra hardware aside of tegra124, so that's all I > can > contribute to. I don't know if others have looked into the same type > of > issue happening on either newer or older platforms. OK, as we happen to still selling Apalis/Colibri T30 and me having Beaver as well as Cardhu available for testing I can cook something up, test and send it along. First tries indicate it working on 4.12 but somehow crashing during memory allocation on -next. We'll see. > Cheers, From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Tue, 11 Jul 2017 15:17:46 +0000 Subject: [PATCH] ARM: tegra: Register host1x node with iommu binding on tegra124 In-Reply-To: <1499785555.1340.15.camel@paulk.fr> References: <20170709163614.6746-1-contact@paulk.fr> <1499763009.1340.11.camel@paulk.fr> <1499784841.1520.20.camel@toradex.com> <1499785555.1340.15.camel@paulk.fr> Message-ID: <1499786264.1520.22.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-07-11 at 18:05 +0300, Paul Kocialkowski wrote: > On Tue, 2017-07-11 at 14:54 +0000, Marcel Ziswiler wrote: > > On Tue, 2017-07-11 at 11:50 +0300, Paul Kocialkowski wrote: > > > On Sun, 2017-07-09 at 19:36 +0300, Paul Kocialkowski wrote: > > > > This registers the host1x node with the SMMU (as HC swgroup) to > > > > allow > > > > the host1x code to attach to it. It avoid failing the probe > > > > sequence, > > > > which resulted in the tegra drm driver not probing and thus > > > > nothing > > > > being displayed on-screen. > > > > > > Fixes: 404bfb78daf3 ("gpu: host1x: Add IOMMU support") > > > > > > > Signed-off-by: Paul Kocialkowski > > > W9ppeneeCTY at public.gmane.org> > > > > Tested-by: Marcel Ziswiler > > Tested-on: Apalis TK1, Jetson-TK1 > > > > > > --- > > > > ?arch/arm/boot/dts/tegra124.dtsi | 1 + > > > > ?1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm/boot/dts/tegra124.dtsi > > > > b/arch/arm/boot/dts/tegra124.dtsi > > > > index 187a36c6d0fc..b3b89befffeb 100644 > > > > --- a/arch/arm/boot/dts/tegra124.dtsi > > > > +++ b/arch/arm/boot/dts/tegra124.dtsi > > > > @@ -85,6 +85,7 @@ > > > > ? clocks = <&tegra_car TEGRA124_CLK_HOST1X>; > > > > ? resets = <&tegra_car 28>; > > > > ? reset-names = "host1x"; > > > > + iommus = <&mc TEGRA_SWGROUP_HC>; > > > > ? > > > > ? #address-cells = <2>; > > > > ? #size-cells = <2>; > > > > So I take it we still will need this one moving forward, correct? > > Yes, this one actually enables the IOMMU while the other one handles > the > failure to attach the IOMMU without brinding the whole drm driver > down. > > So it's best to actually make use of the feature! > > > How about tegra30, I guess the same applies there, isn't it? Should > > I > > send a patch or are you guys doing that? > > I don't have any tegra hardware aside of tegra124, so that's all I > can > contribute to. I don't know if others have looked into the same type > of > issue happening on either newer or older platforms. OK, as we happen to still selling Apalis/Colibri T30 and me having Beaver as well as Cardhu available for testing I can cook something up, test and send it along. First tries indicate it working on 4.12 but somehow crashing during memory allocation on -next. We'll see. > Cheers,