All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rtmutex: remove unnecessary adjust prio
@ 2017-07-13  6:18 Alex Shi
  2017-07-13  9:48 ` [tip:locking/urgent] locking/rtmutex: Remove unnecessary priority adjustment tip-bot for Alex Shi
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2017-07-13  6:18 UTC (permalink / raw)
  To: peterz, mingo, open list:LOCKING PRIMITIVES
  Cc: linux-kernel, Alex Shi, Steven Rostedt, Sebastian Siewior,
	Mathieu Poirier, Juri Lelli, Thomas Gleixner

We don't need to adjust prio before new pi_waiter adding. The prio
only need update after pi_waiter change or task priority change.

Steven Rostedt pointed:
"Interesting, I did some git mining and this was added with the original
entry of the rtmutex.c (23f78d4a0). Looking at even that version, I
don't see the purpose of adjusting the task prio here. It is done
before anything changes in the task."

Signed-off-by: Alex Shi <alex.shi@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
To: linux-kernel@vger.kernel.org
To: Ingo Molnar <mingo@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel/locking/rtmutex.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 28cd09e..d1fe41f 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
 		return -EDEADLK;
 
 	raw_spin_lock(&task->pi_lock);
-	rt_mutex_adjust_prio(task);
 	waiter->task = task;
 	waiter->lock = lock;
 	waiter->prio = task->prio;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:locking/urgent] locking/rtmutex: Remove unnecessary priority adjustment
  2017-07-13  6:18 [PATCH] rtmutex: remove unnecessary adjust prio Alex Shi
@ 2017-07-13  9:48 ` tip-bot for Alex Shi
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Alex Shi @ 2017-07-13  9:48 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: bigeasy, alex.shi, juri.lelli, tglx, rostedt, peterz,
	mathieu.poirier, hpa, torvalds, linux-kernel, mingo

Commit-ID:  69f0d429c413fe96db2c187475cebcc6e3a8c7f5
Gitweb:     http://git.kernel.org/tip/69f0d429c413fe96db2c187475cebcc6e3a8c7f5
Author:     Alex Shi <alex.shi@linaro.org>
AuthorDate: Thu, 13 Jul 2017 14:18:24 +0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 13 Jul 2017 11:44:06 +0200

locking/rtmutex: Remove unnecessary priority adjustment

We don't need to adjust priority before adding a new pi_waiter, the
priority only needs to be updated after pi_waiter change or task
priority change.

Steven Rostedt pointed out:

  "Interesting, I did some git mining and this was added with the original
   entry of the rtmutex.c (23f78d4a03c5). Looking at even that version, I
   don't see the purpose of adjusting the task prio here. It is done
   before anything changes in the task."

Signed-off-by: Alex Shi <alex.shi@linaro.org>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1499926704-28841-1-git-send-email-alex.shi@linaro.org
[ Enhance the changelog. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/locking/rtmutex.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
index 7806989..649dc9d 100644
--- a/kernel/locking/rtmutex.c
+++ b/kernel/locking/rtmutex.c
@@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
 		return -EDEADLK;
 
 	raw_spin_lock(&task->pi_lock);
-	rt_mutex_adjust_prio(task);
 	waiter->task = task;
 	waiter->lock = lock;
 	waiter->prio = task->prio;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-13  9:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13  6:18 [PATCH] rtmutex: remove unnecessary adjust prio Alex Shi
2017-07-13  9:48 ` [tip:locking/urgent] locking/rtmutex: Remove unnecessary priority adjustment tip-bot for Alex Shi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.