From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756093AbaKTER6 (ORCPT ); Wed, 19 Nov 2014 23:17:58 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:47192 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754023AbaKTER4 (ORCPT ); Wed, 19 Nov 2014 23:17:56 -0500 From: Thierry Reding To: SF Markus Elfring , David Airlie , CC: LKML , , Julia Lawall Date: Thu, 20 Nov 2014 05:17:50 +0100 Message-ID: <149cb6ba1c8.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> In-Reply-To: <546CC755.4010804@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CC755.4010804@users.sourceforge.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 AquaMail/1.5.0.19 (build: 2100846) Subject: Re: [PATCH 1/1] DRM-UDL: Deletion of an unnecessary check before the function call "vunmap" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On November 19, 2014 5:42:26 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Nov 2014 17:33:32 +0100 > > The vunmap() function performes also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/udl/udl_gem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c > index 8044f5f..2979625 100644 > --- a/drivers/gpu/drm/udl/udl_gem.c > +++ b/drivers/gpu/drm/udl/udl_gem.c > @@ -164,8 +164,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj) > return; > } > > - if (obj->vmapping) > - vunmap(obj->vmapping); > + vunmap(obj->vmapping); > > udl_gem_put_pages(obj); > } Reviewed-by: Thierry Reding From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Thu, 20 Nov 2014 04:17:50 +0000 Subject: Re: [PATCH 1/1] DRM-UDL: Deletion of an unnecessary check before the function call "vunmap" Message-Id: <149cb6ba1c8.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CC755.4010804@users.sourceforge.net> In-Reply-To: <546CC755.4010804@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , David Airlie , dri-devel@lists.freedesktop.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML On November 19, 2014 5:42:26 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Nov 2014 17:33:32 +0100 > > The vunmap() function performes also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/udl/udl_gem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c > index 8044f5f..2979625 100644 > --- a/drivers/gpu/drm/udl/udl_gem.c > +++ b/drivers/gpu/drm/udl/udl_gem.c > @@ -164,8 +164,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj) > return; > } > > - if (obj->vmapping) > - vunmap(obj->vmapping); > + vunmap(obj->vmapping); > > udl_gem_put_pages(obj); > } Reviewed-by: Thierry Reding From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/1] DRM-UDL: Deletion of an unnecessary check before the function call "vunmap" Date: Thu, 20 Nov 2014 05:17:50 +0100 Message-ID: <149cb6ba1c8.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CC755.4010804@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A61A6E31F for ; Wed, 19 Nov 2014 20:17:57 -0800 (PST) Received: by mail-wg0-f53.google.com with SMTP id l18so2630497wgh.12 for ; Wed, 19 Nov 2014 20:17:55 -0800 (PST) In-Reply-To: <546CC755.4010804@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring , David Airlie , dri-devel@lists.freedesktop.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org T24gTm92ZW1iZXIgMTksIDIwMTQgNTo0MjoyNiBQTSBTRiBNYXJrdXMgRWxmcmluZyAKPGVsZnJp bmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PiB3cm90ZToKPiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8 ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+Cj4gRGF0ZTogV2VkLCAxOSBOb3YgMjAxNCAx NzozMzozMiArMDEwMAo+Cj4gVGhlIHZ1bm1hcCgpIGZ1bmN0aW9uIHBlcmZvcm1lcyBhbHNvIGlu cHV0IHBhcmFtZXRlciB2YWxpZGF0aW9uLiBUaHVzIHRoZSB0ZXN0Cj4gYXJvdW5kIHRoZSBjYWxs IGlzIG5vdCBuZWVkZWQuCj4KPiBUaGlzIGlzc3VlIHdhcyBkZXRlY3RlZCBieSB1c2luZyB0aGUg Q29jY2luZWxsZSBzb2Z0d2FyZS4KPgo+IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxl bGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Vk bC91ZGxfZ2VtLmMgfCAzICstLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfZ2Vt LmMgYi9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9nZW0uYwo+IGluZGV4IDgwNDRmNWYuLjI5Nzk2 MjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfZ2VtLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9nZW0uYwo+IEBAIC0xNjQsOCArMTY0LDcgQEAgdm9pZCB1 ZGxfZ2VtX3Z1bm1hcChzdHJ1Y3QgdWRsX2dlbV9vYmplY3QgKm9iaikKPiAgCQlyZXR1cm47Cj4g IAl9Cj4KPiAtCWlmIChvYmotPnZtYXBwaW5nKQo+IC0JCXZ1bm1hcChvYmotPnZtYXBwaW5nKTsK PiArCXZ1bm1hcChvYmotPnZtYXBwaW5nKTsKPgo+ICAJdWRsX2dlbV9wdXRfcGFnZXMob2JqKTsK PiAgfQoKUmV2aWV3ZWQtYnk6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5j b20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK