From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755946AbaKTEWo (ORCPT ); Wed, 19 Nov 2014 23:22:44 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:35952 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754327AbaKTEWn (ORCPT ); Wed, 19 Nov 2014 23:22:43 -0500 From: Thierry Reding To: SF Markus Elfring , David Airlie , CC: LKML , , Julia Lawall Date: Thu, 20 Nov 2014 05:22:37 +0100 Message-ID: <149cb7002e0.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> In-Reply-To: <546CCB7E.3050109@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CCB7E.3050109@users.sourceforge.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 AquaMail/1.5.0.19 (build: 2100846) Subject: Re: [PATCH 1/1] DRM-vmwgfx: Deletion of an unnecessary check before the function call "vfree" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On November 19, 2014 5:57:13 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Nov 2014 17:50:19 +0100 > > The vfree() function performes also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 14b2f50..f9a67b8 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -889,8 +889,7 @@ static int vmw_driver_unload(struct drm_device *dev) > > if (dev_priv->ctx.res_ht_initialized) > drm_ht_remove(&dev_priv->ctx.res_ht); > - if (dev_priv->ctx.cmd_bounce) > - vfree(dev_priv->ctx.cmd_bounce); > + vfree(dev_priv->ctx.cmd_bounce); > if (dev_priv->enable_fb) { > vmw_fb_close(dev_priv); > vmw_kms_restore_vga(dev_priv); Reviewed-by: Thierry Reding From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Thu, 20 Nov 2014 04:22:37 +0000 Subject: Re: [PATCH 1/1] DRM-vmwgfx: Deletion of an unnecessary check before the function call "vfree" Message-Id: <149cb7002e0.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CCB7E.3050109@users.sourceforge.net> In-Reply-To: <546CCB7E.3050109@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , David Airlie , dri-devel@lists.freedesktop.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML On November 19, 2014 5:57:13 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 19 Nov 2014 17:50:19 +0100 > > The vfree() function performes also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 14b2f50..f9a67b8 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -889,8 +889,7 @@ static int vmw_driver_unload(struct drm_device *dev) > > if (dev_priv->ctx.res_ht_initialized) > drm_ht_remove(&dev_priv->ctx.res_ht); > - if (dev_priv->ctx.cmd_bounce) > - vfree(dev_priv->ctx.cmd_bounce); > + vfree(dev_priv->ctx.cmd_bounce); > if (dev_priv->enable_fb) { > vmw_fb_close(dev_priv); > vmw_kms_restore_vga(dev_priv); Reviewed-by: Thierry Reding From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/1] DRM-vmwgfx: Deletion of an unnecessary check before the function call "vfree" Date: Thu, 20 Nov 2014 05:22:37 +0100 Message-ID: <149cb7002e0.2771.879d79c6f3490faa837fa11cb97f42bf@gmail.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CCB7E.3050109@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id DBE226E10B for ; Wed, 19 Nov 2014 20:22:42 -0800 (PST) Received: by mail-wi0-f178.google.com with SMTP id hi2so4013110wib.5 for ; Wed, 19 Nov 2014 20:22:42 -0800 (PST) In-Reply-To: <546CCB7E.3050109@users.sourceforge.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: SF Markus Elfring , David Airlie , dri-devel@lists.freedesktop.org Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org T24gTm92ZW1iZXIgMTksIDIwMTQgNTo1NzoxMyBQTSBTRiBNYXJrdXMgRWxmcmluZyAKPGVsZnJp bmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PiB3cm90ZToKPiBGcm9tOiBNYXJrdXMgRWxmcmluZyA8 ZWxmcmluZ0B1c2Vycy5zb3VyY2Vmb3JnZS5uZXQ+Cj4gRGF0ZTogV2VkLCAxOSBOb3YgMjAxNCAx Nzo1MDoxOSArMDEwMAo+Cj4gVGhlIHZmcmVlKCkgZnVuY3Rpb24gcGVyZm9ybWVzIGFsc28gaW5w dXQgcGFyYW1ldGVyIHZhbGlkYXRpb24uIFRodXMgdGhlIHRlc3QKPiBhcm91bmQgdGhlIGNhbGwg aXMgbm90IG5lZWRlZC4KPgo+IFRoaXMgaXNzdWUgd2FzIGRldGVjdGVkIGJ5IHVzaW5nIHRoZSBD b2NjaW5lbGxlIHNvZnR3YXJlLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVs ZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vdm13 Z2Z4L3Ztd2dmeF9kcnYuYyB8IDMgKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdm13Z2Z4 L3Ztd2dmeF9kcnYuYyAKPiBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2Rydi5jCj4g aW5kZXggMTRiMmY1MC4uZjlhNjdiOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdm13 Z2Z4L3Ztd2dmeF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2Ry di5jCj4gQEAgLTg4OSw4ICs4ODksNyBAQCBzdGF0aWMgaW50IHZtd19kcml2ZXJfdW5sb2FkKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4KPiAgCWlmIChkZXZfcHJpdi0+Y3R4LnJlc19odF9pbml0 aWFsaXplZCkKPiAgCQlkcm1faHRfcmVtb3ZlKCZkZXZfcHJpdi0+Y3R4LnJlc19odCk7Cj4gLQlp ZiAoZGV2X3ByaXYtPmN0eC5jbWRfYm91bmNlKQo+IC0JCXZmcmVlKGRldl9wcml2LT5jdHguY21k X2JvdW5jZSk7Cj4gKwl2ZnJlZShkZXZfcHJpdi0+Y3R4LmNtZF9ib3VuY2UpOwo+ICAJaWYgKGRl dl9wcml2LT5lbmFibGVfZmIpIHsKPiAgCQl2bXdfZmJfY2xvc2UoZGV2X3ByaXYpOwo+ICAJCXZt d19rbXNfcmVzdG9yZV92Z2EoZGV2X3ByaXYpOwoKUmV2aWV3ZWQtYnk6IFRoaWVycnkgUmVkaW5n IDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK