From mboxrd@z Thu Jan 1 00:00:00 1970 From: Connor Behan Subject: Re: [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN Date: Thu, 25 Aug 2016 12:37:06 -0400 Message-ID: <149d75f3-ba1a-b289-6b9e-9fd0f37e7bde@gmail.com> References: <20160804080657.9664-1-dh.herrmann@gmail.com> <20160804080657.9664-2-dh.herrmann@gmail.com> <20160804081507.GL12611@nuc-i3427.alporthouse.com> <20160825111406.GQ10980@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2126485261==" Return-path: Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1E276E04E for ; Thu, 25 Aug 2016 20:35:08 +0000 (UTC) Received: by mail-qk0-x242.google.com with SMTP id o1so4458733qkd.2 for ; Thu, 25 Aug 2016 13:35:08 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , Emil Velikov Cc: Daniel Vetter , ML dri-devel , Kevin Brace List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2126485261== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q5FXklBL9ahpIOMxL5QbWO28gxArEDOSA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --q5FXklBL9ahpIOMxL5QbWO28gxArEDOSA Content-Type: multipart/mixed; boundary="pDLJq2f6hO6wBJPtui70grfRQx3AgWxgJ" From: Connor Behan To: Alex Deucher , Emil Velikov Cc: Daniel Vetter , Daniel Vetter , ML dri-devel , Kevin Brace Message-ID: <149d75f3-ba1a-b289-6b9e-9fd0f37e7bde@gmail.com> Subject: Re: [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN References: <20160804080657.9664-1-dh.herrmann@gmail.com> <20160804080657.9664-2-dh.herrmann@gmail.com> <20160804081507.GL12611@nuc-i3427.alporthouse.com> <20160825111406.GQ10980@phenom.ffwll.local> In-Reply-To: --pDLJq2f6hO6wBJPtui70grfRQx3AgWxgJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25/08/16 11:13 AM, Alex Deucher wrote: > On Thu, Aug 25, 2016 at 11:04 AM, Emil Velikov > wrote: >> On 25 August 2016 at 12:14, Daniel Vetter wrote: >>> On Thu, Aug 04, 2016 at 09:15:07AM +0100, Chris Wilson wrote: >>>> On Thu, Aug 04, 2016 at 10:06:57AM +0200, David Herrmann wrote: >>>>> The legacy DRI1 drivers expose highly broken interfaces to user-spa= ce. No >>>>> modern system should enable them, or you will effectively allow use= r-space >>>>> to circumvent most of your kernel security measures. The DRI1 kerne= l APIs >>>>> are simply broken. >>>>> >>>>> User-space can always use vesafb/efifb/simplefb and friends to get = working >>>>> graphics. >>>>> >>>>> Lets hide the old drivers behind CONFIG_BROKEN. In case they turn o= ut to >>>>> be still used (really?), we can easily revert this and figure out a= way to >>>>> move them out of sight (e.g., moving all DRI1 drivers to >>>>> drivers/gpu/dri1/). >>>>> >>>>> Signed-off-by: David Herrmann >>>> Acked-by: Chris Wilson >>>> >>>> I'd rather have a couple of distro devs check if they are still usin= g >>>> any of these, and would value their a-b/r-b. >>> Mesa stopped shipping dri1 drivers years ago, and neither Fedora and >>> Debian here have that old version packaged (it should keep working si= nce >>> the dri loader is an ABI). I don't think anyone needs this, and if I'= m >>> wrong we'll hear about it ;-) >>> >> Archlinux (which seems to be picking more users) is still shipping >> dri1 drivers - both mesa and X. No idea for many actually use those >> and/or for how much longer the packages will be around. >> >> IIRC the maintainer, Connor, used to hack on the xf86-video-r128 with >> plans(?) on getting things KMS aware. Not sure if that was by >> extending the existing radeon kernel, ddx, mesa driver(s) or >> otherwise. >> Connor, can you shed some light ? >> > r128 is 90% the same as early radeons so it would make sense to add > support to radeon. > > Alex Ccing Kevin Brace. The drivers were removed from mesa and "you won't have to freeze your kernel or anything" was one of the justifications given at the time for why this wasn't a bad idea. So yes, I have dri1 packages in the Archlinux repos with no plans to drop them. The people who have emailed me about them and filed bugs are probably much less than 1% of the user base but I've never considered that relevant. The point is that hobbyists who want to use old hardware or play with seldomly updated drivers should be able to do this without too many additional hurdles. AFAIK the drivers still work as well as they did in the late 90s. And it's easy for security conscious people to not modprobe them. My -1 would probably mean more if I were still following my initial plans of adding r128 support to the radeon kernel module but at some point while reading documentation I lost motivation. Hopefully this is temporary. --pDLJq2f6hO6wBJPtui70grfRQx3AgWxgJ-- --q5FXklBL9ahpIOMxL5QbWO28gxArEDOSA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXvx64AAoJENU6BEW0eg2rYesH/0AjHyprgyywr+QU7H+cCMxI 1ZhD9H2ImOWPWSs1zwx6qEmF40V1QxJFSp+arasMvsIMpE1seshPlsSngKj6hqJv PYGa5N7pYSzBQlQP4zhLsbhvKzw5YvI+DkNsI7BOFcmHk8JmmG79BbKqCPSQ5ADU FE2pebBCtD+CJTXF24+qiyUt4L6gXZJmW9NwcgiJEwdnoIBKEexllaJyqqSTgtT1 A++0Nz5rPowBvcOJRLWPuQDO5QoqLhMf3B5/Xmp+HFhO7DyQkmR8QcGeRb7xB6XY frRpREGuJy94URQzPRhTHnDteq/o+mEsIkleGfGKlWHENWF/fBqEi70Is8a0Y14= =W56K -----END PGP SIGNATURE----- --q5FXklBL9ahpIOMxL5QbWO28gxArEDOSA-- --===============2126485261== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2126485261==--