All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH] btrfs: copy fsid to super_block s_uuid
Date: Wed, 2 Aug 2017 14:02:11 +0800	[thread overview]
Message-ID: <14c243df-4532-33ab-7e72-89de96f19b2e@oracle.com> (raw)
In-Reply-To: <20170801153644.GA4457@magnolia>


Hi Darrick,

  Thanks for commenting..

>> +	memcpy(&sb->s_uuid, fs_info->fsid, BTRFS_FSID_SIZE);
> 
> uuid_copy()?

   It requires a larger migration to use uuid_t, IMO it can be done all
   together, in a separate patch ?

   Just for experiment, starting with struct btrfs_fs_info.fsid and
   to check its foot prints, I just renamed fsid to fs_id, and compiled.
   It reports 73 'has no member named ‘fsid'' errors.
   So looks like redefining u8 fsid[] to uuid_t fsid and further updating
   all its foot prints, has to be simplified. Any suggestions ?

Thanks, Anand


  reply	other threads:[~2017-08-02  5:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 10:35 [PATCH] btrfs: copy fsid to super_block s_uuid Anand Jain
2017-08-01 15:36 ` Darrick J. Wong
2017-08-02  6:02   ` Anand Jain [this message]
2017-08-02 17:47     ` Darrick J. Wong
2017-08-16 15:40 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14c243df-4532-33ab-7e72-89de96f19b2e@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=darrick.wong@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.