From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH net-next v6 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll() Date: Tue, 24 Jul 2018 11:53:08 +0900 Message-ID: <14d01d2d-0eb8-172b-1c53-7dadc5fffbac@lab.ntt.co.jp> References: <1532196242-2998-1-git-send-email-xiangxia.m.yue@gmail.com> <1532196242-2998-4-git-send-email-xiangxia.m.yue@gmail.com> <2b0efbf4-09e2-0ee9-091f-e2d9e10483a1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Linux Kernel Network Developers , toshiaki.makita1@gmail.com, virtualization@lists.linux-foundation.org, mst@redhat.com To: Tonghao Zhang Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org T24gMjAxOC8wNy8yNCAyOjMxLCBUb25naGFvIFpoYW5nIHdyb3RlOgo+IE9uIE1vbiwgSnVsIDIz LCAyMDE4IGF0IDEwOjIwIFBNIFRvc2hpYWtpIE1ha2l0YQo+IDx0b3NoaWFraS5tYWtpdGExQGdt YWlsLmNvbT4gd3JvdGU6Cj4+Cj4+IE9uIDE4LzA3LzIzICjmnIgpIDIxOjQzLCBUb25naGFvIFpo YW5nIHdyb3RlOgo+Pj4gT24gTW9uLCBKdWwgMjMsIDIwMTggYXQgNTo1OCBQTSBUb3NoaWFraSBN YWtpdGEKPj4+IDxtYWtpdGEudG9zaGlha2lAbGFiLm50dC5jby5qcD4gd3JvdGU6Cj4+Pj4KPj4+ PiBPbiAyMDE4LzA3LzIyIDM6MDQsIHhpYW5neGlhLm0ueXVlQGdtYWlsLmNvbSB3cm90ZToKPj4+ Pj4gRnJvbTogVG9uZ2hhbyBaaGFuZyA8eGlhbmd4aWEubS55dWVAZ21haWwuY29tPgo+Pj4+Pgo+ Pj4+PiBGYWN0b3Igb3V0IGdlbmVyaWMgYnVzeSBwb2xsaW5nIGxvZ2ljIGFuZCB3aWxsIGJlCj4+ Pj4+IHVzZWQgZm9yIGluIHR4IHBhdGggaW4gdGhlIG5leHQgcGF0Y2guIEFuZCB3aXRoIHRoZSBw YXRjaCwKPj4+Pj4gcWVtdSBjYW4gc2V0IGRpZmZlcmVudGx5IHRoZSBidXN5bG9vcF90aW1lb3V0 IGZvciByeCBxdWV1ZS4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogVG9uZ2hhbyBaaGFuZyA8 eGlhbmd4aWEubS55dWVAZ21haWwuY29tPgo+Pj4+PiAtLS0KPj4+PiAuLi4KPj4+Pj4gK3N0YXRp YyB2b2lkIHZob3N0X25ldF9idXN5X3BvbGxfdnFfY2hlY2soc3RydWN0IHZob3N0X25ldCAqbmV0 LAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qgdmhv c3RfdmlydHF1ZXVlICpydnEsCj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0cnVjdCB2aG9zdF92aXJ0cXVldWUgKnR2cSwKPj4+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCByeCkKPj4+Pj4gK3sKPj4+Pj4gKyAgICAgc3Ry dWN0IHNvY2tldCAqc29jayA9IHJ2cS0+cHJpdmF0ZV9kYXRhOwo+Pj4+PiArCj4+Pj4+ICsgICAg IGlmIChyeCkgewo+Pj4+PiArICAgICAgICAgICAgIGlmICghdmhvc3RfdnFfYXZhaWxfZW1wdHko Jm5ldC0+ZGV2LCB0dnEpKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgICB2aG9zdF9wb2xs X3F1ZXVlKCZ0dnEtPnBvbGwpOwo+Pj4+PiArICAgICAgICAgICAgIH0gZWxzZSBpZiAodW5saWtl bHkodmhvc3RfZW5hYmxlX25vdGlmeSgmbmV0LT5kZXYsIHR2cSkpKSB7Cj4+Pj4+ICsgICAgICAg ICAgICAgICAgICAgICB2aG9zdF9kaXNhYmxlX25vdGlmeSgmbmV0LT5kZXYsIHR2cSk7Cj4+Pj4+ ICsgICAgICAgICAgICAgICAgICAgICB2aG9zdF9wb2xsX3F1ZXVlKCZ0dnEtPnBvbGwpOwo+Pj4+ PiArICAgICAgICAgICAgIH0KPj4+Pj4gKyAgICAgfSBlbHNlIGlmICgoc29jayAmJiBza19oYXNf cnhfZGF0YShzb2NrLT5zaykpICYmCj4+Pj4+ICsgICAgICAgICAgICAgICAgICF2aG9zdF92cV9h dmFpbF9lbXB0eSgmbmV0LT5kZXYsIHJ2cSkpIHsKPj4+Pj4gKyAgICAgICAgICAgICB2aG9zdF9w b2xsX3F1ZXVlKCZydnEtPnBvbGwpOwo+Pj4+Cj4+Pj4gTm93IHdlIHdhaXQgZm9yIHZxX2F2YWls IGZvciByeCBhcyB3ZWxsLCBJIHRoaW5rIHlvdSBjYW5ub3Qgc2tpcAo+Pj4+IHZob3N0X2VuYWJs ZV9ub3RpZnkoKSBvbiB0eC4gUHJvYmFibHkgeW91IG1pZ2h0IHdhbnQgdG8gZG86Cj4+PiBJIHRo aW5rIHZob3N0X2VuYWJsZV9ub3RpZnkgaXMgbmVlZGVkLgo+Pj4KPj4+PiB9IGVsc2UgaWYgKHNv Y2sgJiYgc2tfaGFzX3J4X2RhdGEoc29jay0+c2spKSB7Cj4+Pj4gICAgICAgICAgaWYgKCF2aG9z dF92cV9hdmFpbF9lbXB0eSgmbmV0LT5kZXYsIHJ2cSkpIHsKPj4+PiAgICAgICAgICAgICAgICAg IHZob3N0X3BvbGxfcXVldWUoJnJ2cS0+cG9sbCk7Cj4+Pj4gICAgICAgICAgfSBlbHNlIGlmICh1 bmxpa2VseSh2aG9zdF9lbmFibGVfbm90aWZ5KCZuZXQtPmRldiwgcnZxKSkpIHsKPj4+PiAgICAg ICAgICAgICAgICAgIHZob3N0X2Rpc2FibGVfbm90aWZ5KCZuZXQtPmRldiwgcnZxKTsKPj4+PiAg ICAgICAgICAgICAgICAgIHZob3N0X3BvbGxfcXVldWUoJnJ2cS0+cG9sbCk7Cj4+Pj4gICAgICAg ICAgfQo+Pj4+IH0KPj4+IEFzIEphc29uIHJldmlldyBhcyBiZWZvcmUsIHdlIG9ubHkgd2FudCBy eCBraWNrIHdoZW4gcGFja2V0IGlzIHBlbmRpbmcgYXQKPj4+IHNvY2tldCBidXQgd2UncmUgb3V0 IG9mIGF2YWlsYWJsZSBidWZmZXJzLiBTbyB3ZSBqdXN0IGVuYWJsZSBub3RpZnksCj4+PiBidXQg bm90IHBvbGwgaXQgPwo+Pj4KPj4+ICAgICAgICAgIH0gZWxzZSBpZiAoKHNvY2sgJiYgc2tfaGFz X3J4X2RhdGEoc29jay0+c2spKSAmJgo+Pj4gICAgICAgICAgICAgICAgICAgICAgIXZob3N0X3Zx X2F2YWlsX2VtcHR5KCZuZXQtPmRldiwgcnZxKSkgewo+Pj4gICAgICAgICAgICAgICAgICB2aG9z dF9wb2xsX3F1ZXVlKCZydnEtPnBvbGwpOwo+Pj4gICAgICAgICAgZWxzZSB7Cj4+PiAgICAgICAg ICAgICAgICAgIHZob3N0X2VuYWJsZV9ub3RpZnkoJm5ldC0+ZGV2LCBydnEpOwo+Pj4gICAgICAg ICAgfQo+Pgo+PiBXaGVuIHZob3N0X2VuYWJsZV9ub3RpZnkoKSByZXR1cm5zIHRydWUgdGhlIGF2 YWlsIGJlY29tZXMgbm9uLWVtcHR5Cj4+IHdoaWxlIHdlIGFyZSBlbmFibGluZyBub3RpZnkuIFdl IG1heSBkZWxheSB0aGUgcnggcHJvY2VzcyBpZiB3ZSBkb24ndAo+PiBjaGVjayB0aGUgcmV0dXJu IHZhbHVlIG9mIHZob3N0X2VuYWJsZV9ub3RpZnkoKS4KPiBJIGdvdCBpdCB0aGFua3MuCj4+Pj4g QWxzbyBpdCdzIGJldHRlciB0byBjYXJlIHZob3N0X25ldF9kaXNhYmxlX3ZxKCkvdmhvc3RfbmV0 X2VuYWJsZV92cSgpIG9uIHR4Pwo+Pj4gSSBjYW50IGZpbmQgd2h5IGl0IGlzIGJldHRlciwgaWYg bmVjZXNzYXJ5LCB3ZSBjYW4gZG8gaXQuCj4+Cj4+IFRoZSByZWFzb24gaXMgcHJldHR5IHNpbXBs ZS4uLiB3ZSBhcmUgYnVzeXBvbGxpbmcgdGhlIHNvY2tldCBzbyB3ZSBkb24ndAo+PiBuZWVkIHJ4 IHdha2V1cHMgZHVyaW5nIGl0Pwo+IE9LLCBidXQgb25lIHF1ZXN0aW9uLCBob3cgYWJvdXQgcng/ IGRvIHdlIHVzZSB0aGUKPiB2aG9zdF9uZXRfZGlzYWJsZV92cS92aG9zdF9uZXRfZW5zYWJsZV92 cSBvbiByeCA/CgpJZiB3ZSBhcmUgYnVzeXBvbGxpbmcgdGhlIHNvY2sgdHggYnVmPyBJJ20gbm90 IHN1cmUgaWYgcG9sbGluZyBpdAppbXByb3ZlcyB0aGUgcGVyZm9ybWFuY2UuCgotLSAKVG9zaGlh a2kgTWFraXRhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgt Zm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4v bGlzdGluZm8vdmlydHVhbGl6YXRpb24=