From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B58C2D0C0 for ; Wed, 1 Jan 2020 04:00:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3972A206DA for ; Wed, 1 Jan 2020 04:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgAAEAx (ORCPT ); Tue, 31 Dec 2019 23:00:53 -0500 Received: from mga18.intel.com ([134.134.136.126]:39804 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727036AbgAAEAx (ORCPT ); Tue, 31 Dec 2019 23:00:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Dec 2019 20:00:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,381,1571727600"; d="scan'208";a="244308518" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 31 Dec 2019 20:00:50 -0800 Cc: baolu.lu@linux.intel.com, Bjorn Helgaas , Lorenzo Pieralisi , Keith Busch , Joerg Roedel , Christoph Hellwig , David Woodhouse Subject: Re: [RFC 1/5] iommu: Remove device link to group on failure To: Jon Derrick , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org References: <1577823863-3303-1-git-send-email-jonathan.derrick@intel.com> <1577823863-3303-2-git-send-email-jonathan.derrick@intel.com> From: Lu Baolu Message-ID: <14d024e0-42df-12ae-0571-bd27b26166b7@linux.intel.com> Date: Wed, 1 Jan 2020 11:59:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1577823863-3303-2-git-send-email-jonathan.derrick@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, On 1/1/20 4:24 AM, Jon Derrick wrote: > This adds the missing teardown step that removes the device link from > the group when the device addition fails. This change looks good to me. Reviewed-by: Lu Baolu Best regards, baolu > > Signed-off-by: Jon Derrick > --- > drivers/iommu/iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index d5174f0..3e35284 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -768,6 +768,7 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev) > mutex_unlock(&group->mutex); > dev->iommu_group = NULL; > kobject_put(group->devices_kobj); > + sysfs_remove_link(group->devices_kobj, device->name); > err_free_name: > kfree(device->name); > err_remove_link: > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A3BC2D0C0 for ; Wed, 1 Jan 2020 04:00:57 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8BF2206DA for ; Wed, 1 Jan 2020 04:00:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8BF2206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 665B984B8F; Wed, 1 Jan 2020 04:00:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8fTNTxg7vn3Q; Wed, 1 Jan 2020 04:00:54 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id A21FE846AD; Wed, 1 Jan 2020 04:00:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 86F34C1D81; Wed, 1 Jan 2020 04:00:54 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 507EDC077D for ; Wed, 1 Jan 2020 04:00:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 3746B204A2 for ; Wed, 1 Jan 2020 04:00:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HJm-PH8rVBiQ for ; Wed, 1 Jan 2020 04:00:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by silver.osuosl.org (Postfix) with ESMTPS id 9214A20441 for ; Wed, 1 Jan 2020 04:00:52 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Dec 2019 20:00:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,381,1571727600"; d="scan'208";a="244308518" Received: from allen-box.sh.intel.com (HELO [10.239.159.136]) ([10.239.159.136]) by fmsmga004.fm.intel.com with ESMTP; 31 Dec 2019 20:00:50 -0800 Subject: Re: [RFC 1/5] iommu: Remove device link to group on failure To: Jon Derrick , iommu@lists.linux-foundation.org, linux-pci@vger.kernel.org References: <1577823863-3303-1-git-send-email-jonathan.derrick@intel.com> <1577823863-3303-2-git-send-email-jonathan.derrick@intel.com> From: Lu Baolu Message-ID: <14d024e0-42df-12ae-0571-bd27b26166b7@linux.intel.com> Date: Wed, 1 Jan 2020 11:59:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1577823863-3303-2-git-send-email-jonathan.derrick@intel.com> Content-Language: en-US Cc: Bjorn Helgaas , Keith Busch , David Woodhouse , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi, On 1/1/20 4:24 AM, Jon Derrick wrote: > This adds the missing teardown step that removes the device link from > the group when the device addition fails. This change looks good to me. Reviewed-by: Lu Baolu Best regards, baolu > > Signed-off-by: Jon Derrick > --- > drivers/iommu/iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index d5174f0..3e35284 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -768,6 +768,7 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev) > mutex_unlock(&group->mutex); > dev->iommu_group = NULL; > kobject_put(group->devices_kobj); > + sysfs_remove_link(group->devices_kobj, device->name); > err_free_name: > kfree(device->name); > err_remove_link: > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu