From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0ECC77B7A for ; Thu, 1 Jun 2023 06:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbjFAGmV (ORCPT ); Thu, 1 Jun 2023 02:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbjFAGmU (ORCPT ); Thu, 1 Jun 2023 02:42:20 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13496184 for ; Wed, 31 May 2023 23:42:16 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-96fbe7fbdd4so54632966b.3 for ; Wed, 31 May 2023 23:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685601734; x=1688193734; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ANMyuQNsEPiF3QmDOiOhBLvKIIT27fWFnUKpORZrZFw=; b=ggtn9YySWdXvGrl85dcClMiC4+V1v1mqF11/6CQ+6dJ1lklKIHR73dJ7mVcp/QxxIQ /xdx8h+2OS6ricRnu8tSxMMLAzo7rd3Z4G7TB7wyvIlghny2osCznIfUsRl3cFzZpycg 8QWJHmeA+RHG3daSf3sppVfBVYNdBAPwyas61MqbUfXvqT84ZmCZEC4127Sc1BCWemD+ r/nQr6IsDNQafD79CUDqH4BLGjHQFBmHH/W77T40PrORsTSiBathnYRDYzP7RK2ukaTU +P+HYPylSQf/yfYwwiJVn0BcHvvuxOaoBlXb6pHy+4C9zWR7DsZjk4coKv5AOZ6D7HH0 nYiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685601734; x=1688193734; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ANMyuQNsEPiF3QmDOiOhBLvKIIT27fWFnUKpORZrZFw=; b=NQYzMxfD0RM0ICUUgjN9GQgRMTCuOnVyJbWjZBNZ9ZG8uXcZf6gYlYjuhi4hLjg9aR 25qtVgJBEr7ZRj7xm8dFLeeLZubTl7d3uDLEB69Ez/mhOwT44/hwN8HzYij/uy81HtD4 t9crHrj8L0Sq/5O1nKq3NMf/rWByT8k+PDu1DNn4CRrLGynBwlegtlNnbakeAYYN3upM Ac2ifs7xnVKasiuJK23SxWu0rxaAW6oqKqGHXmSpaN7pI2ehn1sK5Fyj4mP+qu2Jhy0R 3lboEOiBTT7VvM/RLbXzEDUXVy31qVH91D2+zZbkkkub+WEd+PWclavUjW140YWsPbZ8 vrng== X-Gm-Message-State: AC+VfDygv50ZSrfWyIhucaGSdlWso+3pbL02QbjZLkH+/wotVi/yIOi2 hrUtsyVb13zjGu/OLqY3pm/6yg== X-Google-Smtp-Source: ACHHUZ66nv9NTyqbJPI7nFOnwMxBePXKep1wFvXa6V6HAWyh9Su1v4eq7DXY5+5fNbc53Pd+4P/dGw== X-Received: by 2002:a17:907:3f1c:b0:970:d85:59e9 with SMTP id hq28-20020a1709073f1c00b009700d8559e9mr6969993ejc.5.1685601734515; Wed, 31 May 2023 23:42:14 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id f19-20020a170906139300b0095fd0462695sm9994101ejc.5.2023.05.31.23.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 23:42:14 -0700 (PDT) Message-ID: <14df9815-3c3a-5adf-b8ca-01ea5cf89bfd@linaro.org> Date: Thu, 1 Jun 2023 08:42:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 06/43] dt-bindings: pinctrl: Add Cirrus EP93xx Content-Language: en-US To: Nikita Shubin , Alexander Sverdlin , Arnd Bergmann , Linus Walleij , Rob Herring , Krzysztof Kozlowski Cc: Michael Peters , Kris Bahnsen , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601053546.9574-7-nikita.shubin@maquefel.me> From: Krzysztof Kozlowski In-Reply-To: <20230601053546.9574-7-nikita.shubin@maquefel.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 01/06/2023 07:33, Nikita Shubin wrote: > Add YAML bindings for ep93xx SoC pinctrl. > > Signed-off-by: Nikita Shubin > Reviewed-by: Linus Walleij > --- > > Notes: > v0 -> v1: > > Krzysztof Kozlowski: > - removed wildcards > - use fallback compatible and list all possible compatibles > - fix ident > - dropped bindings in title > > .../pinctrl/cirrus,ep9301-pinctrl.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/cirrus,ep9301-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,ep9301-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,ep9301-pinctrl.yaml > new file mode 100644 > index 000000000000..ff7b30a11bab > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,ep9301-pinctrl.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/cirrus,ep9301-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus ep93xx pins mux controller > + > +maintainers: > + - Nikita Shubin > + - Alexander Sverdlin > + > +properties: > + compatible: > + oneOf: > + - const: cirrus,ep9301-pinctrl > + - items: > + - enum: > + - cirrus,ep9302-pinctrl > + - cirrus,ep9307-pinctrl > + - cirrus,ep9312-pinctrl > + - cirrus,ep9315-pinctrl > + - const: cirrus,ep9301-pinctrl > + > +patternProperties: > + '^pins-': > + type: object > + description: pin node > + $ref: pinmux-node.yaml# > + > + properties: > + function: > + enum: [ spi, ac97, i2s, pwm, keypad, pata, lcd, gpio ] Blank line. > + groups: > + minItems: 1 > + maxItems: 2 How one pin can belong to two groups? What does it mean? > + items: > + enum: [ ssp, ac97, i2s_on_ssp, i2s_on_ac97, pwm1, gpio1agrp, > + gpio2agrp, gpio3agrp, gpio4agrp, gpio6agrp, gpio7agrp, > + rasteronsdram0grp, rasteronsdram3grp, keypadgrp, idegrp] > + > + required: > + - function > + - groups > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + syscon@80930000 { > + compatible = "cirrus,ep9301-syscon", > + "syscon", "simple-mfd"; Weird wrapping. > + reg = <0x80930000 0x1000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + pinctrl { > + compatible = "cirrus,ep9312-pinctrl", "cirrus,ep9301-pinctrl"; > + spi_default_pins: pins-spi { > + function = "spi"; > + groups = "ssp"; > + }; > + }; > + }; Best regards, Krzysztof