All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Dirk Behme <dirk.behme@de.bosch.com>, linux-renesas-soc@vger.kernel.org
Cc: geert+renesas@glider.be, Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] ravb: Fix RAVB_RXTSTAMP_TYPE_ALL value
Date: Thu, 9 Apr 2020 12:26:46 +0300	[thread overview]
Message-ID: <14e0c265-5cb6-0170-e673-8300eddc417c@cogentembedded.com> (raw)
In-Reply-To: <20200409061509.13385-1-dirk.behme@de.bosch.com>

Hello!

On 09.04.2020 9:15, Dirk Behme wrote:

> In the function ravb_hwtstamp_get() in ravb_main.c with the existing
> values for RAVB_RXTSTAMP_TYPE_V2_L2_EVENT (0x2) and RAVB_RXTSTAMP_TYPE_ALL
> (0x6)
> 
> if (priv->tstamp_rx_ctrl & RAVB_RXTSTAMP_TYPE_V2_L2_EVENT)
>          config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L2_EVENT;
> else if (priv->tstamp_rx_ctrl & RAVB_RXTSTAMP_TYPE_ALL)
>          config.rx_filter = HWTSTAMP_FILTER_ALL;
> 
> if the test on RAVB_RXTSTAMP_TYPE_ALL should be true, it will never
> be reached. Correct this by changing RAVB_RXTSTAMP_TYPE_ALL to 0x4.
> 
> While at it, drop two unused macros.

    Don't do 2 things in 1 patch, especially when you're doing a fix
and the other thing is a cleanup.

> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Reported-by: Julia Lawall <julia.lawall@inria.fr>
> Suggested-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
[...]

MBR, Sergei

      reply	other threads:[~2020-04-09  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  6:15 [PATCH] ravb: Fix RAVB_RXTSTAMP_TYPE_ALL value Dirk Behme
2020-04-09  9:26 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14e0c265-5cb6-0170-e673-8300eddc417c@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=geert+renesas@glider.be \
    --cc=julia.lawall@inria.fr \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.