From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Hanna Reitz <hreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v4 3/5] migrate-bitmaps-test: Fix pylint warnings
Date: Thu, 2 Sep 2021 12:53:11 +0300 [thread overview]
Message-ID: <14fcbe06-01ed-4069-9aa0-568fb6057036@virtuozzo.com> (raw)
In-Reply-To: <20210902094017.32902-4-hreitz@redhat.com>
02.09.2021 12:40, Hanna Reitz wrote:
> There are a couple of things pylint takes issue with:
> - The "time" import is unused
> - The import order (iotests should come last)
> - get_bitmap_hash() doesn't use @self and so should be a function
> - Semicolons at the end of some lines
> - Parentheses after "if"
> - Some lines are too long (80 characters instead of 79)
> - inject_test_case()'s @name parameter shadows a top-level @name
> variable
> - "lambda self: mc(self)" were equivalent to just "mc", but in
> inject_test_case(), it is not equivalent, so add a comment and disable
> the warning locally
> - Always put two empty lines after a function
> - f'exec: cat > /dev/null' does not need to be an f-string
>
> Fix them.
>
> Signed-off-by: Hanna Reitz<hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-09-02 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 9:40 [PATCH v4 0/5] iotests/297: Cover tests/ Hanna Reitz
2021-09-02 9:40 ` [PATCH v4 1/5] iotests/297: Drop 169 and 199 from the skip list Hanna Reitz
2021-09-02 9:40 ` [PATCH v4 2/5] migrate-bitmaps-postcopy-test: Fix pylint warnings Hanna Reitz
2021-09-02 9:40 ` [PATCH v4 3/5] migrate-bitmaps-test: " Hanna Reitz
2021-09-02 9:53 ` Vladimir Sementsov-Ogievskiy [this message]
2021-09-02 9:40 ` [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path Hanna Reitz
2021-09-02 9:58 ` Vladimir Sementsov-Ogievskiy
2021-09-02 10:15 ` Philippe Mathieu-Daudé
2021-09-07 9:57 ` Hanna Reitz
2021-09-07 10:23 ` Philippe Mathieu-Daudé
2021-09-02 9:40 ` [PATCH v4 5/5] iotests/297: Cover tests/ Hanna Reitz
2021-09-07 9:50 ` [PATCH v4 0/5] " Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14fcbe06-01ed-4069-9aa0-568fb6057036@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.