From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92345C43334 for ; Thu, 9 Jun 2022 08:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232458AbiFIIqP (ORCPT ); Thu, 9 Jun 2022 04:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242899AbiFIIoH (ORCPT ); Thu, 9 Jun 2022 04:44:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B948848E77 for ; Thu, 9 Jun 2022 01:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654764154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EUXb3OtLQfesjMR2aTZtn/nYj0py51rPllhsatp6KLg=; b=GlRgmtA9FltEeNshMH2bUNGKhp7yESUkwxthDcyY+hqZqHWrgGva6c43TFPFyMlxGt4fcg cN+VjJbdAEfvCqchfwgdHhZVKKQiC1QEU0RoVq+Ioera6joduex6fWQSB0cV2ZmKZcNMSc pcWowEoshNyg6DbTZDvV71fYkkdDMRw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-YirucgYSN4ahW-0rrOfVLg-1; Thu, 09 Jun 2022 04:42:33 -0400 X-MC-Unique: YirucgYSN4ahW-0rrOfVLg-1 Received: by mail-wm1-f69.google.com with SMTP id h189-20020a1c21c6000000b0039c65f0e4ccso1274989wmh.2 for ; Thu, 09 Jun 2022 01:42:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:cc:from:subject:in-reply-to :content-transfer-encoding; bh=EUXb3OtLQfesjMR2aTZtn/nYj0py51rPllhsatp6KLg=; b=Px+6ypYqlVTYwL/ELaE9/g882ZeRLmMSNaym/aZW7G73ceW1ZUx4MsNfd/3MXeozEg /8KkN0ixcAm8foMa+FHzIC+v9UXN9dJUpWqZBDWzJROAeqdNUGDnhVdyVnSuxL6Lmcr4 mMcOfVecBBGjnKoutCX022DSmy9P1TuwyfJyrPMK5VhKmmV3sHoxaDHrtIL/m23MPuDp EnQiWEkNJcMNLKZazta+9SEDSUM7/XSIuar0HTEP3+HQMfMeWs+Cjdu5MIKvC0pJ4TCH knbo+yfcT05z0/JVY9CV45dXa4bG8KAeqEmdsHagnOtgyCoHQQodvPe1vSNuLDPn9riy VnTQ== X-Gm-Message-State: AOAM5335cIjoJiDFqk2njiO5KLrzpET87k9jCXzWLSM9s/EZW79XNmJ0 KkEjoIILAid8B+zGjCMD29Ksnf7/6Ax0alPTgTT4NfZTuMHIn8u5Nrj0hye0IAPl7EZRPApw2wL YSFCBFFlZAt3vGl1Ns7B9yYj2 X-Received: by 2002:a5d:6a92:0:b0:210:3387:23ec with SMTP id s18-20020a5d6a92000000b00210338723ecmr36882994wru.102.1654764152228; Thu, 09 Jun 2022 01:42:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX9SiYs8CeGshCq+oyK5c43j3U3DoJlGXVyZq/2+VB9rKnOKT+FGzdzTsJffnB4AR11tXK4Q== X-Received: by 2002:a5d:6a92:0:b0:210:3387:23ec with SMTP id s18-20020a5d6a92000000b00210338723ecmr36882976wru.102.1654764152035; Thu, 09 Jun 2022 01:42:32 -0700 (PDT) Received: from [192.168.0.3] (ip-109-42-115-130.web.vodafone.de. [109.42.115.130]) by smtp.gmail.com with ESMTPSA id k7-20020a7bc407000000b00397402ae674sm9284836wmi.11.2022.06.09.01.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 01:42:31 -0700 (PDT) Message-ID: <14fd32f1-1eb8-8eb3-972a-c1858ee6fdb7@redhat.com> Date: Thu, 9 Jun 2022 10:42:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Sean Christopherson , Paolo Bonzini , KVM References: <20220603004331.1523888-1-seanjc@google.com> <87wndr9qef.fsf@redhat.com> Cc: Cornelia Huck , Andrew Jones , Vitaly Kuznetsov , David Matlack , Ben Gardon , Oliver Upton , linux-kernel@vger.kernel.org From: Thomas Huth Subject: Re: [Sean Christopherson] [PATCH v2 000/144] KVM: selftests: Overhaul APIs, purge VCPU_ID In-Reply-To: <87wndr9qef.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3 Jun 2022 00:41, Sean Christopherson wrote: > > Overhaul KVM's selftest APIs to get selftests to a state where adding new > features and writing tests is less painful/disgusting. > > Patches 1 fixes a goof in kvm/queue and should be squashed. > > I would really, really, really like to get this queued up sooner than > later, or maybe just thrown into a separate selftests-specific branch that > folks can develop against. Rebasing is tedious, frustrating, and time > consuming. And spoiler alert, there's another 42 x86-centric patches > inbound that builds on this series to clean up CPUID related crud... > > The primary theme is to stop treating tests like second class citizens. > Stop hiding vcpu, kvm_vm, etc... There's no sensitive data/constructs, and > the encapsulation has led to really, really bad and difficult to maintain > code. E.g. having to pass around the VM just to call a vCPU ioctl(), > arbitrary non-zero vCPU IDs, tests having to care about the vCPU ID in the > first place, etc... > > The other theme in the rework is to deduplicate code and try to set us > up for success in the future. E.g. provide macros/helpers instead of > spamming CTRL-C => CTRL-V (see the -1k LoC), structure the VM creation > APIs to build on one another, etc... > > The absurd patch count (as opposed to just ridiculous) is due to converting > each test away from using hardcoded vCPU IDs in a separate patch. The vast > majority of those patches probably aren't worth reviewing in depth, the > changes are mostly mechanical in nature. > > However, _running_ non-x86 tests (or tests that have unique non-x86 > behavior) would be extremely valuable. All patches have been compile tested > on x86, arm, risc-v, and s390, but I've only run the tests on x86. Based on > my track record for the x86+common tests, I will be very, very surprised if > I didn't break any of the non-x86 tests, e.g. pthread_create()'s 'void *' > param tripped me up multiple times. Hi, I just checked your series on s390x, and as far as I can see, the tests still work fine with the patches applied. Thus: Tested-by: Thomas Huth