All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arkadi Sharshevsky <arkadis@mellanox.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
	f.fainelli@gmail.com, andrew@lunn.ch,
	vivien.didelot@savoirfairelinux.com, Woojung.Huh@microchip.com,
	stephen@networkplumber.org, mlxsw@mellanox.com,
	Arkadi Sharshevsky <arkadis@mellanox.com>
Subject: [PATCH net-next 06/11] net: dsa: Add support for querying supported bridge flags
Date: Tue, 18 Jul 2017 17:20:19 +0300	[thread overview]
Message-ID: <1500387624-4361-7-git-send-email-arkadis@mellanox.com> (raw)
In-Reply-To: <1500387624-4361-1-git-send-email-arkadis@mellanox.com>

The DSA drivers do not support bridge flags offload. Yet, this attribute
should be added in order for the bridge to fail when one tries set a
flag on the port, as explained in commit dc0ecabd6231 ("net: switchdev:
Add support for querying supported bridge flags by hardware").

Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
---
 net/dsa/slave.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index a083287..bf93fbc 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -324,6 +324,9 @@ static int dsa_slave_port_attr_get(struct net_device *dev,
 		attr->u.ppid.id_len = sizeof(ds->index);
 		memcpy(&attr->u.ppid.id, &ds->index, attr->u.ppid.id_len);
 		break;
+	case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT:
+		attr->u.brport_flags_support = 0;
+		break;
 	default:
 		return -EOPNOTSUPP;
 	}
-- 
2.4.11

  parent reply	other threads:[~2017-07-18 14:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 14:20 [PATCH net-next 00/11] Change DSA's FDB API and perform switchdev cleanup Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 01/11] net: dsa: Change DSA slave FDB API to be switchdev independent Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 02/11] net: dsa: Remove prepare phase for FDB Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 03/11] net: dsa: Remove switchdev dependency from DSA switch notifier chain Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 04/11] net: dsa: Add support for learning FDB through notification Arkadi Sharshevsky
2017-07-18 17:16   ` Vivien Didelot
2017-07-19 10:27     ` Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 05/11] net: dsa: Remove support for FDB add/del via SELF Arkadi Sharshevsky
2017-07-18 17:19   ` Vivien Didelot
2017-07-18 14:20 ` Arkadi Sharshevsky [this message]
2017-07-18 17:22   ` [PATCH net-next 06/11] net: dsa: Add support for querying supported bridge flags Vivien Didelot
2017-07-18 14:20 ` [PATCH net-next 07/11] net: dsa: Remove support for bypass bridge port attributes/vlan set Arkadi Sharshevsky
2017-07-18 17:40   ` Vivien Didelot
2017-07-19 11:53     ` Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 08/11] net: dsa: Remove redundant MDB dump support Arkadi Sharshevsky
2017-07-18 17:42   ` Vivien Didelot
2017-07-18 14:20 ` [PATCH net-next 09/11] net: dsa: Move FDB dump implementation inside DSA Arkadi Sharshevsky
2017-07-18 18:06   ` Vivien Didelot
2017-07-19 12:00     ` Arkadi Sharshevsky
2017-07-18 14:20 ` [PATCH net-next 10/11] net: bridge: Remove FDB deletion through switchdev object Arkadi Sharshevsky
2017-07-18 18:07   ` Vivien Didelot
2017-07-18 14:20 ` [PATCH net-next 11/11] net: switchdev: Remove bridge bypass support from switchdev Arkadi Sharshevsky
2017-07-18 18:11   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500387624-4361-7-git-send-email-arkadis@mellanox.com \
    --to=arkadis@mellanox.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.