From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754415AbdGXN2Z (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Jul 2017 09:28:25 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:37761 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753710AbdGXN2R (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Jul 2017 09:28:17 -0400
Message-ID: <1500902885.12695.0.camel@edumazet-glaptop3.roam.corp.google.com>
Subject: Re: [PATCH] Optimize int_sqrt for small values for faster idle
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        davidlohr.bueso@hp.com, rafael.j.wysocki@intel.com, lenb@kernel.org
Date: Mon, 24 Jul 2017 06:28:05 -0700
In-Reply-To: <20170720101001.kubsvi5mpzwp3ujd@hirez.programming.kicks-ass.net>
References: <1454017365-8509-1-git-send-email-andi@firstfloor.org>
         <87y4b4azsy.fsf@rasmusvillemoes.dk>
         <20160201213622.GA15302@tassilo.jf.intel.com>
         <87powgav0h.fsf@rasmusvillemoes.dk>
         <1454373398.7627.193.camel@edumazet-glaptop2.roam.corp.google.com>
         <20170720101001.kubsvi5mpzwp3ujd@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-07-20 at 12:10 +0200, Peter Zijlstra wrote:
> On Mon, Feb 01, 2016 at 04:36:38PM -0800, Eric Dumazet wrote:
> > On Tue, 2016-02-02 at 00:08 +0100, Rasmus Villemoes wrote:
> > 
> > > Thanks. (Is there a good way to tell gcc that avg*avg is actually a
> > > 32x32->64 multiplication?)
> > 
> > If avg is 32bit, compiler does that for you.
> > 
> > u32 avg = ...
> > 
> > u64 result = (u64)avg * avg;
> 
> It does not in fact do that :/ See commit:
> 
>   9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")

Interesting :/

Thanks for letting me know !