From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCBFCC433E0 for ; Thu, 25 Jun 2020 16:31:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4F6F20767 for ; Thu, 25 Jun 2020 16:31:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UKFtZWDW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="dDhj0N7C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4F6F20767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=um4UJQ2sJhSpTXASOMYJ7Nft4LPX1cX/WLh4O3fivNY=; b=UKFtZWDWjdf0FRbJOtYYtInUq KTKaz9fuNW/OKNvKhZt5op2Pjl8AIHX0VPo2DOwMjK4a5URnEkvc28RUWJ5Cx+/SKE9F1Fr7x0nLz x9Cn9doXyphR9HEqYvysAdrgAoxnXifErwigKufzTSKgrt2FfYutuSAoAniJbJKGJNGcLyNDdbpBk CL0d+xxwemgauJB/aQQljKe7p1JOCYUDxACh6GQETXcLThnpk+U4ZsZMxB4zVg9gXbZPCFFeRSL+0 Ry7HaLjR2LBukF8KHPQ0/GqnNri/HVpjlaEJ1CfEQNXgehDaoTxV0G4Pzb7UBuiE8oU4amuCBiwiL G8sVCKkwQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUkq-0003G7-DC; Thu, 25 Jun 2020 16:29:36 +0000 Received: from mout.web.de ([212.227.17.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUkk-0003Dq-K9 for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:29:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1593102568; bh=Wmxc1Sl9jqB6XId+hYYkwnOcjZSN/YGKtG2Nah/HecI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=dDhj0N7CVhvsSUGLhCLZUDsdL83WSVZ+wLL7JJ/bXMdx31GHL5YxWYq8Hc0lTSSqi 0p1Xq+Pn1NneQIQ3sGukhSKDqxLJY6/RbrO1fLFVlZVnzuB26GDBT103R5HaUFwHnJ WDS6xl7gUMC8y6gedcYISocAm/U8wOjKIMIVXFNw= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.36] ([77.11.129.96]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MTfol-1jPS0o3M8z-00U4EX; Thu, 25 Jun 2020 18:29:27 +0200 Subject: Re: [PATCH v2 2/2] ARM: dts: imx6q-tbs2910: Add an mdio node To: Fabio Estevam , shawnguo@kernel.org References: <20200625111846.9507-1-festevam@gmail.com> <20200625111846.9507-2-festevam@gmail.com> From: Soeren Moch Autocrypt: addr=smoch@web.de; prefer-encrypt=mutual; keydata= xsJuBFF1CvoRCADuPSewZ3cFP42zIHDvyXJuBIqMfjbKsx27T97oRza/j12Cz1aJ9qIfjOt5 9cHpi+NeCo5n5Pchlb11IGMjrd70NAByx87PwGL2MO5k/kMNucbYgN8Haas4Y3ECgrURFrZK vvTMqFNQM/djQgjxUlEIej9wlnUO2xe7uF8rB+sQ+MqzMFwesCsoWgl+gRui7AhjxDJ2+nmy Ec8ZtuTrWcTNJDsPMehLRBTf84RVg+4pkv4zH7ICzb4AWJxuTFDfQsSxfLuPmYtG0z7Jvjnt iDaaa3p9+gmZYEWaIAn9W7XTLn0jEpgK35sMtW1qJ4XKuBXzDYyN6RSId/RfkPG5X6tXAQDH KCd0I2P2dBVbSWfKP5nOaBH6Fph7nxFFayuFEUNcuQgAlO7L2bW8nRNKlBbBVozIekqpyCU7 mCdqdJBj29gm2oRcWTDB9/ARAT2z56q34BmHieY/luIGsWN54axeALlNgpNQEcKmTE4WuPaa YztGF3z18/lKDmYBbokIha+jw5gdunzXXtj5JGiwD6+qxUxoptsBooD678XxqxxhBuNPVPZ0 rncSqYrumNYqcrMXo4F58T+bly2NUSqmDHBROn30BuW2CAcmfQtequGiESNHgyJLCaBWRs5R bm/u6OlBST2KeAMPUfGvL6lWyvNzoJCWfUdVVxjgh56/s6Rp6gCHAO5q9ItsPJ5xvSWnX4hE bAq8Bckrv2E8F0Bg/qJmbZ53FQf9GEytLQe0xhYCe/vEO8oRfsZRTMsGxFH1DMvfZ7f/MrPW CTyPQ3KnwJxi9Mot2AtP1V1kfjiJ/jtuVTk021x45b6K9mw0/lX7lQ+dycrjTm6ccu98UiW1 OGw4rApMgHJR9pA59N7FAtI0bHsGVKlSzWVMdVNUCtF9R4VXUNxMZz84/ZcZ9hTK59KnrJb/ ft/IEAIEpdY7IOVI7mso060k3IFFV/HbWI/erjAGPaXR3Cccf0aH28nKIIVREfWd/7BU050G P0RTccOxtYp9KHCF3W6bC9raJXlIoktbpYYJJgHUfIrPXrnnmKkWy6AgbkPh/Xi49c5oGolN aNGeFuvYWc0aU29lcmVuIE1vY2ggPHNtb2NoQHdlYi5kZT7CegQTEQgAIgUCUXUK+gIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQANCJ0qFZnBAmcQEAkMwkC8NpkNTFQ+wc1j0C D1zWXsI3BE+elCcGlzcK8d0A/04iWXt16ussH2x+LzceaJlUJUOs6c4khyCRzWWXKK1HzsFN BFF1CvoQCADVUJEklP4MK6yoxlb+/fFsPw2YBNfpstx6TB8EC7TefHY1vIe/O4i4Vf4YfR+E dbFRfEc1uStvd/NBOZmEZYOwXgKuckwKSEGKCDz5IBhiI84e0Je4ZkHP3poljJenZEtdfiSG ZKtEjWJUv34EQGbkal7oJ2FLdlicquDmSq/WSjFenfVuGKx4Cx4jb3D0RP8A0lCGMHY6qhlq fA4SgtjbFiSPXolTCCWGJr3L5CYnPaxg4r0G5FWt+4FZsUmvdUTWB1lZV7LGk1dBjdnPv6UT X9VtL2dWl1GJHajKBJp9yz8OmkptxHLY1ZeqZRv9zEognqiE2VGiKTZe1Ajs55+HAAMFB/4g FrF01xxygoi4x5zFzTB0VGmKIYK/rsnDxJFJoaR/S9iSycSZPTxECCy955fIFLy+GEF5J3Mb G1ETO4ue2wjBMRMJZejEbD42oFgsT1qV+h8TZYWLZNoc/B/hArl5cUMa+tqz8Ih2+EUXr9wn lYqqw/ita/7yP3ScDL9NGtZ+D4rp4h08FZKKKJq8lpy7pTmd/Nt5rnwPuWxagWM0C2nMnjtm GL2tWQL0AmGIbapr0uMkvw6XsQ9NRYYyKyftP1YhgIvTiF2pAJRlmn/RZL6ZuCSJRZFMLT/v 3wqJe3ZMlKtufQP8iemqsUSKhJJVIwAKloCX08K8RJ6JRjga/41HwmEEGBEIAAkFAlF1CvoC GwwACgkQANCJ0qFZnBD/XQEAgRNZehpq0lRRtZkevVooDWftWF34jFgxigwqep7EtBwBAIlW iHJPk0kAK21A1fmcp11cd6t8Jgfn1ciPuc0fqaRb Message-ID: <1500b023-57dd-8031-863d-328fa9dcb214@web.de> Date: Thu, 25 Jun 2020 18:29:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200625111846.9507-2-festevam@gmail.com> Content-Language: en-GB X-Provags-ID: V03:K1:e3G0kpxYVhG6IMRfED/hWbLhQ80Puc0/su5TpaJVE+GPYdvG1Sr UNNz/6aVIYjHZfMGNsKFudb39msvdsMgWPkl9ehp+6k99z7zYPgvYgqJfvLSvvbsPjIzTfW GpVE5K8aZYiWlDq7kjz5RYFAejBF8r7uEFA33CTYoalHTKg/ggDFKU6IF2EaNTfqxz1AlBS I4tNIbYPkoaThcntXJJLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:7LXu8FrSCq0=:ourD9sW4Oxkyh8de4DqzLV hgAmcXyYUYtldasRxNTRwXKOU5Yn1aCeX6GWeRLNk+6mZpb8Py3svVl9nYemx5B2HIVV++1Yh 6VmPN+16hFxV8VLCd5hbx0b29c5nTCCaqSc3EF0vz9soCvZWBZitG6q42DCHor6eeuUiX5N0j c7n+d9shsez0x3Pq3Y30rpFALGC1u9U5mcZOhMQ+PsJ7NA+igweSdr70Ya7ws9oT6pCCN9aaw zGAes/sl7UHSPPxpngz0Qhi1vmPYIwXoz/xbWEMiYjJxP9HTebwaZ31FEXcZNT0uc5KgEBIvK R1YRDIi2xB0uD4pEDcUgb2HWYRZs0sjVcSCBINX4rp5kcbomSlwRXAhJyCKbkExlPYyVOGp7p Yt1NvnUotbjIzHYvT1t7WjZx2PCdYrUNg80C0ZfKgCstRQQd5wiEpyBePAmZsDtrzdrCudI/J A5yr36DLg6eS3/es26xIBGlFYFD+16mzHs2XCDFiXlOHDUsUOe6BoM75/Gzz320R6yEhzTnLi tqeAmBjFhJSJBWSZjeZW+KSvYw1uxNUHqbKEiDFTswGuzJKGSkZaekXTRK1gOoMsbplVTnrR1 sxjX3zcAvneY84Dv1kAVXcll750HQq098HlenYJoj2mFYsr/MuYMX15H7qHPclJbFW1GMDGOt BFp+G/tdUSJzdWwK3wpm86b8EGe+nLzrTaHVBBIZRk6t14rCKdCJCbHqutWSFPefU6wuTBYEc MxtGScddbXJyNKaWj9bJHmOci7Cv1/ttp+CdHI6SM6Vgq0NLZnrX3dR7VPIp98oRHkeub2KjR DmDGMX4bMpRe3MoJCXBU9x7pTZlY7+/iHqxdnnsPGyAJ89o/l/YMmGn4256TQE8CGpBSFPn8p plGv1O5gnNqbmPn9SdofzMo731ScAHkb3v+MRIWx/L6YRM5LbtBqfJjSDQbSLcBmbDNtKsQ74 j7dK3V6C5g6XZCfl9YjNs8un7STpdBIS1rfidnAovLaZOZqQHNmBwm67CIB5tX9IndGxuncIb ByoMqc5zjjtYswbqeDUqZNAD9XXUuyas1wTiL67VA3wRh8l1EzXVAbStoYSbUj2bXIWUKBeK4 737LPTy7qgKJgDk7xP1UQSHUdllJR+trqhlSMwOY6P5k0gxr5pGgmuZIdCqOd4t6/qcG9dAyC oCc/tXKSfEUTCu3Epi+Rgv6LlAzBpJ3/4V5sowdu7y1q6a2zlBszaJSluX35QsJknAgxw= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, On 25.06.20 13:18, Fabio Estevam wrote: > imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4. > > The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin. > > Improve the Ethernet representation by adding an mdio node with such > information. > > This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now > expects the 'qca,clk-out-frequency' property to be passed via > device tree. > > Signed-off-by: Fabio Estevam Due to my experience Shawn likes the properties sorted alphabetically, with some exceptions. I'm not sure if the "phy-handle" property is such exception. But this works, describes the hardware correctly, and fixes ethernet problems in U-Boot. Reviewed-by: Soeren Moch Tested in U-Boot and linux-5.7: Tested-by: Soeren Moch Thanks, Soeren > --- > Changes since v1: > - Use the correct board name in teh Subject. > > arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts > index 7b03b2787430..dfba19cd7af5 100644 > --- a/arch/arm/boot/dts/imx6q-tbs2910.dts > +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts > @@ -101,7 +101,18 @@ > phy-mode = "rgmii-id"; > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > phy-reset-duration = <10>; > + phy-handle = <&phy>; > status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy: ethernet-phy@4 { > + reg = <4>; > + qca,clk-out-frequency = <125000000>; > + }; > + }; > }; > > &hdmi { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel