All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiran Gunda <kgunda@codeaurora.org>
To: gregkh@linuxfoundation.org, sboyd@codeaurora.org,
	Kiran Gunda <kgunda@codeaurora.org>,
	Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
	David Collins <collinsd@codeaurora.org>,
	linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org
Subject: [PATCH V2 10/12] spmi: pmic-arb: fix a possible null pointer dereference
Date: Fri, 28 Jul 2017 12:40:45 +0530	[thread overview]
Message-ID: <1501225847-27807-11-git-send-email-kgunda@codeaurora.org> (raw)
In-Reply-To: <1501225847-27807-1-git-send-email-kgunda@codeaurora.org>

If "core" memory resource is not specified, then the driver could
end up dereferencing a null pointer. Fix this issue.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 88fe421..bc68e08 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -955,14 +955,14 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
 	pmic_arb->spmic = ctrl;
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
-	pmic_arb->core_size = resource_size(res);
-
 	core = devm_ioremap_resource(&ctrl->dev, res);
 	if (IS_ERR(core)) {
 		err = PTR_ERR(core);
 		goto err_put_ctrl;
 	}
 
+	pmic_arb->core_size = resource_size(res);
+
 	pmic_arb->ppid_to_apid = devm_kcalloc(&ctrl->dev, PMIC_ARB_MAX_PPID,
 					      sizeof(*pmic_arb->ppid_to_apid),
 					      GFP_KERNEL);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2017-07-28  7:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  7:10 [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 01/12] spmi: pmic-arb: remove the read/write access checks Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 07/12] spmi: pmic-arb: return the value instead of passing by pointer Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Kiran Gunda
2017-07-28  7:10 ` [PATCH V2 09/12] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-28  7:10 ` Kiran Gunda [this message]
2017-07-28  7:10 ` [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-08-17  7:41   ` Shawn Guo
2017-08-17 10:08     ` kgunda
2017-08-17 12:28       ` Shawn Guo
2017-08-18 11:13         ` kgunda
2017-08-18 11:20           ` kgunda
2017-08-18 13:22           ` Shawn Guo
2017-07-28  7:10 ` [PATCH V2 12/12] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
2017-08-01  4:55 ` [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes kgunda
2017-08-01 18:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501225847-27807-11-git-send-email-kgunda@codeaurora.org \
    --to=kgunda@codeaurora.org \
    --cc=adharmap@codeaurora.org \
    --cc=collinsd@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.