* [PATCH] IB/hns: Explicitly include linux/interrupt.h
@ 2017-07-28 10:51 Mark Brown
[not found] ` <20170728105112.7577-1-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2017-07-28 10:51 UTC (permalink / raw)
To: Lijun Ou, Wei Hu, Doug Ledford, Sean Hefty, Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Mark Brown
This file uses interrupt APIs but doesn't explicitly include
linux/interrupt.h meaning that changes in other header files could cause
build breakage as happened in next-20170728 for arm64. Add an explicit
include to avoid such problems.
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c
index 50f864935a0e..e1e4c16ca3d5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_eq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
@@ -30,6 +30,7 @@
* SOFTWARE.
*/
+#include <linux/interrupt.h>
#include <linux/platform_device.h>
#include "hns_roce_common.h"
#include "hns_roce_device.h"
--
2.13.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hns: Explicitly include linux/interrupt.h
[not found] ` <20170728105112.7577-1-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2017-07-31 19:24 ` Doug Ledford
[not found] ` <1501529069.2725.5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Doug Ledford @ 2017-07-31 19:24 UTC (permalink / raw)
To: Mark Brown, Lijun Ou, Wei Hu, Sean Hefty, Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote:
> This file uses interrupt APIs but doesn't explicitly include
> linux/interrupt.h meaning that changes in other header files could
> cause
> build breakage as happened in next-20170728 for arm64. Add an
> explicit
> include to avoid such problems.
>
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c
> b/drivers/infiniband/hw/hns/hns_roce_eq.c
> index 50f864935a0e..e1e4c16ca3d5 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_eq.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
> @@ -30,6 +30,7 @@
> * SOFTWARE.
> */
>
> +#include <linux/interrupt.h>
> #include <linux/platform_device.h>
> #include "hns_roce_common.h"
> #include "hns_roce_device.h"
Hi Mark,
Your patch is fine, but I grabbed the one from Arnd before I grabbed
this one. That was an accident on my part (yours was sent to the list
first and I normally would have grabbed it), my apologies for that. I
knew I had seen a patch come through and I scrolled back until I found
it without realizing there were two.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hns: Explicitly include linux/interrupt.h
[not found] ` <1501529069.2725.5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2017-08-22 2:21 ` Wei Hu (Xavier)
[not found] ` <599B9539.5040004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Wei Hu (Xavier) @ 2017-08-22 2:21 UTC (permalink / raw)
To: Doug Ledford, Mark Brown, Lijun Ou, Sean Hefty, Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4
Hi, Doug & Mark Brown & Arnd Bergmann
Thanks for your patches!
@Doug, Which branch can we found this patch? Thanks
Regards
Wei Hu
On 2017/8/1 3:24, Doug Ledford wrote:
> On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote:
>> This file uses interrupt APIs but doesn't explicitly include
>> linux/interrupt.h meaning that changes in other header files could
>> cause
>> build breakage as happened in next-20170728 for arm64. Add an
>> explicit
>> include to avoid such problems.
>>
>> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> ---
>> drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c
>> b/drivers/infiniband/hw/hns/hns_roce_eq.c
>> index 50f864935a0e..e1e4c16ca3d5 100644
>> --- a/drivers/infiniband/hw/hns/hns_roce_eq.c
>> +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
>> @@ -30,6 +30,7 @@
>> * SOFTWARE.
>> */
>>
>> +#include <linux/interrupt.h>
>> #include <linux/platform_device.h>
>> #include "hns_roce_common.h"
>> #include "hns_roce_device.h"
> Hi Mark,
>
> Your patch is fine, but I grabbed the one from Arnd before I grabbed
> this one. That was an accident on my part (yours was sent to the list
> first and I normally would have grabbed it), my apologies for that. I
> knew I had seen a patch come through and I scrolled back until I found
> it without realizing there were two.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hns: Explicitly include linux/interrupt.h
[not found] ` <599B9539.5040004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
@ 2017-08-22 21:06 ` Doug Ledford
0 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2017-08-22 21:06 UTC (permalink / raw)
To: Wei Hu (Xavier), Mark Brown, Lijun Ou, Sean Hefty, Hal Rosenstock
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4
On Tue, 2017-08-22 at 10:21 +0800, Wei Hu (Xavier) wrote:
> Hi, Doug & Mark Brown & Arnd Bergmann
> Thanks for your patches!
>
> @Doug, Which branch can we found this patch? Thanks
I put this in -rc, it should already be visible to you in Linus' master
branch.
> Regards
> Wei Hu
>
> On 2017/8/1 3:24, Doug Ledford wrote:
> > On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote:
> > > This file uses interrupt APIs but doesn't explicitly include
> > > linux/interrupt.h meaning that changes in other header files
> > > could
> > > cause
> > > build breakage as happened in next-20170728 for arm64. Add an
> > > explicit
> > > include to avoid such problems.
> > >
> > > Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > > ---
> > > drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c
> > > b/drivers/infiniband/hw/hns/hns_roce_eq.c
> > > index 50f864935a0e..e1e4c16ca3d5 100644
> > > --- a/drivers/infiniband/hw/hns/hns_roce_eq.c
> > > +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
> > > @@ -30,6 +30,7 @@
> > > * SOFTWARE.
> > > */
> > >
> > > +#include <linux/interrupt.h>
> > > #include <linux/platform_device.h>
> > > #include "hns_roce_common.h"
> > > #include "hns_roce_device.h"
> >
> > Hi Mark,
> >
> > Your patch is fine, but I grabbed the one from Arnd before I
> > grabbed
> > this one. That was an accident on my part (yours was sent to the
> > list
> > first and I normally would have grabbed it), my apologies for
> > that. I
> > knew I had seen a patch come through and I scrolled back until I
> > found
> > it without realizing there were two.
> >
>
>
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-22 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-28 10:51 [PATCH] IB/hns: Explicitly include linux/interrupt.h Mark Brown
[not found] ` <20170728105112.7577-1-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-31 19:24 ` Doug Ledford
[not found] ` <1501529069.2725.5.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-22 2:21 ` Wei Hu (Xavier)
[not found] ` <599B9539.5040004-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-08-22 21:06 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.