From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH] IB/hns: Explicitly include linux/interrupt.h Date: Mon, 31 Jul 2017 15:24:29 -0400 Message-ID: <1501529069.2725.5.camel@redhat.com> References: <20170728105112.7577-1-broonie@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170728105112.7577-1-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown , Lijun Ou , Wei Hu , Sean Hefty , Hal Rosenstock Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, 2017-07-28 at 11:51 +0100, Mark Brown wrote: > This file uses interrupt APIs but doesn't explicitly include > linux/interrupt.h meaning that changes in other header files could > cause > build breakage as happened in next-20170728 for arm64. Add an > explicit > include to avoid such problems. > > Signed-off-by: Mark Brown > --- > drivers/infiniband/hw/hns/hns_roce_eq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c > b/drivers/infiniband/hw/hns/hns_roce_eq.c > index 50f864935a0e..e1e4c16ca3d5 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_eq.c > +++ b/drivers/infiniband/hw/hns/hns_roce_eq.c > @@ -30,6 +30,7 @@ > * SOFTWARE. > */ > > +#include > #include > #include "hns_roce_common.h" > #include "hns_roce_device.h" Hi Mark, Your patch is fine, but I grabbed the one from Arnd before I grabbed this one. That was an accident on my part (yours was sent to the list first and I normally would have grabbed it), my apologies for that. I knew I had seen a patch come through and I scrolled back until I found it without realizing there were two. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html