All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, kwolf@redhat.com,
	mreitz@redhat.com, eblake@redhat.com,
	Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v4 11/15] qcow2: move is_zero() up
Date: Tue,  1 Aug 2017 17:19:08 +0300	[thread overview]
Message-ID: <1501597152-25342-12-git-send-email-anton.nefedov@virtuozzo.com> (raw)
In-Reply-To: <1501597152-25342-1-git-send-email-anton.nefedov@virtuozzo.com>

To be used in the following commit without a forward declaration.

Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
---
 block/qcow2.c | 45 ++++++++++++++++++++++-----------------------
 1 file changed, 22 insertions(+), 23 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index f522ba9..2ec8b03 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1946,6 +1946,28 @@ static bool merge_cow(uint64_t offset, unsigned bytes,
     return false;
 }
 
+static bool is_zero(BlockDriverState *bs, int64_t offset, int64_t bytes)
+{
+    int64_t nr;
+    int64_t res;
+    int64_t start;
+
+    /* Widen to sector boundaries, then clamp to image length, before
+     * checking status of underlying sectors */
+    start = QEMU_ALIGN_DOWN(offset, BDRV_SECTOR_SIZE);
+    bytes = QEMU_ALIGN_UP(offset + bytes, BDRV_SECTOR_SIZE) - start;
+
+    if (start + bytes > bs->total_sectors * BDRV_SECTOR_SIZE) {
+        bytes = bs->total_sectors * BDRV_SECTOR_SIZE - start;
+    }
+
+    if (!bytes) {
+        return true;
+    }
+    res = bdrv_block_status_above(bs, NULL, start, bytes, &nr, NULL);
+    return res >= 0 && (res & BDRV_BLOCK_ZERO) && nr == bytes;
+}
+
 /*
  * If the specified area is beyond EOF, allocates it + prealloc_size
  * bytes ahead.
@@ -3088,29 +3110,6 @@ finish:
     return ret;
 }
 
-
-static bool is_zero(BlockDriverState *bs, int64_t offset, int64_t bytes)
-{
-    int64_t nr;
-    int64_t res;
-    int64_t start;
-
-    /* Widen to sector boundaries, then clamp to image length, before
-     * checking status of underlying sectors */
-    start = QEMU_ALIGN_DOWN(offset, BDRV_SECTOR_SIZE);
-    bytes = QEMU_ALIGN_UP(offset + bytes, BDRV_SECTOR_SIZE) - start;
-
-    if (start + bytes > bs->total_sectors * BDRV_SECTOR_SIZE) {
-        bytes = bs->total_sectors * BDRV_SECTOR_SIZE - start;
-    }
-
-    if (!bytes) {
-        return true;
-    }
-    res = bdrv_block_status_above(bs, NULL, start, bytes, &nr, NULL);
-    return res >= 0 && (res & BDRV_BLOCK_ZERO) && nr == bytes;
-}
-
 static coroutine_fn int qcow2_co_pwrite_zeroes(BlockDriverState *bs,
     int64_t offset, int bytes, BdrvRequestFlags flags)
 {
-- 
2.7.4

  parent reply	other threads:[~2017-08-01 14:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 14:18 [Qemu-devel] [PATCH v4 00/15] qcow2: space preallocation and COW improvements Anton Nefedov
2017-08-01 14:18 ` [Qemu-devel] [PATCH v4 01/15] mirror: inherit supported write/zero flags Anton Nefedov
2017-08-04 15:13   ` [Qemu-devel] [PATCH v4 for-2.10 " Eric Blake
2017-08-01 14:18 ` [Qemu-devel] [PATCH v4 02/15] blkverify: set " Anton Nefedov
2017-08-04 15:23   ` Eric Blake
2017-08-07 12:19     ` Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 03/15] block: introduce BDRV_REQ_ALLOCATE flag Anton Nefedov
2017-08-04 19:51   ` Eric Blake
2017-08-29 12:47   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 04/15] block: treat BDRV_REQ_ALLOCATE as serialising Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 05/15] file-posix: support BDRV_REQ_ALLOCATE Anton Nefedov
2017-08-29 13:00   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 06/15] block: support BDRV_REQ_ALLOCATE in passthrough drivers Anton Nefedov
2017-08-29 13:07   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 07/15] qcow2: preallocation at image expand Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 08/15] qcow2: set inactive flag Anton Nefedov
2017-08-04 20:00   ` Eric Blake
2017-08-07 12:06     ` Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 09/15] qcow2: truncate preallocated space Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 10/15] qcow2: check space leak at the end of the image Anton Nefedov
2017-08-01 14:19 ` Anton Nefedov [this message]
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 12/15] qcow2: skip writing zero buffers to empty COW areas Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 13/15] qcow2: allocate image space by-cluster Anton Nefedov
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 14/15] iotest 190: test BDRV_REQ_ALLOCATE Anton Nefedov
2017-08-04 15:27   ` Eric Blake
2017-08-01 14:19 ` [Qemu-devel] [PATCH v4 15/15] iotest 134: test cluster-misaligned encrypted write Anton Nefedov
2017-09-21 17:16 ` [Qemu-devel] [PATCH v4 00/15] qcow2: space preallocation and COW improvements Anton Nefedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501597152-25342-12-git-send-email-anton.nefedov@virtuozzo.com \
    --to=anton.nefedov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.