From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 01/17] rbtree: changes to align the
 coding conventions with Linux tree
Date: Thu, 3 Aug 2017 12:37:50 +0200
Message-ID: <1501756670.28477.6.camel@citrix.com>
References: <20170714082636.29511-1-kpraveen.lkml@gmail.com>
 <20170714082636.29511-2-kpraveen.lkml@gmail.com>
 <5968D4F6020000780016AB37@prv-mh.provo.novell.com>
 <1500036672.13834.14.camel@gmail.com>
 <5968DDCE020000780016AB87@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8908497888006248659=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5968DDCE020000780016AB87@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>, Praveen Kumar <kpraveen.lkml@gmail.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============8908497888006248659==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-7rq3WeARPbLVndjDBb0a"

--=-7rq3WeARPbLVndjDBb0a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2017-07-14 at 07:05 -0600, Jan Beulich wrote:
> > > > On 14.07.17 at 14:51, <kpraveen.lkml@gmail.com> wrote:
> >=20
> > Agreed, I shouldn't have added.
> > rbtree.h file does include incline functions which are actually
> > commented, and in order to have complete similarity I did include
> > the
> > same here.
> >=20
> > Also, rbtree.c does have comment in header note being modified, for
> > the
> > same reason.
> >=20
> > Further, do you suggest to keep the old ones, but that may cause
> > porting issue and it won't be exact replica from Linux base. Please
> > suggest.
>=20
> I'm fine with comment updates, _as long as you say so_ in the
> commit message. If you say "only style changes", then there
> ought to be no additions whatsoever.
>=20
I fully agree with Jan.

And, as him, I also think you can update the header comments at the
beginning of both rbtree.c and rbtree.h files, as soon as you mention
that in the changelog.

*HOWEVER*, about this change, in both .c and .h:

@@ -14,7 +14,8 @@
   GNU General Public License for more details.
=20
   You should have received a copy of the GNU General Public License
-  along with this program; If not, see <http://www.gnu.org/licenses/>.
+  along with this program; if not, write to the Free Software
+  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  US=
A
=20
   linux/lib/rbtree.c
 */

This comes from 443701ef "Replace FSF street address with canonical
URL" (check with `git blame xen/common/rbtree.c'), and I think we
should leave this alone (i.e., keep the url, and not change back to the
physical address).

I understand it then will be a difference between our rbtree.{c,h} and
Linux's ones, but I think it's one difference it's worth living with
(and, honestly, I really don't expect this specific thing to cause much
issues in future 'backports' from Linux).

If others agree on this too, that would mean you basically would let
the header comment of rbtree.c alone, while in rbtree.h, you "just" add
the commented API usage example functions.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-7rq3WeARPbLVndjDBb0a
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZgvz+AAoJEBZCeImluHPuwQoP/0i9mHeVJyPHOh2Hzu9YtBZm
ZtykHGcjbbcVLF3FI0JORxSh56L9hi59kJUohMM6ILNVpz6476xFSLisUr612Dqb
/B9npaSYaiVj/R+qOO+oUXP5cXWkdueTfWIn35OS+ocHgqMDGZ/5Dkw2Y2drdiRj
NLtO3BlUuxfUDgFVUQxr7d06gE/n/Q+CAagm3524wWaiFEZ83ShLZ71Ps/ms7WX+
Of81hlN54A/Vbjnn13F/w/6GOpJMJPl5fx66QgDVMOdtvMh0qeYp5BRutYPB2SlN
OTH0wCITT1YktR+pGR4Z+qZWiArC5v0GRsq+thd4Og5n/yz1rcxvS+A1etBX57RN
2qFmDjwtgVaYY6mvg/Gmer/yqIyoZFXiJ0G1FQS4V/u0MXoqj/CXkeZTsjedbhcJ
DwAT490WtAuQRKwtEL4OvK42NKMK3BsA0z/krfzZmIpOb1TKBYDVl7684Yea2wKY
VfDb8Qc26/cG8Ib0VLMk4dktu7zqChzrOjekIKCWWUU0uKOMxhAHsboEdus3k8mv
UNGLxNTAoqlOxnzGC8zaD3jTGJSSaeQm7hkCfV+Ep/9wSwFRDeTP4Bx5+tBIQUni
nnTXJKDNWvApHwbbQDT9wBiQooBRMWU/ekz/III4lBE4MN2VQlWjpR40dL+i0euQ
KSqFHBeiNdxd/wCnoRLr
=ib6C
-----END PGP SIGNATURE-----

--=-7rq3WeARPbLVndjDBb0a--


--===============8908497888006248659==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============8908497888006248659==--