From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3/5] xen: RCU/x86/ARM: discount CPUs that
 were idle when grace period started.
Date: Wed, 9 Aug 2017 11:20:49 +0200
Message-ID: <1502270449.5719.15.camel@citrix.com>
References: <150114201043.22910.12807057883146318803.stgit@Solace>
 <150114248433.22910.16140726025093688678.stgit@Solace>
 <5988264402000078001038B6@prv-mh.provo.novell.com>
 <1502268539.5719.13.camel@citrix.com>
 <598AEAB5020000780016E136@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1019164127099312029=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=387e5d5e3=dario.faggioli@citrix.com>)
 id 1dfNAn-0004dh-62
 for xen-devel@lists.xenproject.org; Wed, 09 Aug 2017 09:21:05 +0000
In-Reply-To: <598AEAB5020000780016E136@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, julien.grall@arm.com, sstabellini@kernel.org, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

--===============1019164127099312029==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-EMLDP7sV4Apw12XkdXk8"

--=-EMLDP7sV4Apw12XkdXk8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2017-08-09 at 02:57 -0600, Jan Beulich wrote:
> > > > On 09.08.17 at 10:48, <dario.faggioli@citrix.com> wrote:
> >=20
> > _I_think_ what the original author meant was something along the
> > line
> > of <<Accessing nohz_cpu_mask before incrementing rcp->cur is
> > unsafe.
> > Therefore, let's access it afterwords, and put a barrier in
> > between.>>
> >=20
> > But yeah, as said, I don't like it myself. In fact, it's the same
> > exact
> > wording used in the changelog of the patch (Linux commit
> > c3f5902325d3053986e7359f706581d8f032e72f), but while it is fine
> > there,
> > here is completely misleading, as it does not comment/describe the
> > final look of the code.
> >=20
> > I'm going to change it.
>=20
> Perhaps worth submitting a Linux patch too then?
>=20
That code is long gone.

The file itself doesn't exist any longer, and the mask has been killed,
in favour of other mechanisms (depending of the variant of RCU, of the
degree of tickles-idleness, etc). :-)

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-EMLDP7sV4Apw12XkdXk8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZitPyAAoJEBZCeImluHPu1UoP/RmdNU1eNNSm+OHzVrQj4KBV
3dK3TmWsjqSLb7XAikT/hE5+Z7EoI6G3iY40/kc/RRvqUJZTjBVp2bWPP+Hx4fZL
j+LbVqilEM2gtnFxdRvBHroVZLHIosbYyh9VowpA/lSyLEMFzKs8CSik3GM7okID
knCyC4zGEQvwGFJ1GShjOwz5dtGQUcfHE2FicuAJ82qpRSi/CqZAuiw8PpD9jrME
NQk3fTlFtzJ9vWQhDfwjamhoEsC8jRKP3Dun2WwLTo5t7IQReQI0UbZt2luxB3WC
kiKk8LZzNejGLnqfRHAG/c8kNbuNub0J4UuRs/UqGnUrjtGjUlflpWedsNRnVOai
vPbYZuVuxGw7pedESDp9CPgIEVc992plaCB6ngwCcwG1Nbz0OSIjoSXqVFWMxM7f
CMWCwF8oKL+Yb768/WrK5y4zc914eMcd1s58KMKiTgCM2oAFAj1GvIdkTFyL4uXx
AzhysT/7mP4BAyHH6mtPnnohoYUqFrjV0fBIEAi8AU7E2F6AJs+ajXmjM9NPunIR
zfnz8XYNE+YdfWoWJtybvyxT4XrtUDJ9f74htMq/p0otodFnTOieB6HQr6nGGQiu
zsbhNn7R03uUswe9eg5Pk4k6Xm7efavt9MEi8M4ay3zf7wUnTgPTDJ7wNWloX+HO
fgNhNKryGKQdnhRWe0e7
=Ery/
-----END PGP SIGNATURE-----

--=-EMLDP7sV4Apw12XkdXk8--


--===============1019164127099312029==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============1019164127099312029==--