* [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek
This patch series based on v4.13-rc1, include MT7622 i2c dt-binding
and compatible.
changes since v2:
- Remove all the length settings from mt7622_i2c_quirks
changes since v1:
- Modify commit message
- Revise dt-binding documentation
Jun Gao (2):
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
2 files changed, 20 insertions(+), 5 deletions(-)
--
1.8.1.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek
This patch series based on v4.13-rc1, include MT7622 i2c dt-binding
and compatible.
changes since v2:
- Remove all the length settings from mt7622_i2c_quirks
changes since v1:
- Modify commit message
- Revise dt-binding documentation
Jun Gao (2):
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
2 files changed, 20 insertions(+), 5 deletions(-)
--
1.8.1.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: linux-arm-kernel
This patch series based on v4.13-rc1, include MT7622 i2c dt-binding
and compatible.
changes since v2:
- Remove all the length settings from mt7622_i2c_quirks
changes since v1:
- Modify commit message
- Revise dt-binding documentation
Jun Gao (2):
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
2 files changed, 20 insertions(+), 5 deletions(-)
--
1.8.1.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek, Jun Gao
From: Jun Gao <jun.gao@mediatek.com>
Add MT7622 i2c binding to binding file and change the compatible
information formats of all SoCs to the same.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..71fc0b3 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Jun Gao
From: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Add MT7622 i2c binding to binding file and change the compatible
information formats of all SoCs to the same.
Signed-off-by: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..71fc0b3 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Jun Gao <jun.gao@mediatek.com>
Add MT7622 i2c binding to binding file and change the compatible
information formats of all SoCs to the same.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..71fc0b3 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
2017-08-15 13:08 ` Jun Gao
(?)
@ 2017-08-15 13:08 ` Jun Gao
-1 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek, Jun Gao
From: Jun Gao <jun.gao@mediatek.com>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..09d288c 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,10 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +194,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +214,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek, Jun Gao
From: Jun Gao <jun.gao@mediatek.com>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..09d288c 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,10 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +194,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +214,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
@ 2017-08-15 13:08 ` Jun Gao
0 siblings, 0 replies; 15+ messages in thread
From: Jun Gao @ 2017-08-15 13:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Jun Gao <jun.gao@mediatek.com>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..09d288c 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,10 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +194,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +214,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
2017-08-15 13:08 ` Jun Gao
(?)
@ 2017-08-16 2:20 ` Sean Wang
-1 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 2:20 UTC (permalink / raw)
To: Jun Gao
Cc: Wolfram Sang, Matthias Brugger, devicetree, srv_heupstream,
linux-kernel, linux-mediatek, linux-i2c, linux-arm-kernel
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT7622 i2c binding to binding file and change the compatible
> information formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index bd5a7be..71fc0b3 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7622-i2c": for Mediatek MT7622
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
Hi, Jun
the patch for new soc support and clean-ups should better be in separate
patch following previous Matthias suggestion.
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html
And also spelling for Mediatek should be corrected using MediaTek.
Sean
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
@ 2017-08-16 2:20 ` Sean Wang
0 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 2:20 UTC (permalink / raw)
To: Jun Gao
Cc: Wolfram Sang, Matthias Brugger, devicetree, srv_heupstream,
linux-kernel, linux-mediatek, linux-i2c, linux-arm-kernel
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT7622 i2c binding to binding file and change the compatible
> information formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index bd5a7be..71fc0b3 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7622-i2c": for Mediatek MT7622
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
Hi, Jun
the patch for new soc support and clean-ups should better be in separate
patch following previous Matthias suggestion.
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html
And also spelling for Mediatek should be corrected using MediaTek.
Sean
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
@ 2017-08-16 2:20 ` Sean Wang
0 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 2:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add MT7622 i2c binding to binding file and change the compatible
> information formats of all SoCs to the same.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> index bd5a7be..71fc0b3 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
> @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
>
> Required properties:
> - compatible: value should be either of the following.
> - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
> - "mediatek,mt6577-i2c": for i2c compatible with mt6577.
> - "mediatek,mt6589-i2c": for i2c compatible with mt6589.
> - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
> - "mediatek,mt8173-i2c": for i2c compatible with mt8173.
> + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
> + "mediatek,mt6577-i2c": for Mediatek MT6577
> + "mediatek,mt6589-i2c": for Mediatek MT6589
> + "mediatek,mt7622-i2c": for Mediatek MT7622
> + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
> + "mediatek,mt8173-i2c": for Mediatek MT8173
> - reg: physical base address of the controller and dma base, length of memory
> mapped region.
> - interrupts: interrupt number to the cpu.
Hi, Jun
the patch for new soc support and clean-ups should better be in separate
patch following previous Matthias suggestion.
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html
And also spelling for Mediatek should be corrected using MediaTek.
Sean
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
@ 2017-08-16 3:08 ` Sean Wang
0 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 3:08 UTC (permalink / raw)
To: Jun Gao
Cc: Wolfram Sang, Matthias Brugger, devicetree, srv_heupstream,
linux-kernel, linux-mediatek, linux-i2c, linux-arm-kernel
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limits message numbers to 255, and does not support 4GB
> DMA mode.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
you seemed missing a Reviewed-by tag from Joe.C
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009975.html
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 9bedf0b..09d288c 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,6 +172,10 @@ struct mtk_i2c {
> .max_comb_2nd_msg_len = 31,
> };
>
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> +};
> +
> static const struct mtk_i2c_compatible mt6577_compat = {
> .quirks = &mt6577_i2c_quirks,
> .pmic_i2c = 0,
> @@ -190,6 +194,15 @@ struct mtk_i2c {
> .support_33bits = 0,
> };
>
> +static const struct mtk_i2c_compatible mt7622_compat = {
> + .quirks = &mt7622_i2c_quirks,
> + .pmic_i2c = 0,
> + .dcm = 1,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .support_33bits = 0,
> +};
> +
> static const struct mtk_i2c_compatible mt8173_compat = {
> .pmic_i2c = 0,
> .dcm = 1,
> @@ -201,6 +214,7 @@ struct mtk_i2c {
> static const struct of_device_id mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> {}
> };
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
@ 2017-08-16 3:08 ` Sean Wang
0 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 3:08 UTC (permalink / raw)
To: Jun Gao
Cc: Wolfram Sang, Matthias Brugger,
devicetree-u79uwXL29TY76Z2rM5mHXA,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limits message numbers to 255, and does not support 4GB
> DMA mode.
>
> Signed-off-by: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
you seemed missing a Reviewed-by tag from Joe.C
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009975.html
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 9bedf0b..09d288c 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,6 +172,10 @@ struct mtk_i2c {
> .max_comb_2nd_msg_len = 31,
> };
>
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> +};
> +
> static const struct mtk_i2c_compatible mt6577_compat = {
> .quirks = &mt6577_i2c_quirks,
> .pmic_i2c = 0,
> @@ -190,6 +194,15 @@ struct mtk_i2c {
> .support_33bits = 0,
> };
>
> +static const struct mtk_i2c_compatible mt7622_compat = {
> + .quirks = &mt7622_i2c_quirks,
> + .pmic_i2c = 0,
> + .dcm = 1,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .support_33bits = 0,
> +};
> +
> static const struct mtk_i2c_compatible mt8173_compat = {
> .pmic_i2c = 0,
> .dcm = 1,
> @@ -201,6 +214,7 @@ struct mtk_i2c {
> static const struct of_device_id mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> {}
> };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
@ 2017-08-16 3:08 ` Sean Wang
0 siblings, 0 replies; 15+ messages in thread
From: Sean Wang @ 2017-08-16 3:08 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote:
> From: Jun Gao <jun.gao@mediatek.com>
>
> Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> MT7622 limits message numbers to 255, and does not support 4GB
> DMA mode.
>
> Signed-off-by: Jun Gao <jun.gao@mediatek.com>
you seemed missing a Reviewed-by tag from Joe.C
http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009975.html
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 9bedf0b..09d288c 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -172,6 +172,10 @@ struct mtk_i2c {
> .max_comb_2nd_msg_len = 31,
> };
>
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> +};
> +
> static const struct mtk_i2c_compatible mt6577_compat = {
> .quirks = &mt6577_i2c_quirks,
> .pmic_i2c = 0,
> @@ -190,6 +194,15 @@ struct mtk_i2c {
> .support_33bits = 0,
> };
>
> +static const struct mtk_i2c_compatible mt7622_compat = {
> + .quirks = &mt7622_i2c_quirks,
> + .pmic_i2c = 0,
> + .dcm = 1,
> + .auto_restart = 1,
> + .aux_len_reg = 1,
> + .support_33bits = 0,
> +};
> +
> static const struct mtk_i2c_compatible mt8173_compat = {
> .pmic_i2c = 0,
> .dcm = 1,
> @@ -201,6 +214,7 @@ struct mtk_i2c {
> static const struct of_device_id mtk_i2c_of_match[] = {
> { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> {}
> };
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-08-16 3:09 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-15 13:08 [PATCH v3 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-15 13:08 ` [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-16 2:20 ` Sean Wang
2017-08-16 2:20 ` Sean Wang
2017-08-16 2:20 ` Sean Wang
2017-08-15 13:08 ` [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-15 13:08 ` Jun Gao
2017-08-16 3:08 ` Sean Wang
2017-08-16 3:08 ` Sean Wang
2017-08-16 3:08 ` Sean Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.