From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhcrW-00080M-Ib for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhcrV-0004aR-Mz for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:30 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:36886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhcrV-0004O4-FS for qemu-devel@nongnu.org; Tue, 15 Aug 2017 10:30:29 -0400 From: Peter Maydell Date: Tue, 15 Aug 2017 15:30:18 +0100 Message-Id: <1502807418-9994-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org, KONRAD Frederic , edgar.iglesias@gmail.com, Thomas Huth The mmio-interface device is not something we want to allow users to create on the command line: * it is intended as an implementation detail of the memory subsystem, which gets created and deleted by that subsystem on demand; it makes no sense to create it by hand on the command line * it uses a pointer property 'host_ptr' which can't be set on the command line Mark the device as not user_creatable to avoid confusion. Signed-off-by: Peter Maydell --- hw/misc/mmio_interface.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/misc/mmio_interface.c b/hw/misc/mmio_interface.c index da154e5..894e980 100644 --- a/hw/misc/mmio_interface.c +++ b/hw/misc/mmio_interface.c @@ -111,6 +111,11 @@ static void mmio_interface_class_init(ObjectClass *oc, void *data) dc->realize = mmio_interface_realize; dc->unrealize = mmio_interface_unrealize; dc->props = mmio_interface_properties; + /* Reason: pointer property "host_ptr", and this device + * is an implementation detail of the memory subsystem, + * not intended to be created directly by the user. + */ + dc->user_creatable = false; } static const TypeInfo mmio_interface_info = { -- 2.7.4