From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH v2 1/6] xen: in do_softirq() sample smp_processor_id() once and for all.
Date: Wed, 16 Aug 2017 18:45:35 +0200 [thread overview]
Message-ID: <150290193547.24854.2362617593969664852.stgit@Solace.fritz.box> (raw)
In-Reply-To: <150290125292.24854.17418548557562763544.stgit@Solace.fritz.box>
In fact, right now, we read it at every iteration of the loop.
The reason it's done like this is how context switch was handled
on IA64 (see commit ae9bfcdc, "[XEN] Various softirq cleanups" [1]).
However:
1) we don't have IA64 any longer, and all the achitectures that
we do support, are ok with sampling once and for all;
2) sampling at every iteration (slightly) affect performance;
3) sampling at every iteration is misleading, as it makes people
believe that it is currently possible that SCHEDULE_SOFTIRQ
moves the execution flow on another CPU (and the comment,
by reinforcing this belief, makes things even worse!).
Therefore, let's:
- do the sampling only once, and remove the comment;
- leave an ASSERT() around, so that, if context switching
logic changes (in current or new arches), we will notice.
[1] Some more (historical) information here:
http://old-list-archives.xenproject.org/archives/html/xen-devel/2006-06/msg01262.html
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Tim Deegan <tim@xen.org>
---
This has been submitted already, as a part of another series. Discussion is here:
https://lists.xen.org/archives/html/xen-devel/2017-06/msg00102.html
For the super lazy, Jan's latest word in that thread were these:
"I've voiced my opinion, but I don't mean to block the patch. After
all there's no active issue the change introduces."
(https://lists.xen.org/archives/html/xen-devel/2017-06/msg00797.html)
Since then:
- changed "once and for all" with "only once", as requested by George (and
applied his Reviewed-by, as he said I could).
---
xen/common/softirq.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/xen/common/softirq.c b/xen/common/softirq.c
index ac12cf8..67c84ba 100644
--- a/xen/common/softirq.c
+++ b/xen/common/softirq.c
@@ -27,16 +27,12 @@ static DEFINE_PER_CPU(unsigned int, batching);
static void __do_softirq(unsigned long ignore_mask)
{
- unsigned int i, cpu;
+ unsigned int i, cpu = smp_processor_id();
unsigned long pending;
for ( ; ; )
{
- /*
- * Initialise @cpu on every iteration: SCHEDULE_SOFTIRQ may move
- * us to another processor.
- */
- cpu = smp_processor_id();
+ ASSERT(cpu == smp_processor_id());
if ( rcu_pending(cpu) )
rcu_check_callbacks(cpu);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-16 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 16:45 [PATCH v2 0/6] xen: RCU: x86/ARM: Add support of rcu_idle_{enter, exit} Dario Faggioli
2017-08-16 16:45 ` Dario Faggioli [this message]
2017-08-29 14:02 ` [PATCH v2 1/6] xen: in do_softirq() sample smp_processor_id() once and for all George Dunlap
2017-08-16 16:45 ` [PATCH v2 2/6] xen: ARM: suspend the tick (if in use) when going idle Dario Faggioli
2017-08-16 16:45 ` [PATCH v2 3/6] xen: RCU/x86/ARM: discount CPUs that were idle when grace period started Dario Faggioli
2017-08-17 13:03 ` Tim Deegan
2017-08-18 17:06 ` Dario Faggioli
2017-08-16 16:45 ` [PATCH v2 4/6] xen: RCU: don't let a CPU with a callback go idle Dario Faggioli
2017-08-16 16:46 ` [PATCH v2 5/6] xen: RCU: avoid busy waiting until the end of grace period Dario Faggioli
2017-08-16 16:46 ` [PATCH v2 6/6] xen: try to prevent idle timer from firing too often Dario Faggioli
2017-08-29 14:07 [PATCH v2 1/6] xen: in do_softirq() sample smp_processor_id() once and for all Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150290193547.24854.2362617593969664852.stgit@Solace.fritz.box \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.