All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: dri-devel@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch, linux@armlinux.org.uk,
	laurent.pinchart@ideasonboard.com
Subject: [PATCH v3 1/2] drm/gem: drm_gem_dumb_map_offset(): reject dma-buf
Date: Thu, 17 Aug 2017 18:21:30 +0200	[thread overview]
Message-ID: <1502986891-36764-2-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1502986891-36764-1-git-send-email-noralf@tronnes.org>

Reject mapping an imported dma-buf since is's an invalid use-case.

Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/drm_gem.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index ad4e9cf..8da5801 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -333,6 +333,12 @@ int drm_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
 	if (!obj)
 		return -ENOENT;
 
+	/* Don't allow imported objects to be mapped */
+	if (obj->import_attach) {
+		ret = -EINVAL;
+		goto out;
+	}
+
 	ret = drm_gem_create_mmap_offset(obj);
 	if (ret)
 		goto out;
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-08-17 16:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 16:21 [PATCH v3 0/2] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy Noralf Trønnes
2017-08-17 16:21 ` Noralf Trønnes [this message]
2017-08-17 17:56   ` [PATCH v3 1/2] drm/gem: drm_gem_dumb_map_offset(): reject dma-buf Laurent Pinchart
2017-08-17 18:30     ` Chris Wilson
2017-08-17 19:01       ` Laurent Pinchart
2017-08-17 19:09         ` Chris Wilson
2017-08-17 19:40           ` Laurent Pinchart
2017-08-17 20:01             ` Chris Wilson
2017-08-17 22:35               ` Laurent Pinchart
2017-08-18  7:45                 ` Daniel Vetter
2017-08-18  8:01                   ` Laurent Pinchart
2017-08-18  8:21                     ` Chris Wilson
2017-08-18  7:46   ` Daniel Vetter
2017-08-18 16:13     ` Noralf Trønnes
2017-08-18 17:41       ` Eric Anholt
2017-08-18 20:17         ` Daniel Vetter
2017-08-18 20:34           ` Eric Anholt
2017-08-18 21:01             ` Daniel Vetter
2017-08-18 23:37               ` Eric Anholt
2017-08-24 10:04       ` Brian Starkey
2017-08-25 13:34         ` Daniel Vetter
2017-08-29 16:03           ` Brian Starkey
2017-08-30  7:44             ` Daniel Vetter
2017-08-30  8:38               ` Brian Starkey
2017-09-02 12:42       ` Noralf Trønnes
2017-08-21  5:26   ` Thierry Reding
2017-08-17 16:21 ` [PATCH v3 2/2] drm/armada: Use .dumb_map_offset and .dumb_destroy defaults Noralf Trønnes
2017-08-18  7:47   ` Daniel Vetter
2017-08-30  8:25     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502986891-36764-2-git-send-email-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.