All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: qemu-devel@nongnu.org, jasowang@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] net: introduce common net_crc32() and net_crc32_le() functions
Date: Fri, 18 Aug 2017 15:15:04 +0100	[thread overview]
Message-ID: <1503065708-28277-1-git-send-email-mark.cave-ayland@ilande.co.uk> (raw)

Whilst trying to debug a CRC32 endian issue for NIC multicast hash lookups, it
struck me that it would make sense to have a common set of standard ethernet
CRC32 functions (both little and big endian variants) in net.c.

The first two patches introduce the relevant functions while the last two patches
switch the pcnet and eepro100 drivers over to use them, allowing us to remove
their private implementations.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Mark Cave-Ayland (4):
  net: move CRC32 calculation from compute_mcast_idx() into its own
    net_crc32() function
  net: introduce net_crc32_le() function
  pcnet: switch lnc_mchash() over to use net_crc32_le()
  eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

 hw/net/eepro100.c |   19 +------------------
 hw/net/pcnet.c    |   16 +---------------
 include/net/net.h |    5 ++++-
 net/net.c         |   38 +++++++++++++++++++++++++++++++++-----
 4 files changed, 39 insertions(+), 39 deletions(-)

-- 
1.7.10.4

             reply	other threads:[~2017-08-18 14:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 14:15 Mark Cave-Ayland [this message]
2017-08-18 14:15 ` [Qemu-devel] [PATCH 1/4] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function Mark Cave-Ayland
2017-08-18 16:51   ` Philippe Mathieu-Daudé
2017-08-18 17:06     ` Philippe Mathieu-Daudé
2017-08-18 18:11       ` Mark Cave-Ayland
2017-08-18 14:15 ` [Qemu-devel] [PATCH 2/4] net: introduce net_crc32_le() function Mark Cave-Ayland
2017-08-18 16:54   ` Philippe Mathieu-Daudé
2017-08-18 14:15 ` [Qemu-devel] [PATCH 3/4] pcnet: switch lnc_mchash() over to use net_crc32_le() Mark Cave-Ayland
2017-08-18 16:59   ` Philippe Mathieu-Daudé
2017-08-18 17:10     ` Philippe Mathieu-Daudé
2017-08-18 14:15 ` [Qemu-devel] [PATCH 4/4] eepro100: switch e100_compute_mcast_idx() over to use net_crc32() Mark Cave-Ayland
2017-08-18 17:10   ` Philippe Mathieu-Daudé
2017-08-30 17:42 ` [Qemu-devel] [PATCH 0/4] net: introduce common net_crc32() and net_crc32_le() functions Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503065708-28277-1-git-send-email-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.