From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkAzb-0000Up-Lk for qemu-devel@nongnu.org; Tue, 22 Aug 2017 11:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkAzW-0004kd-L7 for qemu-devel@nongnu.org; Tue, 22 Aug 2017 11:21:23 -0400 Received: from indium.canonical.com ([91.189.90.7]:55532) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkAzW-0004iR-Et for qemu-devel@nongnu.org; Tue, 22 Aug 2017 11:21:18 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1dkAzT-00069Q-KU for ; Tue, 22 Aug 2017 15:21:15 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 0B9CA2E823B for ; Tue, 22 Aug 2017 15:21:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Tue, 22 Aug 2017 15:05:55 -0000 From: "Dr. David Alan Gilbert" Reply-To: Bug 1711602 <1711602@bugs.launchpad.net> Sender: bounces@canonical.com References: <150305905460.11582.12289718300820278863.malonedeb@wampee.canonical.com> Message-Id: <150341435535.17249.15822996915521510428.malone@gac.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org OK, Stefan posted a patch for that assert (see 'nbd-client: avoid spurious = qui_channel_yield() re-entry) so now I'm running with the following patch a= nd I'm seeing the bdrv_inactivate return a -1 for = drive-virtio-disk0 Christian: Could you see what your source says with this patch? diff --git a/block.c b/block.c index 3615a68..f9bd689 100644 --- a/block.c +++ b/block.c @@ -4078,9 +4078,11 @@ static int bdrv_inactivate_recurse(BlockDriverState = *bs, BdrvChild *child, *parent; int ret; = + fprintf(stderr, "%s: entry for %s\n", __func__, bdrv_get_device_or_nod= e_name(bs)); if (!setting_flag && bs->drv->bdrv_inactivate) { ret =3D bs->drv->bdrv_inactivate(bs); if (ret < 0) { + fprintf(stderr, "%s: exit 1(%d) for %s\n", __func__, ret, bdrv= _get_device_or_node_name(bs)); return ret; } } @@ -4094,6 +4096,7 @@ static int bdrv_inactivate_recurse(BlockDriverState *= bs, if (parent->role->inactivate) { ret =3D parent->role->inactivate(parent); if (ret < 0) { + fprintf(stderr, "%s: exit 2(%d) for %s\n", __func__, r= et, bdrv_get_device_or_node_name(bs)); bs->open_flags &=3D ~BDRV_O_INACTIVE; return ret; } @@ -4109,6 +4112,7 @@ static int bdrv_inactivate_recurse(BlockDriverState *= bs, QLIST_FOREACH(child, &bs->children, next) { ret =3D bdrv_inactivate_recurse(child->bs, setting_flag); if (ret < 0) { + fprintf(stderr, "%s: exit 3(%d) for %s\n", __func__, ret, bdrv= _get_device_or_node_name(bs)); return ret; } } @@ -4117,6 +4121,7 @@ static int bdrv_inactivate_recurse(BlockDriverState *= bs, * driver */ bdrv_release_persistent_dirty_bitmaps(bs); = + fprintf(stderr, "%s: exit end good for %s\n", __func__, bdrv_get_devi= ce_or_node_name(bs)); return 0; } -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602 Title: --copy-storage-all failing with qemu 2.10 Status in QEMU: New Status in libvirt package in Ubuntu: Confirmed Status in qemu package in Ubuntu: Confirmed Bug description: We fixed an issue around disk locking already in regard to qemu-nbd [1], but there still seem to be issues. $ virsh migrate --live --copy-storage-all kvmguest-artful-normal qemu+ssh= ://10.22.69.196/system error: internal error: qemu unexpectedly closed the monitor: 2017-08-18T1= 2:10:29.800397Z qemu-system-x86_64: -chardev pty,id=3Dcharserial0: char dev= ice redirected to /dev/pts/0 (label charserial0) 2017-08-18T12:10:48.545776Z qemu-system-x86_64: load of migration failed:= Input/output error Source libvirt log for the guest: 2017-08-18 12:09:08.251+0000: initiating migration 2017-08-18T12:09:08.809023Z qemu-system-x86_64: Unable to read from socke= t: Connection reset by peer 2017-08-18T12:09:08.809481Z qemu-system-x86_64: Unable to read from socke= t: Connection reset by peer Target libvirt log for the guest: 2017-08-18T12:09:08.730911Z qemu-system-x86_64: load of migration failed:= Input/output error 2017-08-18 12:09:09.010+0000: shutting down, reason=3Dcrashed Given the timing it seems that the actual copy now works (it is busy ~10 = seconds on my environment which would be the copy). Also we don't see the old errors we saw before, but afterwards on the act= ual take-over it fails. Dmesg has no related denials as often apparmor is in the mix. Need to check libvirt logs of source [2] and target [3] in Detail. [1]: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg02200.html [2]: http://paste.ubuntu.com/25339356/ [3]: http://paste.ubuntu.com/25339358/ To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1711602/+subscriptions