From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Szwichtenberg, Radoslaw" <radoslaw.szwichtenberg@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Maarten@freedesktop.org" <Maarten@freedesktop.org>
Subject: Re: [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank
Date: Tue, 22 Aug 2017 17:11:29 +0100 [thread overview]
Message-ID: <150341828972.30378.11463175351447835089@mail.alporthouse.com> (raw)
In-Reply-To: <1503046232.3082.0.camel@intel.com>
Quoting Szwichtenberg, Radoslaw (2017-08-18 09:50:35)
> On Fri, 2017-08-18 at 08:54 +0100, Chris Wilson wrote:
> > Quoting Chris Wilson (2017-08-17 13:37:06)
> > > If we miss the current vblank because the gpu was busy, that may cause a
> > > jitter as the frame rate temporarily drops. We try to limit the impact
> > > of this by then boosting the GPU clock to deliver the frame as quickly
> > > as possible. Originally done in commit 6ad790c0f5ac ("drm/i915: Boost GPU
> > > frequency if we detect outstanding pageflips") but was never forward
> > > ported to atomic and finally dropped in commit fd3a40242e87 ("drm/i915:
> > > Rip out legacy page_flip completion/irq handling").
> >
> >
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102199
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102199
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Daniel Vetter <daniel.vetter@intel.com>
> >
> > Tested-by: Lyude Paul <lyude@redhat.com>
> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
Added the blurb to explain itself better and pushed to paper over the
miserable UX performance.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-22 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 12:37 [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank Chris Wilson
2017-08-17 13:11 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-08-18 7:54 ` [PATCH] " Chris Wilson
2017-08-18 8:50 ` Szwichtenberg, Radoslaw
2017-08-22 16:11 ` Chris Wilson [this message]
2017-08-18 9:30 ` Chris Wilson
2017-08-18 14:05 ` Chris Wilson
2017-08-21 15:54 ` Chris Wilson
2017-08-22 17:02 ` Ville Syrjälä
2017-08-22 17:12 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150341828972.30378.11463175351447835089@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Maarten@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=radoslaw.szwichtenberg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.