All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	David Howells <dhowells@redhat.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Gary Hook <gary.hook@amd.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Arnaud Ebalard <arno@natisbad.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
	Steve French <sfrench@samba.org>,
	"Theodore Y. Ts'o" <tytso@mit.edu>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	James Morris <james.l.morris@oracle.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-crypto@v
Cc: Ofir Drang <ofir.drang@arm.com>
Subject: [PATCH v7 07/19] crypto: move pub key to generic async completion
Date: Thu, 24 Aug 2017 17:18:54 +0300	[thread overview]
Message-ID: <1503584350-7831-8-git-send-email-gilad__29110.254351008$1503584920$gmane$org@benyossef.com> (raw)
In-Reply-To: <1503584350-7831-1-git-send-email-gilad@benyossef.com>

public_key_verify_signature() is starting an async crypto op and
waiting for it to complete. Move it over to generic code doing
the same.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
 crypto/asymmetric_keys/public_key.c | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/crypto/asymmetric_keys/public_key.c b/crypto/asymmetric_keys/public_key.c
index 3cd6e12..d916235 100644
--- a/crypto/asymmetric_keys/public_key.c
+++ b/crypto/asymmetric_keys/public_key.c
@@ -57,29 +57,13 @@ static void public_key_destroy(void *payload0, void *payload3)
 	public_key_signature_free(payload3);
 }
 
-struct public_key_completion {
-	struct completion completion;
-	int err;
-};
-
-static void public_key_verify_done(struct crypto_async_request *req, int err)
-{
-	struct public_key_completion *compl = req->data;
-
-	if (err == -EINPROGRESS)
-		return;
-
-	compl->err = err;
-	complete(&compl->completion);
-}
-
 /*
  * Verify a signature using a public key.
  */
 int public_key_verify_signature(const struct public_key *pkey,
 				const struct public_key_signature *sig)
 {
-	struct public_key_completion compl;
+	struct crypto_wait cwait;
 	struct crypto_akcipher *tfm;
 	struct akcipher_request *req;
 	struct scatterlist sig_sg, digest_sg;
@@ -131,20 +115,16 @@ int public_key_verify_signature(const struct public_key *pkey,
 	sg_init_one(&digest_sg, output, outlen);
 	akcipher_request_set_crypt(req, &sig_sg, &digest_sg, sig->s_size,
 				   outlen);
-	init_completion(&compl.completion);
+	crypto_init_wait(&cwait);
 	akcipher_request_set_callback(req, CRYPTO_TFM_REQ_MAY_BACKLOG |
 				      CRYPTO_TFM_REQ_MAY_SLEEP,
-				      public_key_verify_done, &compl);
+				      crypto_req_done, &cwait);
 
 	/* Perform the verification calculation.  This doesn't actually do the
 	 * verification, but rather calculates the hash expected by the
 	 * signature and returns that to us.
 	 */
-	ret = crypto_akcipher_verify(req);
-	if ((ret == -EINPROGRESS) || (ret == -EBUSY)) {
-		wait_for_completion(&compl.completion);
-		ret = compl.err;
-	}
+	ret = crypto_wait_req(crypto_akcipher_verify(req), &cwait);
 	if (ret < 0)
 		goto out_free_output;
 
-- 
2.1.4


  parent reply	other threads:[~2017-08-24 14:18 UTC|newest]

Thread overview: 182+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 14:18 [PATCH v7 00/19] simplify crypto wait for async op Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 01/19] crypto: change transient busy return code to -EAGAIN Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 02/19] crypto: ccp: use -EAGAIN for transient busy indication Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 03/19] crypto: remove redundant backlog checks on EBUSY Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 04/19] crypto: marvell/cesa: " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 05/19] crypto: introduce crypto wait for async op Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 06/19] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 07/19] crypto: move pub key " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef [this message]
2017-08-24 14:18 ` [PATCH v7 08/19] crypto: move drbg " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 09/19] crypto: move gcm " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 10/19] crypto: move testmgr " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 11/19] fscrypt: move " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18 ` [PATCH v7 12/19] dm: move dm-verity " Gilad Ben-Yossef
2017-08-24 14:18 ` Gilad Ben-Yossef
     [not found] ` <1503584350-7831-1-git-send-email-gilad-6S/DczAoZh3WXxRugSxzZg@public.gmane.org>
2017-08-24 14:18   ` [PATCH v7 01/19] crypto: change transient busy return code to -EAGAIN Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 02/19] crypto: ccp: use -EAGAIN for transient busy indication Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 03/19] crypto: remove redundant backlog checks on EBUSY Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 04/19] crypto: marvell/cesa: " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 05/19] crypto: introduce crypto wait for async op Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 06/19] crypto: move algif to generic async completion Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 07/19] crypto: move pub key " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 08/19] crypto: move drbg " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 09/19] crypto: move gcm " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 10/19] crypto: move testmgr " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 11/19] fscrypt: move " Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:18   ` [PATCH v7 12/19] dm: move dm-verity " Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18     ` Gilad Ben-Yossef
2017-08-24 14:18   ` Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 13/19] cifs: move " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 14/19] ima: " Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 15/19] crypto: tcrypt: " Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 16/19] crypto: talitos: " Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 17/19] crypto: qce: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 18/19] crypto: mediatek: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` [PATCH v7 19/19] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-31 12:31   ` [PATCH v7 00/19] simplify crypto wait for async op Harsh Jain
2017-08-31 12:43     ` Harsh Jain
2017-08-31 12:31     ` Harsh Jain
2017-08-31 12:31     ` Harsh Jain
2017-08-31 12:31     ` Harsh Jain
2017-09-03  6:09     ` Gilad Ben-Yossef
     [not found]     ` <CAFXBA=n6W_n1P=NKHEUAgpaDDrdmh4QwB4aYma9xyio7UFP3Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-03  6:17       ` Gilad Ben-Yossef
2017-09-03  6:17         ` Gilad Ben-Yossef
2017-09-03  6:17         ` Gilad Ben-Yossef
2017-09-03  6:17         ` Gilad Ben-Yossef
2017-09-03  6:17         ` Gilad Ben-Yossef
2017-09-05 11:23         ` Harsh Jain
2017-09-05 11:35           ` Harsh Jain
2017-09-05 11:23           ` Harsh Jain
2017-09-05 11:23           ` Harsh Jain
2017-09-05 11:23           ` Harsh Jain
2017-09-05 12:16           ` Gilad Ben-Yossef
2017-09-05 12:16             ` Gilad Ben-Yossef
2017-09-05 12:16             ` Gilad Ben-Yossef
2017-09-05 12:16             ` Gilad Ben-Yossef
2017-09-05 12:16             ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 13/19] cifs: move to generic async completion Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 14/19] ima: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 15/19] crypto: tcrypt: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 16/19] crypto: talitos: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 17/19] crypto: qce: " Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 18/19] crypto: mediatek: " Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19 ` [PATCH v7 19/19] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19   ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef
2017-08-24 14:19 ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1503584350-7831-8-git-send-email-gilad__29110.254351008$1503584920$gmane$org@benyossef.com' \
    --to=gilad@benyossef.com \
    --cc=agk@redhat.com \
    --cc=arno@natisbad.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=gary.hook@amd.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jaegeuk@kernel.org \
    --cc=james.l.morris@oracle.com \
    --cc=linux-crypto@v \
    --cc=matthias.bgg@gmail.com \
    --cc=ofir.drang@arm.com \
    --cc=serge@hallyn.com \
    --cc=sfrench@samba.org \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tytso@mit.edu \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.