All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-08-28 14:20 ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI phy
or in FS/LS with the on-chip FS phy.

Amelie Delaunay (7):
  dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
  usb: dwc2: add support for STM32F7 USB OTG HS
  ARM: dts: stm32: Add USB HS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB HS on stm32746g-eval
  ARM: dts: stm32: Enable USB HS on stm32f746-disco
  ARM: dts: stm32: Add USB FS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB FS on stm32f746-disco

 Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
 arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
 arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
 arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
 drivers/usb/dwc2/params.c                      | 11 ++++
 5 files changed, 139 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-08-28 14:20 ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI phy
or in FS/LS with the on-chip FS phy.

Amelie Delaunay (7):
  dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
  usb: dwc2: add support for STM32F7 USB OTG HS
  ARM: dts: stm32: Add USB HS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB HS on stm32746g-eval
  ARM: dts: stm32: Enable USB HS on stm32f746-disco
  ARM: dts: stm32: Add USB FS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB FS on stm32f746-disco

 Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
 arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
 arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
 arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
 drivers/usb/dwc2/params.c                      | 11 ++++
 5 files changed, 139 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-08-28 14:20 ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
OTG FS and the other is USB OTG HS. The USB FS core only works with its
internal phy whilst the USB HS core can work in HS with external ULPI phy
or in FS/LS with the on-chip FS phy.

Amelie Delaunay (7):
  dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
  usb: dwc2: add support for STM32F7 USB OTG HS
  ARM: dts: stm32: Add USB HS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB HS on stm32746g-eval
  ARM: dts: stm32: Enable USB HS on stm32f746-disco
  ARM: dts: stm32: Add USB FS support for STM32F746 MCU
  ARM: dts: stm32: Enable USB FS on stm32f746-disco

 Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
 arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
 arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
 arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
 drivers/usb/dwc2/params.c                      | 11 ++++
 5 files changed, 139 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds binding documentation for DWC2 controller in HS mode found
on STMicroelectronics STM32F7 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index fcf199b..46da5f1 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -19,6 +19,8 @@ Required properties:
   configured in FS mode;
   - "st,stm32f4x9-hsotg": The DWC2 USB HS controller instance in STM32F4x9 SoCs
   configured in HS mode;
+  - "st,stm32f7-hsotg": The DWC2 USB HS controller instance in STM32F7 SoCs
+    configured in HS mode;
 - reg : Should contain 1 register range (address and length)
 - interrupts : Should contain 1 interrupt
 - clocks: clock provider specifier
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: devicetree, Amelie Delaunay, Benjamin Gaignard, linux-usb,
	linux-kernel, linux-arm-kernel

This patch adds binding documentation for DWC2 controller in HS mode found
on STMicroelectronics STM32F7 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index fcf199b..46da5f1 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -19,6 +19,8 @@ Required properties:
   configured in FS mode;
   - "st,stm32f4x9-hsotg": The DWC2 USB HS controller instance in STM32F4x9 SoCs
   configured in HS mode;
+  - "st,stm32f7-hsotg": The DWC2 USB HS controller instance in STM32F7 SoCs
+    configured in HS mode;
 - reg : Should contain 1 register range (address and length)
 - interrupts : Should contain 1 interrupt
 - clocks: clock provider specifier
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds binding documentation for DWC2 controller in HS mode found
on STMicroelectronics STM32F7 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt
index fcf199b..46da5f1 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.txt
+++ b/Documentation/devicetree/bindings/usb/dwc2.txt
@@ -19,6 +19,8 @@ Required properties:
   configured in FS mode;
   - "st,stm32f4x9-hsotg": The DWC2 USB HS controller instance in STM32F4x9 SoCs
   configured in HS mode;
+  - "st,stm32f7-hsotg": The DWC2 USB HS controller instance in STM32F7 SoCs
+    configured in HS mode;
 - reg : Should contain 1 register range (address and length)
 - interrupts : Should contain 1 interrupt
 - clocks: clock provider specifier
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 drivers/usb/dwc2/params.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index a3ffe97..d5b672d 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
 	p->activate_stm_fs_transceiver = true;
 }
 
+static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
+{
+	struct dwc2_core_params *p = &hsotg->params;
+
+	p->host_rx_fifo_size = 622;
+	p->host_nperio_tx_fifo_size = 128;
+	p->host_perio_tx_fifo_size = 256;
+}
+
 const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
 	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
@@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "st,stm32f4x9-fsotg",
 	  .data = dwc2_set_stm32f4x9_fsotg_params },
 	{ .compatible = "st,stm32f4x9-hsotg" },
+	{ .compatible = "st,stm32f7-hsotg",
+	  .data = dwc2_set_stm32f7_hsotg_params },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 drivers/usb/dwc2/params.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index a3ffe97..d5b672d 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
 	p->activate_stm_fs_transceiver = true;
 }
 
+static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
+{
+	struct dwc2_core_params *p = &hsotg->params;
+
+	p->host_rx_fifo_size = 622;
+	p->host_nperio_tx_fifo_size = 128;
+	p->host_perio_tx_fifo_size = 256;
+}
+
 const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
 	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
@@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "st,stm32f4x9-fsotg",
 	  .data = dwc2_set_stm32f4x9_fsotg_params },
 	{ .compatible = "st,stm32f4x9-hsotg" },
+	{ .compatible = "st,stm32f7-hsotg",
+	  .data = dwc2_set_stm32f7_hsotg_params },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 drivers/usb/dwc2/params.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index a3ffe97..d5b672d 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
 	p->activate_stm_fs_transceiver = true;
 }
 
+static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
+{
+	struct dwc2_core_params *p = &hsotg->params;
+
+	p->host_rx_fifo_size = 622;
+	p->host_nperio_tx_fifo_size = 128;
+	p->host_perio_tx_fifo_size = 256;
+}
+
 const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
 	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
@@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
 	{ .compatible = "st,stm32f4x9-fsotg",
 	  .data = dwc2_set_stm32f4x9_fsotg_params },
 	{ .compatible = "st,stm32f4x9-hsotg" },
+	{ .compatible = "st,stm32f7-hsotg",
+	  .data = dwc2_set_stm32f7_hsotg_params },
 	{},
 };
 MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 3/7] ARM: dts: stm32: Add USB HS support for STM32F746 MCU
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 49 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 4506eb9..5d0cc72 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -361,6 +361,46 @@
 					bias-disable;
 				};
 			};
+
+			usbotg_hs_pins_a: usbotg-hs@0 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PI11_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_hs_pins_b: usbotg-hs@1 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PC2_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc@40023000 {
@@ -380,6 +420,15 @@
 			assigned-clocks = <&rcc 1 CLK_HSE_RTC>;
 			assigned-clock-rates = <1000000>;
 		};
+
+		usbotg_hs: usb@40040000 {
+			compatible = "st,stm32f7-hsotg";
+			reg = <0x40040000 0x40000>;
+			interrupts = <77>;
+			clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 3/7] ARM: dts: stm32: Add USB HS support for STM32F746 MCU
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 49 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 4506eb9..5d0cc72 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -361,6 +361,46 @@
 					bias-disable;
 				};
 			};
+
+			usbotg_hs_pins_a: usbotg-hs@0 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PI11_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_hs_pins_b: usbotg-hs@1 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PC2_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc@40023000 {
@@ -380,6 +420,15 @@
 			assigned-clocks = <&rcc 1 CLK_HSE_RTC>;
 			assigned-clock-rates = <1000000>;
 		};
+
+		usbotg_hs: usb@40040000 {
+			compatible = "st,stm32f7-hsotg";
+			reg = <0x40040000 0x40000>;
+			interrupts = <77>;
+			clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 3/7] ARM: dts: stm32: Add USB HS support for STM32F746 MCU
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds the USB pins and nodes for USB HS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 49 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 4506eb9..5d0cc72 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -361,6 +361,46 @@
 					bias-disable;
 				};
 			};
+
+			usbotg_hs_pins_a: usbotg-hs at 0 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PI11_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_hs_pins_b: usbotg-hs at 1 {
+				pins {
+					pinmux = <STM32F746_PH4_FUNC_OTG_HS_ULPI_NXT>,
+						 <STM32F746_PC2_FUNC_OTG_HS_ULPI_DIR>,
+						 <STM32F746_PC0_FUNC_OTG_HS_ULPI_STP>,
+						 <STM32F746_PA5_FUNC_OTG_HS_ULPI_CK>,
+						 <STM32F746_PA3_FUNC_OTG_HS_ULPI_D0>,
+						 <STM32F746_PB0_FUNC_OTG_HS_ULPI_D1>,
+						 <STM32F746_PB1_FUNC_OTG_HS_ULPI_D2>,
+						 <STM32F746_PB10_FUNC_OTG_HS_ULPI_D3>,
+						 <STM32F746_PB11_FUNC_OTG_HS_ULPI_D4>,
+						 <STM32F746_PB12_FUNC_OTG_HS_ULPI_D5>,
+						 <STM32F746_PB13_FUNC_OTG_HS_ULPI_D6>,
+						 <STM32F746_PB5_FUNC_OTG_HS_ULPI_D7>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc at 40023000 {
@@ -380,6 +420,15 @@
 			assigned-clocks = <&rcc 1 CLK_HSE_RTC>;
 			assigned-clock-rates = <1000000>;
 		};
+
+		usbotg_hs: usb at 40040000 {
+			compatible = "st,stm32f7-hsotg";
+			reg = <0x40040000 0x40000>;
+			interrupts = <77>;
+			clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch enables USB HS on stm32746g-eval (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32746g-eval.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579..03ee797 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -83,6 +83,13 @@
 			gpios = <&gpioc 13 0>;
 		};
 	};
+
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -102,3 +109,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: devicetree, Amelie Delaunay, Benjamin Gaignard, linux-usb,
	linux-kernel, linux-arm-kernel

This patch enables USB HS on stm32746g-eval (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32746g-eval.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579..03ee797 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -83,6 +83,13 @@
 			gpios = <&gpioc 13 0>;
 		};
 	};
+
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -102,3 +109,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch enables USB HS on stm32746g-eval (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32746g-eval.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index 69a9579..03ee797 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -83,6 +83,13 @@
 			gpios = <&gpioc 13 0>;
 		};
 	};
+
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -102,3 +109,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 5/7] ARM: dts: stm32: Enable USB HS on stm32f746-disco
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch enables USB HS on stm32f746-disco (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 18f6560..8f0c3d5 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -61,6 +61,12 @@
 		serial0 = &usart1;
 	};
 
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -72,3 +78,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_b>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 5/7] ARM: dts: stm32: Enable USB HS on stm32f746-disco
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard, Amelie Delaunay

This patch enables USB HS on stm32f746-disco (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 18f6560..8f0c3d5 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -61,6 +61,12 @@
 		serial0 = &usart1;
 	};
 
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -72,3 +78,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_b>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 5/7] ARM: dts: stm32: Enable USB HS on stm32f746-disco
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch enables USB HS on stm32f746-disco (Host mode).

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 18f6560..8f0c3d5 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -61,6 +61,12 @@
 		serial0 = &usart1;
 	};
 
+	usbotg_hs_phy: usb-phy {
+		#phy-cells = <0>;
+		compatible = "usb-nop-xceiv";
+		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
+		clock-names = "main_clk";
+	};
 };
 
 &clk_hse {
@@ -72,3 +78,12 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_hs {
+	dr_mode = "host";
+	phys = <&usbotg_hs_phy>;
+	phy-names = "usb2-phy";
+	pinctrl-0 = <&usbotg_hs_pins_b>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 5d0cc72..b605445 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -401,6 +401,28 @@
 					slew-rate = <2>;
 				};
 			};
+
+			usbotg_fs_pins_a: usbotg-fs@0 {
+				pins {
+					pinmux = <STM32F746_PA10_FUNC_OTG_FS_ID>,
+						 <STM32F746_PA11_FUNC_OTG_FS_DM>,
+						 <STM32F746_PA12_FUNC_OTG_FS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_fs_pins_b: usbotg-fs@1 {
+				pins {
+					pinmux = <STM32F746_PB12_FUNC_OTG_HS_ID>,
+						 <STM32F746_PB14_FUNC_OTG_HS_DM>,
+						 <STM32F746_PB15_FUNC_OTG_HS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc@40023000 {
@@ -429,6 +451,15 @@
 			clock-names = "otg";
 			status = "disabled";
 		};
+
+		usbotg_fs: usb@50000000 {
+			compatible = "st,stm32f4x9-fsotg";
+			reg = <0x50000000 0x40000>;
+			interrupts = <67>;
+			clocks = <&rcc 0 STM32F7_AHB2_CLOCK(OTGFS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 5d0cc72..b605445 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -401,6 +401,28 @@
 					slew-rate = <2>;
 				};
 			};
+
+			usbotg_fs_pins_a: usbotg-fs@0 {
+				pins {
+					pinmux = <STM32F746_PA10_FUNC_OTG_FS_ID>,
+						 <STM32F746_PA11_FUNC_OTG_FS_DM>,
+						 <STM32F746_PA12_FUNC_OTG_FS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_fs_pins_b: usbotg-fs@1 {
+				pins {
+					pinmux = <STM32F746_PB12_FUNC_OTG_HS_ID>,
+						 <STM32F746_PB14_FUNC_OTG_HS_DM>,
+						 <STM32F746_PB15_FUNC_OTG_HS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc@40023000 {
@@ -429,6 +451,15 @@
 			clock-names = "otg";
 			status = "disabled";
 		};
+
+		usbotg_fs: usb@50000000 {
+			compatible = "st,stm32f4x9-fsotg";
+			reg = <0x50000000 0x40000>;
+			interrupts = <67>;
+			clocks = <&rcc 0 STM32F7_AHB2_CLOCK(OTGFS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746.dtsi | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 5d0cc72..b605445 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -401,6 +401,28 @@
 					slew-rate = <2>;
 				};
 			};
+
+			usbotg_fs_pins_a: usbotg-fs at 0 {
+				pins {
+					pinmux = <STM32F746_PA10_FUNC_OTG_FS_ID>,
+						 <STM32F746_PA11_FUNC_OTG_FS_DM>,
+						 <STM32F746_PA12_FUNC_OTG_FS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
+
+			usbotg_fs_pins_b: usbotg-fs at 1 {
+				pins {
+					pinmux = <STM32F746_PB12_FUNC_OTG_HS_ID>,
+						 <STM32F746_PB14_FUNC_OTG_HS_DM>,
+						 <STM32F746_PB15_FUNC_OTG_HS_DP>;
+					bias-disable;
+					drive-push-pull;
+					slew-rate = <2>;
+				};
+			};
 		};
 
 		crc: crc at 40023000 {
@@ -429,6 +451,15 @@
 			clock-names = "otg";
 			status = "disabled";
 		};
+
+		usbotg_fs: usb at 50000000 {
+			compatible = "st,stm32f4x9-fsotg";
+			reg = <0x50000000 0x40000>;
+			interrupts = <67>;
+			clocks = <&rcc 0 STM32F7_AHB2_CLOCK(OTGFS)>;
+			clock-names = "otg";
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 7/7] ARM: dts: stm32: Enable USB FS on stm32f746-disco
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-08-28 14:20   ` Amelie Delaunay
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS
enable.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 8f0c3d5..eeb430c 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -67,6 +67,14 @@
 		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
 		clock-names = "main_clk";
 	};
+
+	/* This turns on vbus for otg fs for host mode (dwc2) */
+	vcc5v_otg_fs: vcc5v-otg-fs-regulator {
+		compatible = "regulator-fixed";
+		gpio = <&gpiod 5 0>;
+		regulator-name = "vcc5_host1";
+		regulator-always-on;
+	};
 };
 
 &clk_hse {
@@ -87,3 +95,10 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_fs {
+	dr_mode = "host";
+	pinctrl-0 = <&usbotg_fs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 7/7] ARM: dts: stm32: Enable USB FS on stm32f746-disco
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS
enable.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 8f0c3d5..eeb430c 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -67,6 +67,14 @@
 		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
 		clock-names = "main_clk";
 	};
+
+	/* This turns on vbus for otg fs for host mode (dwc2) */
+	vcc5v_otg_fs: vcc5v-otg-fs-regulator {
+		compatible = "regulator-fixed";
+		gpio = <&gpiod 5 0>;
+		regulator-name = "vcc5_host1";
+		regulator-always-on;
+	};
 };
 
 &clk_hse {
@@ -87,3 +95,10 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_fs {
+	dr_mode = "host";
+	pinctrl-0 = <&usbotg_fs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* [PATCHv2 7/7] ARM: dts: stm32: Enable USB FS on stm32f746-disco
@ 2017-08-28 14:20   ` Amelie Delaunay
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie Delaunay @ 2017-08-28 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

This patch enables USB FS on stm32f746-disco (Host mode) with 5V VBUS
enable.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32f746-disco.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts
index 8f0c3d5..eeb430c 100644
--- a/arch/arm/boot/dts/stm32f746-disco.dts
+++ b/arch/arm/boot/dts/stm32f746-disco.dts
@@ -67,6 +67,14 @@
 		clocks = <&rcc 0 STM32F7_AHB1_CLOCK(OTGHSULPI)>;
 		clock-names = "main_clk";
 	};
+
+	/* This turns on vbus for otg fs for host mode (dwc2) */
+	vcc5v_otg_fs: vcc5v-otg-fs-regulator {
+		compatible = "regulator-fixed";
+		gpio = <&gpiod 5 0>;
+		regulator-name = "vcc5_host1";
+		regulator-always-on;
+	};
 };
 
 &clk_hse {
@@ -87,3 +95,10 @@
 	pinctrl-names = "default";
 	status = "okay";
 };
+
+&usbotg_fs {
+	dr_mode = "host";
+	pinctrl-0 = <&usbotg_fs_pins_a>;
+	pinctrl-names = "default";
+	status = "okay";
+};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
@ 2017-09-01 15:35     ` Rob Herring
  0 siblings, 0 replies; 72+ messages in thread
From: Rob Herring @ 2017-09-01 15:35 UTC (permalink / raw)
  To: Amelie Delaunay
  Cc: Greg Kroah-Hartman, Mark Rutland, Russell King, Maxime Coquelin,
	Alexandre Torgue, John Youn, linux-usb, devicetree, linux-kernel,
	linux-arm-kernel, Benjamin Gaignard

On Mon, Aug 28, 2017 at 04:20:12PM +0200, Amelie Delaunay wrote:
> This patch adds binding documentation for DWC2 controller in HS mode found
> on STMicroelectronics STM32F7 SoC.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
@ 2017-09-01 15:35     ` Rob Herring
  0 siblings, 0 replies; 72+ messages in thread
From: Rob Herring @ 2017-09-01 15:35 UTC (permalink / raw)
  To: Amelie Delaunay
  Cc: Greg Kroah-Hartman, Mark Rutland, Russell King, Maxime Coquelin,
	Alexandre Torgue, John Youn, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard

On Mon, Aug 28, 2017 at 04:20:12PM +0200, Amelie Delaunay wrote:
> This patch adds binding documentation for DWC2 controller in HS mode found
> on STMicroelectronics STM32F7 SoC.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
@ 2017-09-01 15:35     ` Rob Herring
  0 siblings, 0 replies; 72+ messages in thread
From: Rob Herring @ 2017-09-01 15:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Aug 28, 2017 at 04:20:12PM +0200, Amelie Delaunay wrote:
> This patch adds binding documentation for DWC2 controller in HS mode found
> on STMicroelectronics STM32F7 SoC.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
  2017-08-28 14:20   ` Amelie Delaunay
  (?)
@ 2017-09-29 14:20     ` Amelie DELAUNAY
  -1 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-09-29 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre TORGUE, John Youn, Felipe Balbi
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

Hi,

Gentle ping for driver review submitted on August 28th.

Thanks,
Amelie

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>   drivers/usb/dwc2/params.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index a3ffe97..d5b672d 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
> +{
> +	struct dwc2_core_params *p = &hsotg->params;
> +
> +	p->host_rx_fifo_size = 622;
> +	p->host_nperio_tx_fifo_size = 128;
> +	p->host_perio_tx_fifo_size = 256;
> +}
> +
>   const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "st,stm32f4x9-fsotg",
>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>   	{ .compatible = "st,stm32f4x9-hsotg" },
> +	{ .compatible = "st,stm32f7-hsotg",
> +	  .data = dwc2_set_stm32f7_hsotg_params },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-09-29 14:20     ` Amelie DELAUNAY
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-09-29 14:20 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre TORGUE, John Youn, Felipe Balbi
  Cc: devicetree, linux-usb, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

Hi,

Gentle ping for driver review submitted on August 28th.

Thanks,
Amelie

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>   drivers/usb/dwc2/params.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index a3ffe97..d5b672d 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
> +{
> +	struct dwc2_core_params *p = &hsotg->params;
> +
> +	p->host_rx_fifo_size = 622;
> +	p->host_nperio_tx_fifo_size = 128;
> +	p->host_perio_tx_fifo_size = 256;
> +}
> +
>   const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "st,stm32f4x9-fsotg",
>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>   	{ .compatible = "st,stm32f4x9-hsotg" },
> +	{ .compatible = "st,stm32f7-hsotg",
> +	  .data = dwc2_set_stm32f7_hsotg_params },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-09-29 14:20     ` Amelie DELAUNAY
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-09-29 14:20 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Gentle ping for driver review submitted on August 28th.

Thanks,
Amelie

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> ---
>   drivers/usb/dwc2/params.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index a3ffe97..d5b672d 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
> +{
> +	struct dwc2_core_params *p = &hsotg->params;
> +
> +	p->host_rx_fifo_size = 622;
> +	p->host_nperio_tx_fifo_size = 128;
> +	p->host_perio_tx_fifo_size = 256;
> +}
> +
>   const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>   	{ .compatible = "st,stm32f4x9-fsotg",
>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>   	{ .compatible = "st,stm32f4x9-hsotg" },
> +	{ .compatible = "st,stm32f7-hsotg",
> +	  .data = dwc2_set_stm32f7_hsotg_params },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
  2017-09-29 14:20     ` Amelie DELAUNAY
  (?)
@ 2017-09-30 17:16       ` John Youn
  -1 siblings, 0 replies; 72+ messages in thread
From: John Youn @ 2017-09-30 17:16 UTC (permalink / raw)
  To: Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
	Russell King, Maxime Coquelin, Alexandre TORGUE, John Youn,
	Felipe Balbi
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

On 09/29/2017 07:22 AM, Amelie DELAUNAY wrote:
> Hi,
>
> Gentle ping for driver review submitted on August 28th.
>
> Thanks,
> Amelie
>
> On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
>> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
>> ---
>>   drivers/usb/dwc2/params.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
>> index a3ffe97..d5b672d 100644
>> --- a/drivers/usb/dwc2/params.c
>> +++ b/drivers/usb/dwc2/params.c
>> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>>   	p->activate_stm_fs_transceiver = true;
>>   }
>>
>> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
>> +{
>> +	struct dwc2_core_params *p = &hsotg->params;
>> +
>> +	p->host_rx_fifo_size = 622;
>> +	p->host_nperio_tx_fifo_size = 128;
>> +	p->host_perio_tx_fifo_size = 256;
>> +}
>> +
>>   const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
>> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "st,stm32f4x9-fsotg",
>>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>>   	{ .compatible = "st,stm32f4x9-hsotg" },
>> +	{ .compatible = "st,stm32f7-hsotg",
>> +	  .data = dwc2_set_stm32f7_hsotg_params },
>>   	{},
>>   };
>>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
>>


Acked-by: John Youn <johnyoun@synopsys.com>


John

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-09-30 17:16       ` John Youn
  0 siblings, 0 replies; 72+ messages in thread
From: John Youn @ 2017-09-30 17:16 UTC (permalink / raw)
  To: Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
	Russell King, Maxime Coquelin, Alexandre TORGUE, John Youn,
	Felipe Balbi
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin GAIGNARD

On 09/29/2017 07:22 AM, Amelie DELAUNAY wrote:
> Hi,
>
> Gentle ping for driver review submitted on August 28th.
>
> Thanks,
> Amelie
>
> On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
>> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org>
>> ---
>>   drivers/usb/dwc2/params.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
>> index a3ffe97..d5b672d 100644
>> --- a/drivers/usb/dwc2/params.c
>> +++ b/drivers/usb/dwc2/params.c
>> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>>   	p->activate_stm_fs_transceiver = true;
>>   }
>>
>> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
>> +{
>> +	struct dwc2_core_params *p = &hsotg->params;
>> +
>> +	p->host_rx_fifo_size = 622;
>> +	p->host_nperio_tx_fifo_size = 128;
>> +	p->host_perio_tx_fifo_size = 256;
>> +}
>> +
>>   const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
>> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "st,stm32f4x9-fsotg",
>>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>>   	{ .compatible = "st,stm32f4x9-hsotg" },
>> +	{ .compatible = "st,stm32f7-hsotg",
>> +	  .data = dwc2_set_stm32f7_hsotg_params },
>>   	{},
>>   };
>>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
>>


Acked-by: John Youn <johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>


John

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS
@ 2017-09-30 17:16       ` John Youn
  0 siblings, 0 replies; 72+ messages in thread
From: John Youn @ 2017-09-30 17:16 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/29/2017 07:22 AM, Amelie DELAUNAY wrote:
> Hi,
>
> Gentle ping for driver review submitted on August 28th.
>
> Thanks,
> Amelie
>
> On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
>> This patch adds the dwc2_set_params function for STM32F7 USB OTG HS.
>>
>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
>> ---
>>   drivers/usb/dwc2/params.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
>> index a3ffe97..d5b672d 100644
>> --- a/drivers/usb/dwc2/params.c
>> +++ b/drivers/usb/dwc2/params.c
>> @@ -136,6 +136,15 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>>   	p->activate_stm_fs_transceiver = true;
>>   }
>>
>> +static void dwc2_set_stm32f7_hsotg_params(struct dwc2_hsotg *hsotg)
>> +{
>> +	struct dwc2_core_params *p = &hsotg->params;
>> +
>> +	p->host_rx_fifo_size = 622;
>> +	p->host_nperio_tx_fifo_size = 128;
>> +	p->host_perio_tx_fifo_size = 256;
>> +}
>> +
>>   const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "brcm,bcm2835-usb", .data = dwc2_set_bcm_params },
>>   	{ .compatible = "hisilicon,hi6220-usb", .data = dwc2_set_his_params  },
>> @@ -154,6 +163,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>>   	{ .compatible = "st,stm32f4x9-fsotg",
>>   	  .data = dwc2_set_stm32f4x9_fsotg_params },
>>   	{ .compatible = "st,stm32f4x9-hsotg" },
>> +	{ .compatible = "st,stm32f7-hsotg",
>> +	  .data = dwc2_set_stm32f7_hsotg_params },
>>   	{},
>>   };
>>   MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
>>


Acked-by: John Youn <johnyoun@synopsys.com>


John

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 10:04   ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 10:04 UTC (permalink / raw)
  To: Amelie Delaunay, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
	Russell King, Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel,
	Benjamin Gaignard, Amelie Delaunay

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]


Hi,

Amelie Delaunay <amelie.delaunay@st.com> writes:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
>
> Amelie Delaunay (7):
>   dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>   usb: dwc2: add support for STM32F7 USB OTG HS
>   ARM: dts: stm32: Add USB HS support for STM32F746 MCU

I have applied these three patches. Should I take the rest? They seems
like they could go upstream through the ARM maintainers.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 10:04   ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 10:04 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Mark Rutland, Russell King,
	Maxime Coquelin, Alexandre Torgue, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard, Amelie Delaunay

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]


Hi,

Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org> writes:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
>
> Amelie Delaunay (7):
>   dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>   usb: dwc2: add support for STM32F7 USB OTG HS
>   ARM: dts: stm32: Add USB HS support for STM32F746 MCU

I have applied these three patches. Should I take the rest? They seems
like they could go upstream through the ARM maintainers.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 10:04   ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 10:04 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Amelie Delaunay <amelie.delaunay@st.com> writes:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
>
> Amelie Delaunay (7):
>   dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>   usb: dwc2: add support for STM32F7 USB OTG HS
>   ARM: dts: stm32: Add USB HS support for STM32F746 MCU

I have applied these three patches. Should I take the rest? They seems
like they could go upstream through the ARM maintainers.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171011/13185691/attachment.sig>

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 11:36     ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 11:36 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard

Hi Felip

On 10/11/2017 12:04 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Amelie Delaunay <amelie.delaunay@st.com> writes:
>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>> or in FS/LS with the on-chip FS phy.
>>
>> Amelie Delaunay (7):
>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
> 
> I have applied these three patches. Should I take the rest? They seems
> like they could go upstream through the ARM maintainers.
> 

I will take other DT patches in my PR.

Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
I prefer also to take it. This patch adds some pinctrl groups but stm32 
pinctrl bindings will change in my next PR (we will use a macro to 
define pins instead of using defined values). So if you push the DT 
patch through your pull request there will be a merge issue.
It is possible that I take also this one ?

Regards
Alex

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 11:36     ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 11:36 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard

Hi Felip

On 10/11/2017 12:04 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org> writes:
>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>> or in FS/LS with the on-chip FS phy.
>>
>> Amelie Delaunay (7):
>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
> 
> I have applied these three patches. Should I take the rest? They seems
> like they could go upstream through the ARM maintainers.
> 

I will take other DT patches in my PR.

Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
I prefer also to take it. This patch adds some pinctrl groups but stm32 
pinctrl bindings will change in my next PR (we will use a macro to 
define pins instead of using defined values). So if you push the DT 
patch through your pull request there will be a merge issue.
It is possible that I take also this one ?

Regards
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 11:36     ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 11:36 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Felip

On 10/11/2017 12:04 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Amelie Delaunay <amelie.delaunay@st.com> writes:
>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>> or in FS/LS with the on-chip FS phy.
>>
>> Amelie Delaunay (7):
>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
> 
> I have applied these three patches. Should I take the rest? They seems
> like they could go upstream through the ARM maintainers.
> 

I will take other DT patches in my PR.

Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
I prefer also to take it. This patch adds some pinctrl groups but stm32 
pinctrl bindings will change in my next PR (we will use a macro to 
define pins instead of using defined values). So if you push the DT 
patch through your pull request there will be a merge issue.
It is possible that I take also this one ?

Regards
Alex

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-11 11:36     ` Alexandre Torgue
  (?)
@ 2017-10-11 11:50       ` Felipe Balbi
  -1 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 11:50 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie Delaunay, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felip
>
> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>> or in FS/LS with the on-chip FS phy.
>>>
>>> Amelie Delaunay (7):
>>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>> 
>> I have applied these three patches. Should I take the rest? They seems
>> like they could go upstream through the ARM maintainers.
>> 
>
> I will take other DT patches in my PR.
>
> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
> I prefer also to take it. This patch adds some pinctrl groups but stm32 
> pinctrl bindings will change in my next PR (we will use a macro to 
> define pins instead of using defined values). So if you push the DT 
> patch through your pull request there will be a merge issue.
> It is possible that I take also this one ?

In that case, it's best if you take them all :-) Here's my Ack:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

I'll drop them from my tree now

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 11:50       ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 11:50 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie Delaunay, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: devicetree, linux-usb, linux-kernel, linux-arm-kernel, Benjamin Gaignard


[-- Attachment #1.1: Type: text/plain, Size: 1463 bytes --]


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felip
>
> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>> or in FS/LS with the on-chip FS phy.
>>>
>>> Amelie Delaunay (7):
>>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>> 
>> I have applied these three patches. Should I take the rest? They seems
>> like they could go upstream through the ARM maintainers.
>> 
>
> I will take other DT patches in my PR.
>
> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
> I prefer also to take it. This patch adds some pinctrl groups but stm32 
> pinctrl bindings will change in my next PR (we will use a macro to 
> define pins instead of using defined values). So if you push the DT 
> patch through your pull request there will be a merge issue.
> It is possible that I take also this one ?

In that case, it's best if you take them all :-) Here's my Ack:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

I'll drop them from my tree now

-- 
balbi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 11:50       ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 11:50 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felip
>
> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>> or in FS/LS with the on-chip FS phy.
>>>
>>> Amelie Delaunay (7):
>>>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>    usb: dwc2: add support for STM32F7 USB OTG HS
>>>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>> 
>> I have applied these three patches. Should I take the rest? They seems
>> like they could go upstream through the ARM maintainers.
>> 
>
> I will take other DT patches in my PR.
>
> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch 
> I prefer also to take it. This patch adds some pinctrl groups but stm32 
> pinctrl bindings will change in my next PR (we will use a macro to 
> define pins instead of using defined values). So if you push the DT 
> patch through your pull request there will be a merge issue.
> It is possible that I take also this one ?

In that case, it's best if you take them all :-) Here's my Ack:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

I'll drop them from my tree now

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171011/8722cedb/attachment.sig>

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 12:05         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 12:05 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard

Hi

On 10/11/2017 01:50 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue@st.com> writes:
>> Hi Felip
>>
>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>> or in FS/LS with the on-chip FS phy.
>>>>
>>>> Amelie Delaunay (7):
>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>
>>> I have applied these three patches. Should I take the rest? They seems
>>> like they could go upstream through the ARM maintainers.
>>>
>>
>> I will take other DT patches in my PR.
>>
>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>> pinctrl bindings will change in my next PR (we will use a macro to
>> define pins instead of using defined values). So if you push the DT
>> patch through your pull request there will be a merge issue.
>> It is possible that I take also this one ?
> 
> In that case, it's best if you take them all :-) Here's my Ack:
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> 
> I'll drop them from my tree now

Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
in your tree.


Thanks
Alex

> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 12:05         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 12:05 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard

Hi

On 10/11/2017 01:50 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org> writes:
>> Hi Felip
>>
>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org> writes:
>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>> or in FS/LS with the on-chip FS phy.
>>>>
>>>> Amelie Delaunay (7):
>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>
>>> I have applied these three patches. Should I take the rest? They seems
>>> like they could go upstream through the ARM maintainers.
>>>
>>
>> I will take other DT patches in my PR.
>>
>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>> pinctrl bindings will change in my next PR (we will use a macro to
>> define pins instead of using defined values). So if you push the DT
>> patch through your pull request there will be a merge issue.
>> It is possible that I take also this one ?
> 
> In that case, it's best if you take them all :-) Here's my Ack:
> 
> Acked-by: Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> 
> I'll drop them from my tree now

Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
in your tree.


Thanks
Alex

> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 12:05         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 12:05 UTC (permalink / raw)
  To: linux-arm-kernel

Hi

On 10/11/2017 01:50 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue@st.com> writes:
>> Hi Felip
>>
>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>> or in FS/LS with the on-chip FS phy.
>>>>
>>>> Amelie Delaunay (7):
>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>
>>> I have applied these three patches. Should I take the rest? They seems
>>> like they could go upstream through the ARM maintainers.
>>>
>>
>> I will take other DT patches in my PR.
>>
>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>> pinctrl bindings will change in my next PR (we will use a macro to
>> define pins instead of using defined values). So if you push the DT
>> patch through your pull request there will be a merge issue.
>> It is possible that I take also this one ?
> 
> In that case, it's best if you take them all :-) Here's my Ack:
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> 
> I'll drop them from my tree now

Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
in your tree.


Thanks
Alex

> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 13:26           ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 13:26 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie Delaunay, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi
>
> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>> Hi Felip
>>>
>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>> or in FS/LS with the on-chip FS phy.
>>>>>
>>>>> Amelie Delaunay (7):
>>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>
>>>> I have applied these three patches. Should I take the rest? They seems
>>>> like they could go upstream through the ARM maintainers.
>>>>
>>>
>>> I will take other DT patches in my PR.
>>>
>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>> pinctrl bindings will change in my next PR (we will use a macro to
>>> define pins instead of using defined values). So if you push the DT
>>> patch through your pull request there will be a merge issue.
>>> It is possible that I take also this one ?
>> 
>> In that case, it's best if you take them all :-) Here's my Ack:
>> 
>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> 
>> I'll drop them from my tree now
>
> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
> in your tree.

Well, I have dropped them from my tree. Please two 1-7 through yours.

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 13:26           ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 13:26 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie Delaunay, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin Gaignard


Hi,

Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org> writes:
> Hi
>
> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org> writes:
>>> Hi Felip
>>>
>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Amelie Delaunay <amelie.delaunay-qxv4g6HH51o@public.gmane.org> writes:
>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>> or in FS/LS with the on-chip FS phy.
>>>>>
>>>>> Amelie Delaunay (7):
>>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>
>>>> I have applied these three patches. Should I take the rest? They seems
>>>> like they could go upstream through the ARM maintainers.
>>>>
>>>
>>> I will take other DT patches in my PR.
>>>
>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>> pinctrl bindings will change in my next PR (we will use a macro to
>>> define pins instead of using defined values). So if you push the DT
>>> patch through your pull request there will be a merge issue.
>>> It is possible that I take also this one ?
>> 
>> In that case, it's best if you take them all :-) Here's my Ack:
>> 
>> Acked-by: Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>> 
>> I'll drop them from my tree now
>
> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
> in your tree.

Well, I have dropped them from my tree. Please two 1-7 through yours.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 13:26           ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-11 13:26 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi
>
> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>> Hi Felip
>>>
>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>> or in FS/LS with the on-chip FS phy.
>>>>>
>>>>> Amelie Delaunay (7):
>>>>>     dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>     usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>     ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>
>>>> I have applied these three patches. Should I take the rest? They seems
>>>> like they could go upstream through the ARM maintainers.
>>>>
>>>
>>> I will take other DT patches in my PR.
>>>
>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>> pinctrl bindings will change in my next PR (we will use a macro to
>>> define pins instead of using defined values). So if you push the DT
>>> patch through your pull request there will be a merge issue.
>>> It is possible that I take also this one ?
>> 
>> In that case, it's best if you take them all :-) Here's my Ack:
>> 
>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> 
>> I'll drop them from my tree now
>
> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2 
> in your tree.

Well, I have dropped them from my tree. Please two 1-7 through yours.

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-11 13:26           ` Felipe Balbi
  (?)
@ 2017-10-11 14:38             ` Alexandre Torgue
  -1 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 14:38 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard



On 10/11/2017 03:26 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue@st.com> writes:
>> Hi
>>
>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi Felip
>>>>
>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>
>>>>>> Amelie Delaunay (7):
>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>
>>>>> I have applied these three patches. Should I take the rest? They seems
>>>>> like they could go upstream through the ARM maintainers.
>>>>>
>>>>
>>>> I will take other DT patches in my PR.
>>>>
>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>> define pins instead of using defined values). So if you push the DT
>>>> patch through your pull request there will be a merge issue.
>>>> It is possible that I take also this one ?
>>>
>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>
>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>
>>> I'll drop them from my tree now
>>
>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>> in your tree.
> 
> Well, I have dropped them from my tree. Please two 1-7 through yours.

Hum, ok for this patchset but IMO it is better (next time) that you take 
driver pacthes in your tree and I take only DT patches in mine.
No ?

Regards
Alex

> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 14:38             ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 14:38 UTC (permalink / raw)
  To: Felipe Balbi, Amelie Delaunay, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: devicetree, linux-usb, linux-kernel, linux-arm-kernel, Benjamin Gaignard



On 10/11/2017 03:26 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue@st.com> writes:
>> Hi
>>
>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi Felip
>>>>
>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>
>>>>>> Amelie Delaunay (7):
>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>
>>>>> I have applied these three patches. Should I take the rest? They seems
>>>>> like they could go upstream through the ARM maintainers.
>>>>>
>>>>
>>>> I will take other DT patches in my PR.
>>>>
>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>> define pins instead of using defined values). So if you push the DT
>>>> patch through your pull request there will be a merge issue.
>>>> It is possible that I take also this one ?
>>>
>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>
>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>
>>> I'll drop them from my tree now
>>
>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>> in your tree.
> 
> Well, I have dropped them from my tree. Please two 1-7 through yours.

Hum, ok for this patchset but IMO it is better (next time) that you take 
driver pacthes in your tree and I take only DT patches in mine.
No ?

Regards
Alex

> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-11 14:38             ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-11 14:38 UTC (permalink / raw)
  To: linux-arm-kernel



On 10/11/2017 03:26 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Alexandre Torgue <alexandre.torgue@st.com> writes:
>> Hi
>>
>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi Felip
>>>>
>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works with its
>>>>>> internal phy whilst the USB HS core can work in HS with external ULPI phy
>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>
>>>>>> Amelie Delaunay (7):
>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>
>>>>> I have applied these three patches. Should I take the rest? They seems
>>>>> like they could go upstream through the ARM maintainers.
>>>>>
>>>>
>>>> I will take other DT patches in my PR.
>>>>
>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" patch
>>>> I prefer also to take it. This patch adds some pinctrl groups but stm32
>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>> define pins instead of using defined values). So if you push the DT
>>>> patch through your pull request there will be a merge issue.
>>>> It is possible that I take also this one ?
>>>
>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>
>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>
>>> I'll drop them from my tree now
>>
>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>> in your tree.
> 
> Well, I have dropped them from my tree. Please two 1-7 through yours.

Hum, ok for this patchset but IMO it is better (next time) that you take 
driver pacthes in your tree and I take only DT patches in mine.
No ?

Regards
Alex

> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12  8:32               ` Amelie DELAUNAY
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-10-12  8:32 UTC (permalink / raw)
  To: Alexandre TORGUE, Felipe Balbi, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

Hi Felipe, Alex,

On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
> 
> 
> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>> Hi
>>>
>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>> Hi Felip
>>>>>
>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>> USB
>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>> with its
>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>> ULPI phy
>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>
>>>>>>> Amelie Delaunay (7):
>>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>> binding
>>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>
>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>> seems
>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>
>>>>>
>>>>> I will take other DT patches in my PR.
>>>>>
>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>> patch
>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>> stm32
>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>> define pins instead of using defined values). So if you push the DT
>>>>> patch through your pull request there will be a merge issue.
>>>>> It is possible that I take also this one ?
>>>>
>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>
>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>
>>>> I'll drop them from my tree now
>>>
>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>> in your tree.
>>
>> Well, I have dropped them from my tree. Please two 1-7 through yours.
> 
> Hum, ok for this patchset but IMO it is better (next time) that you take 
> driver pacthes in your tree and I take only DT patches in mine.
> No ?
> 
> Regards
> Alex
> 
>>

I thought that patches 1 and 2, as they are "driver" patches, had to be 
applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
applied on STM32-DT tree (Alex's one). Did I miss something?

Regards,
Amelie

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12  8:32               ` Amelie DELAUNAY
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-10-12  8:32 UTC (permalink / raw)
  To: Alexandre TORGUE, Felipe Balbi, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin GAIGNARD

Hi Felipe, Alex,

On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
> 
> 
> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>> Hi
>>>
>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>> Hi Felip
>>>>>
>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>> USB
>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>> with its
>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>> ULPI phy
>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>
>>>>>>> Amelie Delaunay (7):
>>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>> binding
>>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>
>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>> seems
>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>
>>>>>
>>>>> I will take other DT patches in my PR.
>>>>>
>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>> patch
>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>> stm32
>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>> define pins instead of using defined values). So if you push the DT
>>>>> patch through your pull request there will be a merge issue.
>>>>> It is possible that I take also this one ?
>>>>
>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>
>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>
>>>> I'll drop them from my tree now
>>>
>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>> in your tree.
>>
>> Well, I have dropped them from my tree. Please two 1-7 through yours.
> 
> Hum, ok for this patchset but IMO it is better (next time) that you take 
> driver pacthes in your tree and I take only DT patches in mine.
> No ?
> 
> Regards
> Alex
> 
>>

I thought that patches 1 and 2, as they are "driver" patches, had to be 
applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
applied on STM32-DT tree (Alex's one). Did I miss something?

Regards,
Amelie

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12  8:32               ` Amelie DELAUNAY
  0 siblings, 0 replies; 72+ messages in thread
From: Amelie DELAUNAY @ 2017-10-12  8:32 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Felipe, Alex,

On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
> 
> 
> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>> Hi
>>>
>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>> Hi Felip
>>>>>
>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>> USB
>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>> with its
>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>> ULPI phy
>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>
>>>>>>> Amelie Delaunay (7):
>>>>>>> ???? dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>> binding
>>>>>>> ???? usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>> ???? ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>
>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>> seems
>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>
>>>>>
>>>>> I will take other DT patches in my PR.
>>>>>
>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>> patch
>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>> stm32
>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>> define pins instead of using defined values). So if you push the DT
>>>>> patch through your pull request there will be a merge issue.
>>>>> It is possible that I take also this one ?
>>>>
>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>
>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>
>>>> I'll drop them from my tree now
>>>
>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>> in your tree.
>>
>> Well, I have dropped them from my tree. Please two 1-7 through yours.
> 
> Hum, ok for this patchset but IMO it is better (next time) that you take 
> driver pacthes in your tree and I take only DT patches in mine.
> No ?
> 
> Regards
> Alex
> 
>>

I thought that patches 1 and 2, as they are "driver" patches, had to be 
applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
applied on STM32-DT tree (Alex's one). Did I miss something?

Regards,
Amelie

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-12  8:32               ` Amelie DELAUNAY
  (?)
@ 2017-10-12  8:43                 ` Felipe Balbi
  -1 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12  8:43 UTC (permalink / raw)
  To: Amelie DELAUNAY, Alexandre TORGUE, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Amelie DELAUNAY <amelie.delaunay@st.com> writes:
> Hi Felipe, Alex,
>
> On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
>> 
>> 
>> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi
>>>>
>>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>>> Hi Felip
>>>>>>
>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>>> USB
>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>>> with its
>>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>>> ULPI phy
>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>
>>>>>>>> Amelie Delaunay (7):
>>>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>>> binding
>>>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>
>>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>>> seems
>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>
>>>>>>
>>>>>> I will take other DT patches in my PR.
>>>>>>
>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>>> patch
>>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>>> stm32
>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>> patch through your pull request there will be a merge issue.
>>>>>> It is possible that I take also this one ?
>>>>>
>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>
>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>
>>>>> I'll drop them from my tree now
>>>>
>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>> in your tree.
>>>
>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>> 
>> Hum, ok for this patchset but IMO it is better (next time) that you take 
>> driver pacthes in your tree and I take only DT patches in mine.
>> No ?
>> 
>> Regards
>> Alex
>> 
>>>
>
> I thought that patches 1 and 2, as they are "driver" patches, had to be 
> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
> applied on STM32-DT tree (Alex's one). Did I miss something?

patch 1 is documentation, right? Without the documentation patch,
checkpatch will cringe :-) So either way works.

If you insist, I can take 1-2 through my tree. No worries.

let me know

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12  8:43                 ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12  8:43 UTC (permalink / raw)
  To: Amelie DELAUNAY, Alexandre TORGUE, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Amelie DELAUNAY <amelie.delaunay@st.com> writes:
> Hi Felipe, Alex,
>
> On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
>> 
>> 
>> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi
>>>>
>>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>>> Hi Felip
>>>>>>
>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>>> USB
>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>>> with its
>>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>>> ULPI phy
>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>
>>>>>>>> Amelie Delaunay (7):
>>>>>>>>      dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>>> binding
>>>>>>>>      usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>      ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>
>>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>>> seems
>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>
>>>>>>
>>>>>> I will take other DT patches in my PR.
>>>>>>
>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>>> patch
>>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>>> stm32
>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>> patch through your pull request there will be a merge issue.
>>>>>> It is possible that I take also this one ?
>>>>>
>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>
>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>
>>>>> I'll drop them from my tree now
>>>>
>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>> in your tree.
>>>
>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>> 
>> Hum, ok for this patchset but IMO it is better (next time) that you take 
>> driver pacthes in your tree and I take only DT patches in mine.
>> No ?
>> 
>> Regards
>> Alex
>> 
>>>
>
> I thought that patches 1 and 2, as they are "driver" patches, had to be 
> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
> applied on STM32-DT tree (Alex's one). Did I miss something?

patch 1 is documentation, right? Without the documentation patch,
checkpatch will cringe :-) So either way works.

If you insist, I can take 1-2 through my tree. No worries.

let me know

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12  8:43                 ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12  8:43 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Amelie DELAUNAY <amelie.delaunay@st.com> writes:
> Hi Felipe, Alex,
>
> On 10/11/2017 04:38 PM, Alexandre Torgue wrote:
>> 
>> 
>> On 10/11/2017 03:26 PM, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>> Hi
>>>>
>>>> On 10/11/2017 01:50 PM, Felipe Balbi wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Alexandre Torgue <alexandre.torgue@st.com> writes:
>>>>>> Hi Felip
>>>>>>
>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is 
>>>>>>>> USB
>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works 
>>>>>>>> with its
>>>>>>>> internal phy whilst the USB HS core can work in HS with external 
>>>>>>>> ULPI phy
>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>
>>>>>>>> Amelie Delaunay (7):
>>>>>>>> ???? dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core 
>>>>>>>> binding
>>>>>>>> ???? usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>> ???? ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>
>>>>>>> I have applied these three patches. Should I take the rest? They 
>>>>>>> seems
>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>
>>>>>>
>>>>>> I will take other DT patches in my PR.
>>>>>>
>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU" 
>>>>>> patch
>>>>>> I prefer also to take it. This patch adds some pinctrl groups but 
>>>>>> stm32
>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>> patch through your pull request there will be a merge issue.
>>>>>> It is possible that I take also this one ?
>>>>>
>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>
>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>
>>>>> I'll drop them from my tree now
>>>>
>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>> in your tree.
>>>
>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>> 
>> Hum, ok for this patchset but IMO it is better (next time) that you take 
>> driver pacthes in your tree and I take only DT patches in mine.
>> No ?
>> 
>> Regards
>> Alex
>> 
>>>
>
> I thought that patches 1 and 2, as they are "driver" patches, had to be 
> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be 
> applied on STM32-DT tree (Alex's one). Did I miss something?

patch 1 is documentation, right? Without the documentation patch,
checkpatch will cringe :-) So either way works.

If you insist, I can take 1-2 through my tree. No worries.

let me know

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-12  8:43                 ` Felipe Balbi
  (?)
@ 2017-10-12 11:46                   ` Alexandre Torgue
  -1 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 11:46 UTC (permalink / raw)
  To: Felipe Balbi, Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

Hi Felipe

On 10/12/2017 10:43 AM, Felipe Balbi wrote:
> 
> Hi,
> 
>>>>>>>
>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>> USB
>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>> with its
>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>> ULPI phy
>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>
>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>       dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>> binding
>>>>>>>>>       usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>       ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>
>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>> seems
>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>
>>>>>>>
>>>>>>> I will take other DT patches in my PR.
>>>>>>>
>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>> patch
>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>> stm32
>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>> It is possible that I take also this one ?
>>>>>>
>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>
>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>
>>>>>> I'll drop them from my tree now
>>>>>
>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>> in your tree.
>>>>
>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>
>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>> driver pacthes in your tree and I take only DT patches in mine.
>>> No ?
>>>
>>> Regards
>>> Alex
>>>
>>>>
>>
>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>> applied on STM32-DT tree (Alex's one). Did I miss something?
> 
> patch 1 is documentation, right? Without the documentation patch,
> checkpatch will cringe :-) So either way works.
> 
> If you insist, I can take 1-2 through my tree. No worries.

I don't want to insist :) but for me it is better (and more safe) if you 
take patch 1&2 in your tree, and will take others in mine.

Thanks in advance.
Alex

> 
> let me know
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:46                   ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 11:46 UTC (permalink / raw)
  To: Felipe Balbi, Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD

Hi Felipe

On 10/12/2017 10:43 AM, Felipe Balbi wrote:
> 
> Hi,
> 
>>>>>>>
>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>> USB
>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>> with its
>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>> ULPI phy
>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>
>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>       dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>> binding
>>>>>>>>>       usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>       ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>
>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>> seems
>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>
>>>>>>>
>>>>>>> I will take other DT patches in my PR.
>>>>>>>
>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>> patch
>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>> stm32
>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>> It is possible that I take also this one ?
>>>>>>
>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>
>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>
>>>>>> I'll drop them from my tree now
>>>>>
>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>> in your tree.
>>>>
>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>
>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>> driver pacthes in your tree and I take only DT patches in mine.
>>> No ?
>>>
>>> Regards
>>> Alex
>>>
>>>>
>>
>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>> applied on STM32-DT tree (Alex's one). Did I miss something?
> 
> patch 1 is documentation, right? Without the documentation patch,
> checkpatch will cringe :-) So either way works.
> 
> If you insist, I can take 1-2 through my tree. No worries.

I don't want to insist :) but for me it is better (and more safe) if you 
take patch 1&2 in your tree, and will take others in mine.

Thanks in advance.
Alex

> 
> let me know
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:46                   ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 11:46 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Felipe

On 10/12/2017 10:43 AM, Felipe Balbi wrote:
> 
> Hi,
> 
>>>>>>>
>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>> USB
>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>> with its
>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>> ULPI phy
>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>
>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>  ???? dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>> binding
>>>>>>>>>  ???? usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>  ???? ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>
>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>> seems
>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>
>>>>>>>
>>>>>>> I will take other DT patches in my PR.
>>>>>>>
>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>> patch
>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>> stm32
>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>> It is possible that I take also this one ?
>>>>>>
>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>
>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>
>>>>>> I'll drop them from my tree now
>>>>>
>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>> in your tree.
>>>>
>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>
>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>> driver pacthes in your tree and I take only DT patches in mine.
>>> No ?
>>>
>>> Regards
>>> Alex
>>>
>>>>
>>
>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>> applied on STM32-DT tree (Alex's one). Did I miss something?
> 
> patch 1 is documentation, right? Without the documentation patch,
> checkpatch will cringe :-) So either way works.
> 
> If you insist, I can take 1-2 through my tree. No worries.

I don't want to insist :) but for me it is better (and more safe) if you 
take patch 1&2 in your tree, and will take others in mine.

Thanks in advance.
Alex

> 
> let me know
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-12 11:46                   ` Alexandre Torgue
  (?)
@ 2017-10-12 11:51                     ` Felipe Balbi
  -1 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:51 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie DELAUNAY, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felipe
>
> On 10/12/2017 10:43 AM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>>>>>>>>
>>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>>> USB
>>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>>> with its
>>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>>> ULPI phy
>>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>>
>>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>>       dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>>> binding
>>>>>>>>>>       usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>>       ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>>
>>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>>> seems
>>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I will take other DT patches in my PR.
>>>>>>>>
>>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>>> patch
>>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>>> stm32
>>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>>> It is possible that I take also this one ?
>>>>>>>
>>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>>
>>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>>
>>>>>>> I'll drop them from my tree now
>>>>>>
>>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>>> in your tree.
>>>>>
>>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>>
>>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>>> driver pacthes in your tree and I take only DT patches in mine.
>>>> No ?
>>>>
>>>> Regards
>>>> Alex
>>>>
>>>>>
>>>
>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>> 
>> patch 1 is documentation, right? Without the documentation patch,
>> checkpatch will cringe :-) So either way works.
>> 
>> If you insist, I can take 1-2 through my tree. No worries.
>
> I don't want to insist :) but for me it is better (and more safe) if you 
> take patch 1&2 in your tree, and will take others in mine.

Okay, I'll apply 1&2

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:51                     ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:51 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie DELAUNAY, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felipe
>
> On 10/12/2017 10:43 AM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>>>>>>>>
>>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>>> USB
>>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>>> with its
>>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>>> ULPI phy
>>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>>
>>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>>       dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>>> binding
>>>>>>>>>>       usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>>       ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>>
>>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>>> seems
>>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I will take other DT patches in my PR.
>>>>>>>>
>>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>>> patch
>>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>>> stm32
>>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>>> It is possible that I take also this one ?
>>>>>>>
>>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>>
>>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>>
>>>>>>> I'll drop them from my tree now
>>>>>>
>>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>>> in your tree.
>>>>>
>>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>>
>>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>>> driver pacthes in your tree and I take only DT patches in mine.
>>>> No ?
>>>>
>>>> Regards
>>>> Alex
>>>>
>>>>>
>>>
>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>> 
>> patch 1 is documentation, right? Without the documentation patch,
>> checkpatch will cringe :-) So either way works.
>> 
>> If you insist, I can take 1-2 through my tree. No worries.
>
> I don't want to insist :) but for me it is better (and more safe) if you 
> take patch 1&2 in your tree, and will take others in mine.

Okay, I'll apply 1&2

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:51                     ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:51 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Alexandre Torgue <alexandre.torgue@st.com> writes:
> Hi Felipe
>
> On 10/12/2017 10:43 AM, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>>>>>>>>
>>>>>>>> On 10/11/2017 12:04 PM, Felipe Balbi wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Amelie Delaunay <amelie.delaunay@st.com> writes:
>>>>>>>>>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is
>>>>>>>>>> USB
>>>>>>>>>> OTG FS and the other is USB OTG HS. The USB FS core only works
>>>>>>>>>> with its
>>>>>>>>>> internal phy whilst the USB HS core can work in HS with external
>>>>>>>>>> ULPI phy
>>>>>>>>>> or in FS/LS with the on-chip FS phy.
>>>>>>>>>>
>>>>>>>>>> Amelie Delaunay (7):
>>>>>>>>>>  ???? dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core
>>>>>>>>>> binding
>>>>>>>>>>  ???? usb: dwc2: add support for STM32F7 USB OTG HS
>>>>>>>>>>  ???? ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>>>>>>>>>
>>>>>>>>> I have applied these three patches. Should I take the rest? They
>>>>>>>>> seems
>>>>>>>>> like they could go upstream through the ARM maintainers.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I will take other DT patches in my PR.
>>>>>>>>
>>>>>>>> Concerning "ARM: dts: stm32: Add USB HS support for STM32F746 MCU"
>>>>>>>> patch
>>>>>>>> I prefer also to take it. This patch adds some pinctrl groups but
>>>>>>>> stm32
>>>>>>>> pinctrl bindings will change in my next PR (we will use a macro to
>>>>>>>> define pins instead of using defined values). So if you push the DT
>>>>>>>> patch through your pull request there will be a merge issue.
>>>>>>>> It is possible that I take also this one ?
>>>>>>>
>>>>>>> In that case, it's best if you take them all :-) Here's my Ack:
>>>>>>>
>>>>>>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>>>>>>>
>>>>>>> I'll drop them from my tree now
>>>>>>
>>>>>> Ok perfect, I will take DT patches (3 to 7) and I let you take patch 1&2
>>>>>> in your tree.
>>>>>
>>>>> Well, I have dropped them from my tree. Please two 1-7 through yours.
>>>>
>>>> Hum, ok for this patchset but IMO it is better (next time) that you take
>>>> driver pacthes in your tree and I take only DT patches in mine.
>>>> No ?
>>>>
>>>> Regards
>>>> Alex
>>>>
>>>>>
>>>
>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>> 
>> patch 1 is documentation, right? Without the documentation patch,
>> checkpatch will cringe :-) So either way works.
>> 
>> If you insist, I can take 1-2 through my tree. No worries.
>
> I don't want to insist :) but for me it is better (and more safe) if you 
> take patch 1&2 in your tree, and will take others in mine.

Okay, I'll apply 1&2

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-10-12 11:51                     ` Felipe Balbi
  (?)
@ 2017-10-12 11:53                       ` Felipe Balbi
  -1 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:53 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie DELAUNAY, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>> 
>>> patch 1 is documentation, right? Without the documentation patch,
>>> checkpatch will cringe :-) So either way works.
>>> 
>>> If you insist, I can take 1-2 through my tree. No worries.
>>
>> I don't want to insist :) but for me it is better (and more safe) if you 
>> take patch 1&2 in your tree, and will take others in mine.
>
> Okay, I'll apply 1&2

they are now in my testing/next and next branches.

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:53                       ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:53 UTC (permalink / raw)
  To: Alexandre Torgue, Amelie DELAUNAY, Greg Kroah-Hartman,
	Rob Herring, Mark Rutland, Russell King, Maxime Coquelin,
	John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD


Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>> 
>>> patch 1 is documentation, right? Without the documentation patch,
>>> checkpatch will cringe :-) So either way works.
>>> 
>>> If you insist, I can take 1-2 through my tree. No worries.
>>
>> I don't want to insist :) but for me it is better (and more safe) if you 
>> take patch 1&2 in your tree, and will take others in mine.
>
> Okay, I'll apply 1&2

they are now in my testing/next and next branches.

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 11:53                       ` Felipe Balbi
  0 siblings, 0 replies; 72+ messages in thread
From: Felipe Balbi @ 2017-10-12 11:53 UTC (permalink / raw)
  To: linux-arm-kernel


Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>> 
>>> patch 1 is documentation, right? Without the documentation patch,
>>> checkpatch will cringe :-) So either way works.
>>> 
>>> If you insist, I can take 1-2 through my tree. No worries.
>>
>> I don't want to insist :) but for me it is better (and more safe) if you 
>> take patch 1&2 in your tree, and will take others in mine.
>
> Okay, I'll apply 1&2

they are now in my testing/next and next branches.

-- 
balbi

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 12:01                         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 12:01 UTC (permalink / raw)
  To: Felipe Balbi, Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin GAIGNARD



On 10/12/2017 01:53 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Felipe Balbi <felipe.balbi@linux.intel.com> writes:
>>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>>>
>>>> patch 1 is documentation, right? Without the documentation patch,
>>>> checkpatch will cringe :-) So either way works.
>>>>
>>>> If you insist, I can take 1-2 through my tree. No worries.
>>>
>>> I don't want to insist :) but for me it is better (and more safe) if you
>>> take patch 1&2 in your tree, and will take others in mine.
>>
>> Okay, I'll apply 1&2
> 
> they are now in my testing/next and next branches.

Thanks Felipe
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 12:01                         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 12:01 UTC (permalink / raw)
  To: Felipe Balbi, Amelie DELAUNAY, Greg Kroah-Hartman, Rob Herring,
	Mark Rutland, Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Benjamin GAIGNARD



On 10/12/2017 01:53 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> writes:
>>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>>>
>>>> patch 1 is documentation, right? Without the documentation patch,
>>>> checkpatch will cringe :-) So either way works.
>>>>
>>>> If you insist, I can take 1-2 through my tree. No worries.
>>>
>>> I don't want to insist :) but for me it is better (and more safe) if you
>>> take patch 1&2 in your tree, and will take others in mine.
>>
>> Okay, I'll apply 1&2
> 
> they are now in my testing/next and next branches.

Thanks Felipe
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-12 12:01                         ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-12 12:01 UTC (permalink / raw)
  To: linux-arm-kernel



On 10/12/2017 01:53 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Felipe Balbi <felipe.balbi@linux.intel.com> writes:
>>>>> I thought that patches 1 and 2, as they are "driver" patches, had to be
>>>>> applied on USB tree (so Felipe's one), and the others (3 to 7) had to be
>>>>> applied on STM32-DT tree (Alex's one). Did I miss something?
>>>>
>>>> patch 1 is documentation, right? Without the documentation patch,
>>>> checkpatch will cringe :-) So either way works.
>>>>
>>>> If you insist, I can take 1-2 through my tree. No worries.
>>>
>>> I don't want to insist :) but for me it is better (and more safe) if you
>>> take patch 1&2 in your tree, and will take others in mine.
>>
>> Okay, I'll apply 1&2
> 
> they are now in my testing/next and next branches.

Thanks Felipe
> 

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
  2017-08-28 14:20 ` Amelie Delaunay
  (?)
@ 2017-10-16 16:16   ` Alexandre Torgue
  -1 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-16 16:16 UTC (permalink / raw)
  To: Amelie Delaunay, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
	Russell King, Maxime Coquelin, John Youn
  Cc: linux-usb, devicetree, linux-kernel, linux-arm-kernel, Benjamin Gaignard

Hi Amélie,

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
> 
> Amelie Delaunay (7):
>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>    usb: dwc2: add support for STM32F7 USB OTG HS
>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB HS on stm32746g-eval
>    ARM: dts: stm32: Enable USB HS on stm32f746-disco
>    ARM: dts: stm32: Add USB FS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB FS on stm32f746-disco
> 
>   Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
>   arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
>   arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
>   arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
>   drivers/usb/dwc2/params.c                      | 11 ++++
>   5 files changed, 139 insertions(+)
> 

Patches 3 to 7 applied on stm32-dt-for-v4.15 branch.
Currently USB stack is not enabled by default (and will not be). If you 
plan to use USB don't forget to create a reserved memory region for DMA 
pool (as DMA and caches are not friends on cortex-M7) in devicetree.
Reserved memory region for DMA pool support will be added in stm32F7 and 
stm32H7 devicetree as soon series "ARM: NOMMU: MPU updates" from 
Vladimir Murzin will be merged.

Regards
Alex

^ permalink raw reply	[flat|nested] 72+ messages in thread

* Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-16 16:16   ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-16 16:16 UTC (permalink / raw)
  To: Amelie Delaunay, Greg Kroah-Hartman, Rob Herring, Mark Rutland,
	Russell King, Maxime Coquelin, John Youn
  Cc: devicetree, linux-usb, linux-kernel, linux-arm-kernel, Benjamin Gaignard

Hi Amélie,

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
> 
> Amelie Delaunay (7):
>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>    usb: dwc2: add support for STM32F7 USB OTG HS
>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB HS on stm32746g-eval
>    ARM: dts: stm32: Enable USB HS on stm32f746-disco
>    ARM: dts: stm32: Add USB FS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB FS on stm32f746-disco
> 
>   Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
>   arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
>   arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
>   arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
>   drivers/usb/dwc2/params.c                      | 11 ++++
>   5 files changed, 139 insertions(+)
> 

Patches 3 to 7 applied on stm32-dt-for-v4.15 branch.
Currently USB stack is not enabled by default (and will not be). If you 
plan to use USB don't forget to create a reserved memory region for DMA 
pool (as DMA and caches are not friends on cortex-M7) in devicetree.
Reserved memory region for DMA pool support will be added in stm32F7 and 
stm32H7 devicetree as soon series "ARM: NOMMU: MPU updates" from 
Vladimir Murzin will be merged.

Regards
Alex

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 72+ messages in thread

* [PATCHv2 0/7] Add support for USB OTG on STM32F7
@ 2017-10-16 16:16   ` Alexandre Torgue
  0 siblings, 0 replies; 72+ messages in thread
From: Alexandre Torgue @ 2017-10-16 16:16 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Am?lie,

On 08/28/2017 04:20 PM, Amelie Delaunay wrote:
> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB
> OTG FS and the other is USB OTG HS. The USB FS core only works with its
> internal phy whilst the USB HS core can work in HS with external ULPI phy
> or in FS/LS with the on-chip FS phy.
> 
> Amelie Delaunay (7):
>    dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding
>    usb: dwc2: add support for STM32F7 USB OTG HS
>    ARM: dts: stm32: Add USB HS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB HS on stm32746g-eval
>    ARM: dts: stm32: Enable USB HS on stm32f746-disco
>    ARM: dts: stm32: Add USB FS support for STM32F746 MCU
>    ARM: dts: stm32: Enable USB FS on stm32f746-disco
> 
>   Documentation/devicetree/bindings/usb/dwc2.txt |  2 +
>   arch/arm/boot/dts/stm32746g-eval.dts           | 16 ++++++
>   arch/arm/boot/dts/stm32f746-disco.dts          | 30 ++++++++++
>   arch/arm/boot/dts/stm32f746.dtsi               | 80 ++++++++++++++++++++++++++
>   drivers/usb/dwc2/params.c                      | 11 ++++
>   5 files changed, 139 insertions(+)
> 

Patches 3 to 7 applied on stm32-dt-for-v4.15 branch.
Currently USB stack is not enabled by default (and will not be). If you 
plan to use USB don't forget to create a reserved memory region for DMA 
pool (as DMA and caches are not friends on cortex-M7) in devicetree.
Reserved memory region for DMA pool support will be added in stm32F7 and 
stm32H7 devicetree as soon series "ARM: NOMMU: MPU updates" from 
Vladimir Murzin will be merged.

Regards
Alex

^ permalink raw reply	[flat|nested] 72+ messages in thread

end of thread, other threads:[~2017-10-16 16:17 UTC | newest]

Thread overview: 72+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 14:20 [PATCHv2 0/7] Add support for USB OTG on STM32F7 Amelie Delaunay
2017-08-28 14:20 ` Amelie Delaunay
2017-08-28 14:20 ` Amelie Delaunay
2017-08-28 14:20 ` [PATCHv2 1/7] dt-bindings: usb: Document the STM32F7 DWC2 USB OTG HS core binding Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-09-01 15:35   ` Rob Herring
2017-09-01 15:35     ` Rob Herring
2017-09-01 15:35     ` Rob Herring
2017-08-28 14:20 ` [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-09-29 14:20   ` Amelie DELAUNAY
2017-09-29 14:20     ` Amelie DELAUNAY
2017-09-29 14:20     ` Amelie DELAUNAY
2017-09-30 17:16     ` John Youn
2017-09-30 17:16       ` John Youn
2017-09-30 17:16       ` John Youn
2017-08-28 14:20 ` [PATCHv2 3/7] ARM: dts: stm32: Add USB HS support for STM32F746 MCU Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20 ` [PATCHv2 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20 ` [PATCHv2 5/7] ARM: dts: stm32: Enable USB HS on stm32f746-disco Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20 ` [PATCHv2 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20 ` [PATCHv2 7/7] ARM: dts: stm32: Enable USB FS on stm32f746-disco Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-08-28 14:20   ` Amelie Delaunay
2017-10-11 10:04 ` [PATCHv2 0/7] Add support for USB OTG on STM32F7 Felipe Balbi
2017-10-11 10:04   ` Felipe Balbi
2017-10-11 10:04   ` Felipe Balbi
2017-10-11 11:36   ` Alexandre Torgue
2017-10-11 11:36     ` Alexandre Torgue
2017-10-11 11:36     ` Alexandre Torgue
2017-10-11 11:50     ` Felipe Balbi
2017-10-11 11:50       ` Felipe Balbi
2017-10-11 11:50       ` Felipe Balbi
2017-10-11 12:05       ` Alexandre Torgue
2017-10-11 12:05         ` Alexandre Torgue
2017-10-11 12:05         ` Alexandre Torgue
2017-10-11 13:26         ` Felipe Balbi
2017-10-11 13:26           ` Felipe Balbi
2017-10-11 13:26           ` Felipe Balbi
2017-10-11 14:38           ` Alexandre Torgue
2017-10-11 14:38             ` Alexandre Torgue
2017-10-11 14:38             ` Alexandre Torgue
2017-10-12  8:32             ` Amelie DELAUNAY
2017-10-12  8:32               ` Amelie DELAUNAY
2017-10-12  8:32               ` Amelie DELAUNAY
2017-10-12  8:43               ` Felipe Balbi
2017-10-12  8:43                 ` Felipe Balbi
2017-10-12  8:43                 ` Felipe Balbi
2017-10-12 11:46                 ` Alexandre Torgue
2017-10-12 11:46                   ` Alexandre Torgue
2017-10-12 11:46                   ` Alexandre Torgue
2017-10-12 11:51                   ` Felipe Balbi
2017-10-12 11:51                     ` Felipe Balbi
2017-10-12 11:51                     ` Felipe Balbi
2017-10-12 11:53                     ` Felipe Balbi
2017-10-12 11:53                       ` Felipe Balbi
2017-10-12 11:53                       ` Felipe Balbi
2017-10-12 12:01                       ` Alexandre Torgue
2017-10-12 12:01                         ` Alexandre Torgue
2017-10-12 12:01                         ` Alexandre Torgue
2017-10-16 16:16 ` Alexandre Torgue
2017-10-16 16:16   ` Alexandre Torgue
2017-10-16 16:16   ` Alexandre Torgue

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.