All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,
	Shaker Daibes <shakerd@mellanox.com>
Subject: Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool
Date: Mon, 28 Aug 2017 08:00:11 -0700	[thread overview]
Message-ID: <1503932411.11498.67.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1503923928-9419-1-git-send-email-tariqt@mellanox.com>

On Mon, 2017-08-28 at 15:38 +0300, Tariq Toukan wrote:
> From: Shaker Daibes <shakerd@mellanox.com>
> 
> UFO was removed in kernel, here we remove it in ethtool app.
> 
> Fixes the following issue:
> Features for ens8:
> Cannot get device udp-fragmentation-offload settings: Operation not supported
> 
> Tested with "make check"
> 
> Signed-off-by: Shaker Daibes <shakerd@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---


Hi guys

I would rather remove the warning, but leave the ability to switch UFO
on machines running old kernel but a recent ethtool.

ethtool does not need to be downgraded every time we boot an old
kernel ;)

Thanks !

  reply	other threads:[~2017-08-28 15:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 12:38 Tariq Toukan
2017-08-28 15:00 ` Eric Dumazet [this message]
2017-08-28 16:38   ` David Miller
2017-08-28 18:22   ` John W. Linville
2017-08-29  7:50     ` Tariq Toukan
2017-08-29 10:44       ` Michal Kubecek
2017-09-04 11:46         ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503932411.11498.67.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=eranbe@mellanox.com \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=shakerd@mellanox.com \
    --cc=tariqt@mellanox.com \
    --subject='Re: [ethtool] ethtool: Remove UDP Fragmentation Offload use from ethtool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.