From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gettext.bbclass: do not add virtual/gettext to DEPENDS
Date: Tue, 29 Aug 2017 11:32:57 +0100 [thread overview]
Message-ID: <1504002777.32591.325.camel@linuxfoundation.org> (raw)
In-Reply-To: <20170829095532.7446-1-alexander.kanavin@linux.intel.com>
On Tue, 2017-08-29 at 12:55 +0300, Alexander Kanavin wrote:
> gettext has a notoriously slow configuration step, and so in my
> testing this greatly speeds up building core-image-minimal: from
> 21m36s to 19m2s (empty sstate and tmp, but pre-populated downloads).
>
> I have also built world, and core-image-sato to make sure it doesn't
> break or modify the build, and there is no difference whatsoever in
> packages and images content. Target gettext not seems to be used for
> anything.
>
> Also fix up insane.bbclass to remove the corresponding QA check.
I like this idea, one small question below...
> diff --git a/meta/classes/insane.bbclass
> b/meta/classes/insane.bbclass
> index b7177c9b329..a2ec466775f 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1183,9 +1183,9 @@ Rerun configure task after fixing this.""")
> elif bb.data.inherits_class('cross-canadian', d):
> gt = "nativesdk-gettext"
> else:
> - gt = "virtual/" + ml + "gettext"
> + gt = None
Should this be gettext-native?
> deps = bb.utils.explode_deps(d.getVar('DEPENDS') or "")
> - if gt not in deps:
> + if gt is not None and gt not in deps:
> for config in configs:
> gnu = "grep \"^[[:space:]]*AM_GNU_GETTEXT\" %s
> >/dev/null" % config
> if subprocess.call(gnu, shell=True) == 0:
Cheers,
Richard
next prev parent reply other threads:[~2017-08-29 10:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 9:55 [PATCH] gettext.bbclass: do not add virtual/gettext to DEPENDS Alexander Kanavin
2017-08-29 10:32 ` Richard Purdie [this message]
2017-08-29 10:49 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504002777.32591.325.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.