From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:58637 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750909AbdH2Qzf (ORCPT ); Tue, 29 Aug 2017 12:55:35 -0400 Message-ID: <1504026511.29723.5.camel@megha-Z97X-UD7-TH> Subject: Re: [PATCH] crypto: x86/sha1 : Fix reads beyond the number of blocks passed From: Megha Dey To: Greg KH Cc: stable@vger.kernel.org Date: Tue, 29 Aug 2017 10:08:31 -0700 In-Reply-To: <20170823004743.GA7033@kroah.com> References: <1503448863-30149-1-git-send-email-megha.dey@linux.intel.com> <20170823004743.GA7033@kroah.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2017-08-22 at 17:47 -0700, Greg KH wrote: > On Tue, Aug 22, 2017 at 05:41:03PM -0700, Megha Dey wrote: > > It was reported that the sha1 AVX2 function(sha1_transform_avx2) is > > reading ahead beyond its intended data, and causing a crash if the next > > block is beyond page boundary: > > http://marc.info/?l=linux-crypto-vger&m=149373371023377 > > > > This patch makes sure that there is no overflow for any buffer length. > > > > It passes the tests written by Jan Stancek that revealed this problem: > > https://github.com/jstancek/sha1-avx2-crash > > > > This patch fixes reads beyond the number of blocks in the same way it > > was done in commit 8861249c740fc4af9ddc5aee321eafefb960d7c6 > > ("crypto: x86/sha1 : Fix reads beyond the number of blocks passed"). > > So all you really want is that specific commit added to the stable > kernels? If so, what kernel tree(s)? Hi Greg, The commit 8861249c740fc4af9ddc5aee321eafefb960d7c6 present in the mainline kernel does not apply cleanly to the stable kernel tree. Hence, I have submitted this patch with some minor changes for the stable tree. I am not sure what you mean by which kernel trees. > > thanks, > > greg k-h