All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Kuehling <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Felix Kuehling <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 1/8] drm/amdgpu: Fix error handling in amdgpu_vm_init
Date: Tue, 29 Aug 2017 18:25:17 -0400	[thread overview]
Message-ID: <1504045524-23853-2-git-send-email-Felix.Kuehling@amd.com> (raw)
In-Reply-To: <1504045524-23853-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>

Make sure vm->root.bo is not left reserved if amdgpu_bo_kmap fails.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 6ff3c1b..0e068fb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -2541,9 +2541,9 @@ int amdgpu_vm_init(struct amdgpu_device *adev, struct amdgpu_vm *vm,
 			goto error_free_root;
 
 		r = amdgpu_bo_kmap(vm->root.base.bo, NULL);
+		amdgpu_bo_unreserve(vm->root.base.bo);
 		if (r)
 			goto error_free_root;
-		amdgpu_bo_unreserve(vm->root.base.bo);
 	}
 
 	return 0;
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-08-29 22:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 22:25 [PATCH 0/8] Retry page fault handling for Vega10 Felix Kuehling
     [not found] ` <1504045524-23853-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-08-29 22:25   ` Felix Kuehling [this message]
2017-08-29 22:25   ` [PATCH 2/8] drm/amdgpu: Add PASID management Felix Kuehling
2017-08-29 22:25   ` [PATCH 3/8] drm/radeon: Add PASID manager for KFD Felix Kuehling
2017-08-29 22:25   ` [PATCH 4/8] drm/amdkfd: Separate doorbell allocation from PASID Felix Kuehling
2017-08-29 22:25   ` [PATCH 5/8] drm/amdkfd: Use PASID manager from KGD Felix Kuehling
     [not found]     ` <1504045524-23853-6-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-09-03 11:54       ` Oded Gabbay
     [not found]         ` <CAFCwf13voQSyLFp8smtgMa=ZRRgrf+7H3wzfnF0cP+ak4tMhGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-05 15:39           ` Felix Kuehling
2017-08-29 22:25   ` [PATCH 6/8] drm/amdgpu: Add prescreening stage in IH processing Felix Kuehling
2017-08-29 22:25   ` [PATCH 7/8] lib: Closed hash table with low overhead Felix Kuehling
2017-08-29 22:25   ` [PATCH 8/8] drm/amdgpu: Track pending retry faults in IH and VM (v2) Felix Kuehling
2017-09-06 21:53   ` [PATCH 0/8] Retry page fault handling for Vega10 Felix Kuehling
     [not found]     ` <0816a963-54cc-0041-4b09-4bf41ee46fbf-5C7GfCeVMHo@public.gmane.org>
2017-09-11 19:29       ` Deucher, Alexander
     [not found]         ` <BN6PR12MB1652DBBD8E350972D2BC6C3AF7680-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-09-12  5:48           ` Oded Gabbay
     [not found]             ` <CAFCwf11o=4iizAbRVNE2w3FoacU3yutKsbMvFGfLNTscv1Ym+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-09-12 20:26               ` Felix Kuehling
2017-09-12 23:05 Felix Kuehling
     [not found] ` <1505257545-28000-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-09-12 23:05   ` [PATCH 1/8] drm/amdgpu: Fix error handling in amdgpu_vm_init Felix Kuehling
     [not found]     ` <1505257545-28000-2-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-09-13 19:34       ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504045524-23853-2-git-send-email-Felix.Kuehling@amd.com \
    --to=felix.kuehling-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.