From: Joonas Lahtinen <email@example.com> To: "Wang, Zhi A" <firstname.lastname@example.org>, Chris Wilson <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com> Cc: "Vivi, Rodrigo" <firstname.lastname@example.org>, "Widawsky, Benjamin" <email@example.com> Subject: Re: [RFCv5 2/2] drm/i915: Introduce private PAT management Date: Wed, 30 Aug 2017 14:09:44 +0300 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <F3B0350DF4CB6849A642218320DE483D7D603D0E@SHSMSX104.ccr.corp.intel.com> On Tue, 2017-08-29 at 18:19 +0000, Wang, Zhi A wrote: > I see. > > For 1) I can fix it in the next RFC. Please send a separate bugfix for this so we can proceed to test and merge immediately. Regards, Joonas > For 2) I can find some VPG guys to ask for the details. > > Thanks, > Zhi. > > -----Original Message----- > From: Chris Wilson [mailto:email@example.com] > Sent: Tuesday, August 29, 2017 9:14 PM > To: Wang, Zhi A <firstname.lastname@example.org>; Joonas Lahtinen <email@example.com>; firstname.lastname@example.org; email@example.com > Cc: firstname.lastname@example.org; Widawsky, Benjamin <email@example.com>; Vivi, Rodrigo <firstname.lastname@example.org> > Subject: RE: [RFCv5 2/2] drm/i915: Introduce private PAT management > > Quoting Wang, Zhi A (2017-08-29 18:54:51) > > Another finding during the re-factoring are: > > > > a)It looks like that the PPAT_CACHE_INDEX on BDW/SKL is mapped to: > > GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(0); > > > > But the PPAT_CACHE_INDEX on CNL is mapped to GEN8_PPAT_LLCELLC | > > GEN8_PPAT_AGE(0); > > > > GEN8_PPAT_WB is missing here and by default the cache attribute is UC. > > > > Is this set intentionally? > > That sounds like a nasty little bug. > > > b) Looks like all the ages of PPAT in windows driver is AGE(3) because of some performance gains, is there any reason that i915 has to set it to AGE(0)? > > Nope, it's never been rigorously tested. On occasion, we've swapped it around (at least for the older gen) and never found a significant difference; I haven't even heard if anyone has tried such experiments on gen8+. Off the top of my head, the age should only matter when you have PTE with different ages (unless there's some automatic clock algorithm tracking the age on each page in a shadow, the challenge being then when you decide to refresh the age from the PTE.) -Chris -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intelemail@example.com https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-08-30 11:09 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-29 8:00 [RFCv5 1/2] drm/i915: Factor out setup_private_pat() Zhi Wang 2017-08-29 8:00 ` [RFCv5 2/2] drm/i915: Introduce private PAT management Zhi Wang 2017-08-29 9:37 ` Joonas Lahtinen 2017-08-29 11:18 ` Wang, Zhi A 2017-08-29 17:54 ` Wang, Zhi A 2017-08-29 18:14 ` Chris Wilson 2017-08-29 18:19 ` Wang, Zhi A 2017-08-30 11:09 ` Joonas Lahtinen [this message] 2017-08-29 10:05 ` Chris Wilson 2017-08-29 10:39 ` Chris Wilson 2017-08-29 11:13 ` Wang, Zhi A 2017-08-29 11:23 ` Chris Wilson 2017-08-29 11:31 ` Wang, Zhi A 2017-08-29 11:38 ` Joonas Lahtinen 2017-08-29 12:12 ` Chris Wilson 2017-08-29 12:18 ` Chris Wilson 2017-08-29 12:41 ` Wang, Zhi A 2017-08-29 8:19 ` ✓ Fi.CI.BAT: success for series starting with [RFCv5,1/2] drm/i915: Factor out setup_private_pat() Patchwork 2017-08-29 9:39 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFCv5 2/2] drm/i915: Introduce private PAT management' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.