From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: Bart Van Assche , "hch@infradead.org" , "sagi@grimberg.me" , "axboe@kernel.dk" CC: "keith.busch@intel.com" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [GIT PULL] nvme update for Linux 4.14, take 2 Date: Wed, 30 Aug 2017 15:28:35 +0000 Message-ID: <1504106914.2526.5.camel@wdc.com> References: <20170829150507.rjixn6uf3id6kltx@infradead.org> <9a27048d-1252-985f-c905-b738d709b204@kernel.dk> <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me> In-Reply-To: <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gV2VkLCAyMDE3LTA4LTMwIGF0IDE4OjEwICswMzAwLCBTYWdpIEdyaW1iZXJnIHdyb3RlOg0K PiBJIGp1c3QgcmVhbGl6ZWQgdGhhdCBwYXRjaDoNCj4gLS0NCj4gY29tbWl0IGQzNTJhZTIwNWQ4 YjA1ZjNmNzU1OGQxMGY0NzRkODQzNjU4MWIzZTINCj4gQXV0aG9yOiBCYXJ0IFZhbiBBc3NjaGUg PGJhcnQudmFuYXNzY2hlQHdkYy5jb20+DQo+IERhdGU6ICAgVGh1IEF1ZyAxNyAxNjoyMzowMyAy MDE3IC0wNzAwDQo+IA0KPiAgICAgIGJsay1tcTogTWFrZSBibGtfbXFfcmVpbml0X3RhZ3NldCgp IGNhbGxzIGVhc2llciB0byByZWFkDQo+IA0KPiAgICAgIFNpbmNlIGJsa19tcV9vcHMucmVpbml0 X3JlcXVlc3QgaXMgb25seSBjYWxsZWQgZnJvbSBpbnNpZGUNCj4gICAgICBibGtfbXFfcmVpbml0 X3RhZ3NldCgpLCBtYWtlIHRoaXMgZnVuY3Rpb24gcG9pbnRlciBhbiBhcmd1bWVudCBvZg0KPiAg ICAgIGJsa19tcV9yZWluaXRfdGFnc2V0KCkgaW5zdGVhZCBvZiBhIG1lbWJlciBvZiBzdHJ1Y3Qg YmxrX21xX29wcy4NCj4gICAgICBUaGlzIHBhdGNoIGRvZXMgbm90IGNoYW5nZSBhbnkgZnVuY3Rp b25hbGl0eSBidXQgbWFrZXMNCj4gICAgICBibGtfbXFfcmVpbml0X3RhZ3NldCgpIGNhbGxzIGVh c2llciB0byByZWFkIGFuZCB0byBhbmFseXplLg0KPiAtLQ0KPiANCj4gTWFrZXMgaXQgaW1wb3Nz aWJsZSBmb3IgbWUgdG8gbW92ZSBjb250cm9sbGVyIHJlc2V0IGZsb3cgdG8NCj4gbnZtZS1jb3Jl IHdpdGhvdXQgYWRkaW5nIGEgdHJhbXBvbGluZSAoYXMgdGhlIHJlaW5pdF9yZXF1ZXN0DQo+IGlz IHRyYW5zcG9ydCBzcGVjaWZpYykuLi4NCg0KSGVsbG8gU2FnaSwNCg0KU29ycnkgYnV0IEkgZG91 YnQgdGhhdCB0aGF0IHBhdGNoIG1ha2VzIGl0ICJpbXBvc3NpYmxlIiB0byBtb3ZlIGNvbnRyb2xs ZXINCnJlc2V0IGZsb3cgdG8gdGhlIE5WTWUgY29yZS4gVGhlcmUgYXJlIGFscmVhZHkgc2V2ZXJh bCBmdW5jdGlvbiBwb2ludGVycyBpbg0KdGhlIG52bWVfY3RybF9vcHMgZGF0YSBzdHJ1Y3R1cmUg YW5kIHRoZXJlIGlzIG9uZSBzdWNoIGRhdGEgc3RydWN0dXJlIHBlcg0KdHJhbnNwb3J0LiBIYWQg eW91IGFscmVhZHkgY29uc2lkZXJlZCB0byBhZGQgYSBmdW5jdGlvbiBwb2ludGVyIHRvIHRoYXQN CnN0cnVjdHVyZT8NCg0KQmFydC4= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart.VanAssche@wdc.com (Bart Van Assche) Date: Wed, 30 Aug 2017 15:28:35 +0000 Subject: [GIT PULL] nvme update for Linux 4.14, take 2 In-Reply-To: <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me> References: <20170829150507.rjixn6uf3id6kltx@infradead.org> <9a27048d-1252-985f-c905-b738d709b204@kernel.dk> <38ddd70f-3fec-09c0-dafb-eba1e8f9cc18@grimberg.me> Message-ID: <1504106914.2526.5.camel@wdc.com> On Wed, 2017-08-30@18:10 +0300, Sagi Grimberg wrote: > I just realized that patch: > -- > commit d352ae205d8b05f3f7558d10f474d8436581b3e2 > Author: Bart Van Assche > Date: Thu Aug 17 16:23:03 2017 -0700 > > blk-mq: Make blk_mq_reinit_tagset() calls easier to read > > Since blk_mq_ops.reinit_request is only called from inside > blk_mq_reinit_tagset(), make this function pointer an argument of > blk_mq_reinit_tagset() instead of a member of struct blk_mq_ops. > This patch does not change any functionality but makes > blk_mq_reinit_tagset() calls easier to read and to analyze. > -- > > Makes it impossible for me to move controller reset flow to > nvme-core without adding a trampoline (as the reinit_request > is transport specific)... Hello Sagi, Sorry but I doubt that that patch makes it "impossible" to move controller reset flow to the NVMe core. There are already several function pointers in the nvme_ctrl_ops data structure and there is one such data structure per transport. Had you already considered to add a function pointer to that structure? Bart.