From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-block-owner@vger.kernel.org>
Received: from esa6.hgst.iphmx.com ([216.71.154.45]:49783 "EHLO
        esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751351AbdH3RLs (ORCPT
        <rfc822;linux-block@vger.kernel.org>);
        Wed, 30 Aug 2017 13:11:48 -0400
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "axboe@fb.com" <axboe@fb.com>,
        "ming.lei@redhat.com" <ming.lei@redhat.com>
CC: Bart Van Assche <Bart.VanAssche@wdc.com>,
        "mgorman@techsingularity.net" <mgorman@techsingularity.net>,
        "paolo.valente@linaro.org" <paolo.valente@linaro.org>,
        "loberman@redhat.com" <loberman@redhat.com>
Subject: Re: [PATCH V3 06/14] blk-mq-sched: don't dequeue request until all in
 ->dispatch are flushed
Date: Wed, 30 Aug 2017 17:11:00 +0000
Message-ID: <1504113058.2526.54.camel@wdc.com>
References: <20170826163332.28971-1-ming.lei@redhat.com>
         <20170826163332.28971-7-ming.lei@redhat.com>
In-Reply-To: <20170826163332.28971-7-ming.lei@redhat.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-block-owner@vger.kernel.org
List-Id: linux-block@vger.kernel.org

T24gU3VuLCAyMDE3LTA4LTI3IGF0IDAwOjMzICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gRHVy
aW5nIGRpc3BhdGNoaW5nLCB3ZSBtb3ZlZCBhbGwgcmVxdWVzdHMgZnJvbSBoY3R4LT5kaXNwYXRj
aCB0bw0KPiBvbmUgdGVtcG9yYXJ5IGxpc3QsIHRoZW4gZGlzcGF0Y2ggdGhlbSBvbmUgYnkgb25l
IGZyb20gdGhpcyBsaXN0Lg0KPiBVbmZvcnR1bmF0ZWx5IGR1aXJuZyB0aGlzIHBlcmlvZCwgcnVu
IHF1ZXVlIGZyb20gb3RoZXIgY29udGV4dHMNCiAgICAgICAgICAgICAgICBeXl5eXl4NCiAgICAg
ICAgICAgICAgICBkdXJpbmc/DQo+IG1heSB0aGluayB0aGUgcXVldWUgaXMgaWRsZSwgdGhlbiBz
dGFydCB0byBkZXF1ZXVlIGZyb20gc3cvc2NoZWR1bGVyDQo+IHF1ZXVlIGFuZCBzdGlsbCB0cnkg
dG8gZGlzcGF0Y2ggYmVjYXVzZSAtPmRpc3BhdGNoIGlzIGVtcHR5LiBUaGlzIHdheQ0KPiBodXJ0
cyBzZXF1ZW50aWFsIEkvTyBwZXJmb3JtYW5jZSBiZWNhdXNlIHJlcXVlc3RzIGFyZSBkZXF1ZXVl
ZCB3aGVuDQo+IGxsZCBxdWV1ZSBpcyBidXN5Lg0KPiBbIC4uLiBdDQo+IGRpZmYgLS1naXQgYS9i
bG9jay9ibGstbXEtc2NoZWQuYyBiL2Jsb2NrL2Jsay1tcS1zY2hlZC5jDQo+IGluZGV4IDczNWU0
MzIyOTRhYi4uNGQ3YmVhOGMyNTk0IDEwMDY0NA0KPiAtLS0gYS9ibG9jay9ibGstbXEtc2NoZWQu
Yw0KPiArKysgYi9ibG9jay9ibGstbXEtc2NoZWQuYw0KPiBAQCAtMTQ2LDcgKzE0Niw2IEBAIHZv
aWQgYmxrX21xX3NjaGVkX2Rpc3BhdGNoX3JlcXVlc3RzKHN0cnVjdCBibGtfbXFfaHdfY3R4ICpo
Y3R4KQ0KPiAgCXN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxID0gaGN0eC0+cXVldWU7DQo+ICAJc3Ry
dWN0IGVsZXZhdG9yX3F1ZXVlICplID0gcS0+ZWxldmF0b3I7DQo+ICAJY29uc3QgYm9vbCBoYXNf
c2NoZWRfZGlzcGF0Y2ggPSBlICYmIGUtPnR5cGUtPm9wcy5tcS5kaXNwYXRjaF9yZXF1ZXN0Ow0K
PiAtCWJvb2wgZG9fc2NoZWRfZGlzcGF0Y2ggPSB0cnVlOw0KPiAgCUxJU1RfSEVBRChycV9saXN0
KTsNCj4gIA0KPiAgCS8qIFJDVSBvciBTUkNVIHJlYWQgbG9jayBpcyBuZWVkZWQgYmVmb3JlIGNo
ZWNraW5nIHF1aWVzY2VkIGZsYWcgKi8NCg0KU2hvdWxkbid0IGJsa19tcV9zY2hlZF9kaXNwYXRj
aF9yZXF1ZXN0cygpIHNldCBCTEtfTVFfU19ESVNQQVRDSF9CVVNZIGp1c3QgYWZ0ZXINCnRoZSBm
b2xsb3dpbmcgc3RhdGVtZW50IGJlY2F1c2UgdGhpcyBzdGF0ZW1lbnQgbWFrZXMgdGhlIGRpc3Bh
dGNoIGxpc3QgZW1wdHk/DQoNCgkJCWxpc3Rfc3BsaWNlX2luaXQoJmhjdHgtPmRpc3BhdGNoLCAm
cnFfbGlzdCk7DQoNCj4gQEAgLTE3Nyw4ICsxNzYsMzMgQEAgdm9pZCBibGtfbXFfc2NoZWRfZGlz
cGF0Y2hfcmVxdWVzdHMoc3RydWN0IGJsa19tcV9od19jdHggKmhjdHgpDQo+ICAJICovDQo+ICAJ
aWYgKCFsaXN0X2VtcHR5KCZycV9saXN0KSkgew0KPiAgCQlibGtfbXFfc2NoZWRfbWFya19yZXN0
YXJ0X2hjdHgoaGN0eCk7DQo+IC0JCWRvX3NjaGVkX2Rpc3BhdGNoID0gYmxrX21xX2Rpc3BhdGNo
X3JxX2xpc3QocSwgJnJxX2xpc3QpOw0KPiAtCX0gZWxzZSBpZiAoIWhhc19zY2hlZF9kaXNwYXRj
aCAmJiAhcS0+cXVldWVfZGVwdGgpIHsNCj4gKwkJYmxrX21xX2Rpc3BhdGNoX3JxX2xpc3QocSwg
JnJxX2xpc3QpOw0KPiArDQo+ICsJCS8qDQo+ICsJCSAqIFdlIG1heSBjbGVhciBESVNQQVRDSF9C
VVNZIGp1c3QgYWZ0ZXIgaXQNCj4gKwkJICogaXMgc2V0IGZyb20gYW5vdGhlciBjb250ZXh0LCB0
aGUgb25seSBjb3N0DQo+ICsJCSAqIGlzIHRoYXQgb25lIHJlcXVlc3QgaXMgZGVxdWV1ZWQgYSBi
aXQgZWFybHksDQo+ICsJCSAqIHdlIGNhbiBzdXJ2aXZlIHRoYXQuIEdpdmVuIHRoZSB3aW5kb3cg
aXMNCj4gKwkJICogdG9vIHNtYWxsLCBubyBuZWVkIHRvIHdvcnJ5IGFib3V0IHBlcmZvcm1hbmNl
DQogICAgICAgICAgICAgICAgICAgXl5eDQpUaGUgd29yZCAidG9vIiBzZWVtcyBleHRyYW5lb3Vz
IHRvIG1lIGluIHRoaXMgc2VudGVuY2UuDQoNCj4gIGJvb2wgYmxrX21xX3NjaGVkX3RyeV9tZXJn
ZShzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSwgc3RydWN0IGJpbyAqYmlvLA0KPiBAQCAtMzMwLDYg
KzM1Myw3IEBAIHN0YXRpYyBib29sIGJsa19tcV9zY2hlZF9ieXBhc3NfaW5zZXJ0KHN0cnVjdCBi
bGtfbXFfaHdfY3R4ICpoY3R4LA0KPiAgCSAqLw0KPiAgCXNwaW5fbG9jaygmaGN0eC0+bG9jayk7
DQo+ICAJbGlzdF9hZGQoJnJxLT5xdWV1ZWxpc3QsICZoY3R4LT5kaXNwYXRjaCk7DQo+ICsJc2V0
X2JpdChCTEtfTVFfU19ESVNQQVRDSF9CVVNZLCAmaGN0eC0+c3RhdGUpOw0KPiAgCXNwaW5fdW5s
b2NrKCZoY3R4LT5sb2NrKTsNCj4gIAlyZXR1cm4gdHJ1ZTsNCj4gIH0NCg0KSXMgaXQgbmVjZXNz
YXJ5IHRvIG1ha2UgYmxrX21xX3NjaGVkX2J5cGFzc19pbnNlcnQoKSBzZXQgQkxLX01RX1NfRElT
UEFUQ0hfQlVTWT8NCk15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCBvbmx5IGNvZGUgdGhhdCBtYWtl
cyB0aGUgZGlzcGF0Y2ggbGlzdCBlbXB0eSBzaG91bGQNCnNldCBCTEtfTVFfU19ESVNQQVRDSF9C
VVNZLiBIb3dldmVyLCBibGtfbXFfc2NoZWRfYnlwYXNzX2luc2VydCgpIGFkZHMgYW4gZWxlbWVu
dA0KdG8gdGhlIGRpc3BhdGNoIGxpc3Qgc28gdGhhdCBndWFyYW50ZWVzIHRoYXQgdGhhdCBsaXN0
IGlzIG5vdCBlbXB0eS4NCg0KPiBkaWZmIC0tZ2l0IGEvYmxvY2svYmxrLW1xLmMgYi9ibG9jay9i
bGstbXEuYw0KPiBpbmRleCBmMDYzZGQwZjE5N2YuLjZhZjU2YTcxYzFjZCAxMDA2NDQNCj4gLS0t
IGEvYmxvY2svYmxrLW1xLmMNCj4gKysrIGIvYmxvY2svYmxrLW1xLmMNCj4gQEAgLTExNDAsNiAr
MTE0MCwxMSBAQCBib29sIGJsa19tcV9kaXNwYXRjaF9ycV9saXN0KHN0cnVjdCByZXF1ZXN0X3F1
ZXVlICpxLCBzdHJ1Y3QgbGlzdF9oZWFkICpsaXN0KQ0KPiAgDQo+ICAJCXNwaW5fbG9jaygmaGN0
eC0+bG9jayk7DQo+ICAJCWxpc3Rfc3BsaWNlX2luaXQobGlzdCwgJmhjdHgtPmRpc3BhdGNoKTsN
Cj4gKwkJLyoNCj4gKwkJICogRElTUEFUQ0hfQlVTWSB3b24ndCBiZSBjbGVhcmVkIHVudGlsIGFs
bCByZXF1ZXN0cw0KPiArCQkgKiBpbiBoY3R4LT5kaXNwYXRjaCBhcmUgZGlzcGF0Y2hlZCBzdWNj
ZXNzZnVsbHkNCj4gKwkJICovDQo+ICsJCXNldF9iaXQoQkxLX01RX1NfRElTUEFUQ0hfQlVTWSwg
JmhjdHgtPnN0YXRlKTsNCj4gIAkJc3Bpbl91bmxvY2soJmhjdHgtPmxvY2spOw0KDQpTYW1lIGNv
bW1lbnQgaGVyZSAtIHNpbmNlIHRoaXMgY29kZSBhZGRzIG9uZSBvciBtb3JlIHJlcXVlc3RzIHRv
IHRoZSBkaXNwYXRjaCBsaXN0LA0KaXMgaXQgcmVhbGx5IG5lZWRlZCB0byBzZXQgdGhlIERJU1BB
VENIX0JVU1kgZmxhZz8NCg0KQmFydC4=