From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Theil Subject: [PATCH v4 2/3] igb_uio: fix irq disable on recent kernels Date: Thu, 31 Aug 2017 12:22:28 +0200 Message-ID: <1504174949-25656-2-git-send-email-markus.theil@tu-ilmenau.de> References: <1503408514-20079-1-git-send-email-markus.theil@tu-ilmenau.de> <1504174949-25656-1-git-send-email-markus.theil@tu-ilmenau.de> Cc: ferruh.yigit@intel.com, Markus Theil , nicolas.dichtel@6wind.com To: dev@dpdk.org Return-path: Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67]) by dpdk.org (Postfix) with ESMTP id 281A6F94 for ; Thu, 31 Aug 2017 12:23:18 +0200 (CEST) In-Reply-To: <1504174949-25656-1-git-send-email-markus.theil@tu-ilmenau.de> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" igb_uio already allocates irqs using pci_alloc_irq_vectors on recent kernels >= 4.8. The interrupt disable code was not using the corresponding pci_free_irq_vectors, but the also deprecated pci_disable_msix, before this fix. Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for MSI-X") Cc: nicolas.dichtel@6wind.com Signed-off-by: Markus Theil --- lib/librte_eal/linuxapp/igb_uio/compat.h | 4 ++-- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 9 +++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/lib/librte_eal/linuxapp/igb_uio/compat.h index b800a53..3825933 100644 --- a/lib/librte_eal/linuxapp/igb_uio/compat.h +++ b/lib/librte_eal/linuxapp/igb_uio/compat.h @@ -124,6 +124,6 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev) #endif /* < 3.3.0 */ -#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0) -#define HAVE_PCI_ENABLE_MSIX +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 8, 0) +#define HAVE_ALLOC_IRQ_VECTORS 1 #endif diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index e2e9263..93bb71d 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -312,14 +312,14 @@ static int igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) { int err = 0; -#ifdef HAVE_PCI_ENABLE_MSIX +#ifndef HAVE_ALLOC_IRQ_VECTORS struct msix_entry msix_entry; #endif switch (igbuio_intr_mode_preferred) { case RTE_INTR_MODE_MSIX: /* Only 1 msi-x vector needed */ -#ifdef HAVE_PCI_ENABLE_MSIX +#ifndef HAVE_ALLOC_IRQ_VECTORS msix_entry.entry = 0; if (pci_enable_msix(udev->pdev, &msix_entry, 1) == 0) { dev_dbg(&udev->pdev->dev, "using MSI-X"); @@ -364,8 +364,13 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) static void igbuio_pci_disable_interrupts(struct rte_uio_pci_dev *udev) { +#ifndef HAVE_ALLOC_IRQ_VECTORS if (udev->mode == RTE_INTR_MODE_MSIX) pci_disable_msix(udev->pdev); +#else + if (udev->mode == RTE_INTR_MODE_MSIX) + pci_free_irq_vectors(udev->pdev); +#endif } static int -- 2.7.4