All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pixman: drop submodule
Date: Mon, 04 Sep 2017 08:31:18 +0200	[thread overview]
Message-ID: <1504506678.18331.1.camel@redhat.com> (raw)
In-Reply-To: <CAKmqyKMUVEb13Ffv5YsovOTRAaQ8g=Q2C=U4FzWWZuygAdMwdA@mail.gmail.com>

  Hi,

> > diff --git a/configure b/configure
> > index dd73cce62f..73760430b0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -930,8 +930,6 @@ for opt do
> >    ;;
> >    --with-system-pixman) pixman="system"
> 
> Is there any use case for '--with-system-pixman now?

There is "--without-pixman" (so you can turn off pixman if you don't
want build the system emulation).  So IMHO it makes sense to leave the
opposite switch in.  The name is a bit strange now, but changing it
might break build scripts, so I left it as-is.  Maybe configure should
accept both "--with-pixman" and "--with-system-pixman"?

cheers,
  Gerd

  parent reply	other threads:[~2017-09-04  6:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-01 10:50 [Qemu-devel] [PATCH] pixman: drop submodule Gerd Hoffmann
2017-09-01 15:26 ` Fam Zheng
2017-09-01 22:13 ` Alistair Francis
2017-09-01 22:17   ` Eric Blake
2017-09-01 22:33     ` Alistair Francis
2017-09-04  6:31   ` Gerd Hoffmann [this message]
2017-09-05 13:10     ` Peter Maydell
2017-09-13 14:56 ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504506678.18331.1.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alistair23@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.