Re: [PATCH v14 0/7] drm/i915/gvt: Dma-buf support for GVT-g

From: Gerd Hoffmann <kraxel@redhat.com>
To: "Zhang, Tina" <tina.zhang@intel.com>,
	"Wang, Zhi A" <zhi.a.wang@intel.com>,
	"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
	"Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"joonas.lahtinen@linux.intel.com"
	<joonas.lahtinen@linux.intel.com>,
	"kwankhede@nvidia.com" <kwankhede@nvidia.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v14 0/7] drm/i915/gvt: Dma-buf support for GVT-g
Date: Mon, 04 Sep 2017 08:38:57 +0200	[thread overview]
Message-ID: <1504507137.18331.3.camel@redhat.com> (raw)
In-Reply-To: <237F54289DF84E4997F34151298ABEBC7C5B9B82@SHSMSX101.ccr.corp.intel.com>

  Hi,

> > However, I see VFIO_DEVICE_QUERY_GFX_PLANE failures which I think
> > should
> > not be there.  When the guest didn't define a plane yet I get "No
> > such device"
> > errors instead of a plane_info struct with fields (drm_format,
> > width, height, size)
> > set to zero.  I also see "Bad address" errors now and then with no
> > obvious cause.
> 
> The idea is to return "No such device" error with fields set to zero.
> There are two cases, in which the "No such device" error is returned:
> one is the guest IGD driver
> has not finished the initialization and the other is the plane is
> disabled by guest IGD driver.
> If we prefer to return success in these two situations with fields
> set to zero, I can add it in the
> next version.

Yes, success should be returned in those cases.  Querying the plane
information worked and the struct is filled by the driver.  Userspace
can figure that there is no plane defined by the guest by looking at
the struct fields.

> > Cursor support isn't working too.
> 
> It seems there is some issue in i915 of version 4.13-rc6, which
> blocks the cursor on native platform.
> I just tried the rc7 (the latest staging), there is on such issue.
> Thanks.

OK, I'll go re-test with the just-released 4.13 kernel then.

thanks,
  Gerd

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx