From: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>
To: eric blake <eblake@redhat.com>, greg kurz <groug@kaod.org>
Cc: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
alberto garcia <berto@igalia.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
jani kokkonen <jani.kokkonen@huawei.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling
Date: Mon, 4 Sep 2017 12:07:41 -0400 [thread overview]
Message-ID: <1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com> (raw)
These patches provide the qmp interface, to query the io throttle
status of the all fsdev devices that are present in a vm.
also, it provides an interface to set the io throttle parameters of a
fsdev to a required value. some of the patches also remove the duplicate
code that was present in block and fsdev files.
Pradeep Jagadeesh (6):
throttle: factor out duplicate code
qmp: Create IOThrottle structure
throttle: move out function to reuse the code
hmp: create a throttle initialization function for code reusability
fsdev: QMP interface for throttling
fsdev: hmp interface for throttling
Makefile | 4 +
blockdev.c | 97 +--------------------
fsdev/qemu-fsdev-dummy.c | 11 +++
fsdev/qemu-fsdev-throttle.c | 189 ++++++++++++++++++++++++++++++----------
fsdev/qemu-fsdev-throttle.h | 9 +-
fsdev/qemu-fsdev.c | 30 +++++++
hmp-commands-info.hx | 18 ++++
hmp-commands.hx | 19 ++++
hmp.c | 79 +++++++++++++++--
hmp.h | 4 +
include/qemu/throttle-options.h | 6 ++
include/qemu/throttle.h | 4 +-
include/qemu/typedefs.h | 1 +
monitor.c | 5 ++
qapi-schema.json | 3 +
qapi/block-core.json | 34 ++++++--
qapi/fsdev.json | 81 +++++++++++++++++
qmp.c | 14 +++
util/throttle.c | 110 +++++++++++++++++++++++
19 files changed, 558 insertions(+), 160 deletions(-)
create mode 100644 qapi/fsdev.json
v0 -> v1:
Addressed comments from Eric Blake, Greg Kurz and Daniel P.Berrange
Mainly renaming the functions and removing the redundant code.
v1 -> v2:
Addressed comments from Eric Blake and Greg Kurz.
As per the suggestion I split the patches into smaller patches.
Removed some more duplicate code.
v2 -> v3:
Addresssed comments from Alberto Garcia.
Changed the comment from block to iothrottle in the iothrottle.json
Added the dummy functions in qemu-fsdev-dummy.c to address the compilation
issues that were observed.
v3 -> v4:
Addressed comments from Eric Blake and Greg Kurz
Re-ordered the patches
Added the dummy functions in qmp.c to address the cross compilation issues
v4 -> v5:
Addressed comments from Eric Blake and Greg Kurz
Split the fsdev qmp patch into hmp and qmp related patches
Moved the common functionalities to throttle.c instead of creating
a new file
v5 -> v6:
Addressed comments from Greg Kurz and Markus Armbruster
Split the commits to specific to hmp and throttle as suggested by Greg
Moved ThrottleConfig typedef to qemu/typedefs.h
Addressed compilation issue on FreeBSD by adding flags in qmp.c
v6 -> v7:
Addressed comments from Albert Garcia and Dr. David Alan Gilbert
Fixed the hmp-commands-info.hx and hmp-commands.hx as per Dr. David's
comments.
Fixed the bug with the hmp fsdev_set_io_throttle and info fsdev_iothrottle
v7 -> v8:
Addressed comments from Markus Armbruster and Eric Blake
Removed unwanted headers from qmp-fsdev-throttle.h
v8 -> v9:
Addressed comments from Markus Armbruster and Eric Blake
Removed the iothrottle.json and pushed the iothrottle struct to
block-core.json
v9 -> v10:
Addressed comments from Albert Garcia
Fixed issue related to dynamically passing throttle configuration
Removed some unused code
--
1.8.3.1
next reply other threads:[~2017-09-04 16:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 16:07 Pradeep Jagadeesh [this message]
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 1/6] throttle: factor out duplicate code Pradeep Jagadeesh
2017-09-06 9:49 ` Greg Kurz
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 2/6] qmp: Create IOThrottle structure Pradeep Jagadeesh
2017-09-08 9:37 ` Markus Armbruster
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 3/6] throttle: move out function to reuse the code Pradeep Jagadeesh
2017-09-08 12:27 ` Greg Kurz
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability Pradeep Jagadeesh
2017-09-05 12:03 ` Alberto Garcia
2017-09-08 12:31 ` Greg Kurz
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling Pradeep Jagadeesh
2017-09-08 10:02 ` Markus Armbruster
2017-09-08 11:33 ` Alberto Garcia
2017-09-08 12:51 ` Markus Armbruster
2017-09-08 12:19 ` Pradeep Jagadeesh
2017-09-08 12:34 ` Markus Armbruster
2017-09-08 12:49 ` Pradeep Jagadeesh
2017-09-11 9:23 ` Pradeep Jagadeesh
2017-09-04 16:07 ` [Qemu-devel] [PATCH v10 6/6] fsdev: hmp " Pradeep Jagadeesh
2017-09-05 7:53 ` Alberto Garcia
2017-09-05 8:28 ` Pradeep Jagadeesh
2017-09-05 8:57 ` Greg Kurz
2017-09-05 9:07 ` Alberto Garcia
2017-09-05 9:13 ` Pradeep Jagadeesh
2017-09-05 9:34 ` Alberto Garcia
2017-09-05 9:36 ` Pradeep Jagadeesh
2017-09-05 17:57 ` Dr. David Alan Gilbert
2017-09-05 21:19 ` [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling Eric Blake
2017-09-06 10:12 ` Pradeep Jagadeesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504541267-36954-1-git-send-email-pradeep.jagadeesh@huawei.com \
--to=pradeepkiruvale@gmail.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=groug@kaod.org \
--cc=jani.kokkonen@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.