All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com,
	pmorel@linux.vnet.ibm.com, cohuck@redhat.com, agraf@suse.de,
	richard.henderson@linaro.org, zyimin@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v3 2/3] s390x/pci: fixup ind_offset of msix routing entry
Date: Tue,  5 Sep 2017 12:12:59 +0200	[thread overview]
Message-ID: <1504606380-49341-3-git-send-email-zyimin@linux.vnet.ibm.com> (raw)
In-Reply-To: <1504606380-49341-1-git-send-email-zyimin@linux.vnet.ibm.com>

The guest uses the mpcifc instruction to register the aibvo of a zpci
device, which is the starting offset of indicators in the indicator
area and thus remains constant. Each msix vector is an offset from the
aibvo. When we map a msix route to an adapter route, we should not
modify the starting offset, but instead add the vector to the starting
offset to get the absolute offset in the specific route.

Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
---
 target/s390x/kvm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
index ebbeb4d6b3..931b85fe3d 100644
--- a/target/s390x/kvm.c
+++ b/target/s390x/kvm.c
@@ -2546,14 +2546,12 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
         return -ENODEV;
     }
 
-    pbdev->routes.adapter.ind_offset = vec;
-
     route->type = KVM_IRQ_ROUTING_S390_ADAPTER;
     route->flags = 0;
     route->u.adapter.summary_addr = pbdev->routes.adapter.summary_addr;
     route->u.adapter.ind_addr = pbdev->routes.adapter.ind_addr;
     route->u.adapter.summary_offset = pbdev->routes.adapter.summary_offset;
-    route->u.adapter.ind_offset = pbdev->routes.adapter.ind_offset;
+    route->u.adapter.ind_offset = pbdev->routes.adapter.ind_offset + vec;
     route->u.adapter.adapter_id = pbdev->routes.adapter.adapter_id;
     return 0;
 }
-- 
2.11.0 (Apple Git-81)

  parent reply	other threads:[~2017-09-05 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 10:12 [Qemu-devel] [PATCH v3 0/3] three zpci patches Yi Min Zhao
2017-09-05 10:12 ` [Qemu-devel] [PATCH v3 1/3] s390x/pci: remove idx from msix msg data Yi Min Zhao
2017-09-05 10:12 ` Yi Min Zhao [this message]
2017-09-05 10:13 ` [Qemu-devel] [PATCH v3 3/3] s390x/pci: add iommu replay callback Yi Min Zhao
2017-09-05 11:58 ` [Qemu-devel] [PATCH v3 0/3] three zpci patches Cornelia Huck
2017-09-06  4:57   ` Yi Min Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504606380-49341-3-git-send-email-zyimin@linux.vnet.ibm.com \
    --to=zyimin@linux.vnet.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.