From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752317AbdIFTqT (ORCPT ); Wed, 6 Sep 2017 15:46:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:54745 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdIFTqR (ORCPT ); Wed, 6 Sep 2017 15:46:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,355,1500966000"; d="scan'208";a="308738770" From: "Bernat, Yehezkel" To: "mario.limonciello@dell.com" CC: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "dvhart@infradead.org" , "hughsient@gmail.com" Subject: Re: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Topic: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Index: AQHTJ0jMLsUiAaWSZ0GkTJffp0ap5w== Date: Wed, 6 Sep 2017 19:46:14 +0000 Message-ID: <1504727178.2677.158.camel@intel.com> References: <1504720440-24423-1-git-send-email-mario.limonciello@dell.com> <1504726863.2677.154.camel@intel.com> In-Reply-To: <1504726863.2677.154.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.18.5.2-0ubuntu3.2 authentication-results: spf=none (sender IP is ) smtp.mailfrom=yehezkel.bernat@intel.com; x-originating-ip: [134.191.232.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN4PR11MB1011;6:taXioaInZPREuymQwUK0KyIR6xnFS8UM5f0aWucFlYj2DgFrIynT2xyEmGsWIh9nENy8oRaXRAArqbi3doHV3VfZYnYB476CFeUKGSOoj48a/Wqm4WNwoAtxKCQDF/VCpyB8fC6NXEGxEveb1HJt2g453tQeajNTr8fXeETpYLfxjttnm38ADVjm8DzpzSzMkakTVemj8ycPiFmX3lJEcWF/nV8NZVK+g5bxij4UJsJ5vkM5QmqKi9Trku2mUmAx3uUssocXqgmBjYQzZ7lpMS1FzDQrqUJwt5nPiqj8YILYFpCDtnP/lJ4qdLfZw4MHYVNS2kpwsadHfkWQdbNSHg==;5:leBaeVItdxQIcAfSQe99CU9lYz56hHoZjZiN46Xnee8fsfsGdvtIs0aGKzKrDdQi9vlwKDBJ0wQeYH+s8mbM2qbDo9K/cX9nhC8XlFqLLAhwbeyxsfaaTy84wRWnvFrNRfS8Bo2MLs6eTQaggQK1QQ==;24:5rFf3TT5hvwbFte1QC5K6e1Q2IE5zkill5bZxiL8of8jpUL7WrPkDt6+u2voBBUuaevMIiRxXBCgJ81HyTwdMKtoUjYUFr2DlpoxC5JxjpY=;7:8fqkjwPYm9cDET23DfxLuEJchfWVDNEjSISvPgh2FCDYDKbJvcf+FaTBqnoJNSRw8Sfr8+/NB3iW7oFfPXjS71vJ/KAXmILfVDULVjbaH+NpMmbMLuJ78vDxV0NFZN0DPfQ32Pr85OxmIVaOwbtfCQrriQ59RUB6dqkyAcP65oyaytkb17UUYWQ3k2Rmc7fMS0XcsbDSHnV+ILLQVUKALdfKZGzMIOErYEeLEuvP6fU= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8553bb1c-8baf-4f25-1094-08d4f55feee5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN4PR11MB1011; x-ms-traffictypediagnostic: BN4PR11MB1011: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN4PR11MB1011;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN4PR11MB1011; x-forefront-prvs: 0422860ED4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(189002)(199003)(39060400002)(3660700001)(2906002)(2501003)(14454004)(86362001)(7736002)(305945005)(103116003)(68736007)(101416001)(5660300001)(102836003)(81166006)(81156014)(3846002)(97736004)(3280700002)(8676002)(8936002)(50226002)(6116002)(4326008)(2900100001)(2950100002)(76176999)(33646002)(6916009)(8666007)(106356001)(77096006)(50986999)(478600001)(25786009)(5640700003)(229853002)(189998001)(6512007)(6486002)(99286003)(54906002)(6436002)(66066001)(110136004)(53936002)(105586002)(6506006)(36756003)(2351001)(6246003)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN4PR11MB1011;H:BN4PR11MB0996.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <83BD0648BAAE544C82CE669C86ED5E75@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2017 19:46:14.3363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB1011 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v86JkPj6023800 (Resending with a fixed CC list. Sorry.) > Current implementations of Intel Thunderbolt controllers will go > into a low power mode when not in use. >  > Many machines containing these controllers also have a GPIO wired up > that can force the controller awake.  This is offered via a ACPI-WMI > interface intended to be manipulated by a userspace utility. > This mechanism is provided by Intel to OEMs to include in BIOS. > It uses an industry wide GUID that is populated in a separate _WDG > entry with no binary MOF. >  > This interface allow software such as fwupd to wake up thunderbolt > controllers to query the firmware version or flash new firmware. As this is a Thunderbolt specific function, maybe it's better to be exposed from the Thunderbolt driver? > + > +static DEVICE_ATTR_WO(force_power); > + I'm not sure what is the convention for permissions for this type of attributes but I feel like this worth being root-only writable, as it can be used to power-off the controller in the middle of a FW update, for example. From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bernat, Yehezkel" Subject: Re: [PATCH] Add driver to force WMI Thunderbolt controller power status Date: Wed, 6 Sep 2017 19:46:14 +0000 Message-ID: <1504727178.2677.158.camel@intel.com> References: <1504720440-24423-1-git-send-email-mario.limonciello@dell.com> <1504726863.2677.154.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com ([134.134.136.24]:54745 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbdIFTqR (ORCPT ); Wed, 6 Sep 2017 15:46:17 -0400 In-Reply-To: <1504726863.2677.154.camel@intel.com> Content-Language: en-US Content-ID: <83BD0648BAAE544C82CE669C86ED5E75@namprd11.prod.outlook.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: "mario.limonciello@dell.com" Cc: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "dvhart@infradead.org" , "hughsient@gmail.com" KFJlc2VuZGluZyB3aXRoIGEgZml4ZWQgQ0MgbGlzdC4gU29ycnkuKQ0KDQo+IEN1cnJlbnQgaW1w bGVtZW50YXRpb25zIG9mIEludGVsIFRodW5kZXJib2x0IGNvbnRyb2xsZXJzIHdpbGwgZ28NCj4g aW50byBhIGxvdyBwb3dlciBtb2RlIHdoZW4gbm90IGluIHVzZS4NCj7CoA0KPiBNYW55IG1hY2hp bmVzIGNvbnRhaW5pbmcgdGhlc2UgY29udHJvbGxlcnMgYWxzbyBoYXZlIGEgR1BJTyB3aXJlZCB1 cA0KPiB0aGF0IGNhbiBmb3JjZSB0aGUgY29udHJvbGxlciBhd2FrZS7CoMKgVGhpcyBpcyBvZmZl cmVkIHZpYSBhIEFDUEktV01JDQo+IGludGVyZmFjZSBpbnRlbmRlZCB0byBiZSBtYW5pcHVsYXRl ZCBieSBhIHVzZXJzcGFjZSB1dGlsaXR5Lg0KDQoNCj4gVGhpcyBtZWNoYW5pc20gaXMgcHJvdmlk ZWQgYnkgSW50ZWwgdG8gT0VNcyB0byBpbmNsdWRlIGluIEJJT1MuDQo+IEl0IHVzZXMgYW4gaW5k dXN0cnkgd2lkZSBHVUlEIHRoYXQgaXMgcG9wdWxhdGVkIGluIGEgc2VwYXJhdGUgX1dERw0KPiBl bnRyeSB3aXRoIG5vIGJpbmFyeSBNT0YuDQo+wqANCj4gVGhpcyBpbnRlcmZhY2UgYWxsb3cgc29m dHdhcmUgc3VjaCBhcyBmd3VwZCB0byB3YWtlIHVwIHRodW5kZXJib2x0DQo+IGNvbnRyb2xsZXJz IHRvIHF1ZXJ5IHRoZSBmaXJtd2FyZSB2ZXJzaW9uIG9yIGZsYXNoIG5ldyBmaXJtd2FyZS4NCg0K QXMgdGhpcyBpcyBhIFRodW5kZXJib2x0IHNwZWNpZmljIGZ1bmN0aW9uLCBtYXliZSBpdCdzIGJl dHRlciB0byBiZQ0KZXhwb3NlZCBmcm9tIHRoZSBUaHVuZGVyYm9sdCBkcml2ZXI/DQoNCg0KPiAr DQo+ICtzdGF0aWMgREVWSUNFX0FUVFJfV08oZm9yY2VfcG93ZXIpOw0KPiArDQoNCkknbSBub3Qg c3VyZSB3aGF0IGlzIHRoZSBjb252ZW50aW9uIGZvciBwZXJtaXNzaW9ucyBmb3IgdGhpcyB0eXBl IG9mDQphdHRyaWJ1dGVzIGJ1dCBJIGZlZWwgbGlrZSB0aGlzIHdvcnRoIGJlaW5nIHJvb3Qtb25s eSB3cml0YWJsZSwgYXMgaXQNCmNhbiBiZSB1c2VkIHRvIHBvd2VyLW9mZiB0aGUgY29udHJvbGxl ciBpbiB0aGUgbWlkZGxlIG9mIGEgRlcgdXBkYXRlLA0KZm9yIGV4YW1wbGUu