From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Add a default case in gen7 hwsp switch-case
Date: Fri, 08 Sep 2017 20:07:44 +0100 [thread overview]
Message-ID: <150489766421.23880.18222112666650750336@mail.alporthouse.com> (raw)
In-Reply-To: <20170830180115.907-1-michel.thierry@intel.com>
Quoting Michel Thierry (2017-08-30 19:01:15)
> Gen7 won't get any new engines, and we already added VCS2 there to just
> silence gcc's not handled in switch warnings.
>
> Use a default case instead, otherwise we will need to keep adding extra
> cases if changes happen in the future.
>
> v2: Since reaching the default case is impossible, use GEM_BUG_ON (Chris).
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Reviewed and pushed, thanks.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-08 19:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 18:55 [PATCH] drm/i915: Add a default case in gen7 hwsp switch-case Michel Thierry
2017-08-29 19:13 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-29 19:18 ` [PATCH] " Chris Wilson
2017-08-29 19:21 ` Michel Thierry
2017-08-29 22:17 ` ✓ Fi.CI.IGT: success for " Patchwork
2017-08-30 18:01 ` [PATCH v2] " Michel Thierry
2017-09-08 19:07 ` Chris Wilson [this message]
2017-08-30 18:23 ` ✓ Fi.CI.BAT: success for drm/i915: Add a default case in gen7 hwsp switch-case (rev2) Patchwork
2017-08-31 11:00 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150489766421.23880.18222112666650750336@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.