All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eduardo Valentin <eduval@amazon.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: David Miller <davem@davemloft.net>,
	dwmw2@infradead.org, vallish@amazon.com, shuah@kernel.org,
	richardcochran@gmail.com, xiyou.wangcong@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	anchalag@amazon.com, dwmw@amazon.com
Subject: Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket
Date: Fri, 08 Sep 2017 12:11:49 -0700	[thread overview]
Message-ID: <1504897909.15310.89.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <20170908185521.GA12340@u40b0340c692b58f6553c.ant.amazon.com>

On Fri, 2017-09-08 at 11:55 -0700, Eduardo Valentin wrote:
> Hello,
> 
> On Fri, Sep 08, 2017 at 10:26:45AM -0700, David Miller wrote:
> > From: David Woodhouse <dwmw2@infradead.org>
> > Date: Fri, 08 Sep 2017 18:23:22 +0100
> > 
> > > I don't know that anyone's ever tried saying "show me the chapter
> and
> > > verse of the documentation"
> > 
> > Do you know why I brought this up?  Because the person I am replying
> > to told me that the syscall documentation should have suggested this
> > or that.
> > 
> > That's why.
> 
> :-) My intention was for sure not to upset anybody.
> 
> Just to reiterate, the point of patch is simple, there was a change in
> behavior in the system call from one kernel version to the other. As I
> mentioned, I agree that the userspace could use other means to achieve
> the same, but still the system call behavior has changed.
> 
> > 
> > So let's concentrate on the other aspects of my reply, ok?
> 
> I agree. I would prefer to understand here what is the technical
> reason not to accept these patches other than "use other system
> calls".

So if we need to replace all 'legacy' timers to high resolution timer,
because some application was _relying_ on jiffies being kind of precise,
maybe it is better to revert the change done on legacy timers.

Or continue the migration and make them use high res internally.

select() and poll() are the standard way to have precise timeouts,
it is silly we have to maintain a timeout handling in the datagram fast
path.

  reply	other threads:[~2017-09-08 19:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  0:10 [PATCH v2 0/2] enable hires timer to timeout datagram socket Vallish Vaidyeshwara
2017-08-23  0:10 ` [PATCH v2 1/2] net: enable high resolution timer mode to timeout datagram sockets Vallish Vaidyeshwara
2017-08-23  0:10 ` [PATCH v2 2/2] selftests/net: add test to verify datagram socket timeout Vallish Vaidyeshwara
2017-08-23  4:30 ` [PATCH v2 0/2] enable hires timer to timeout datagram socket David Miller
2017-08-27 20:47   ` Vallish Vaidyeshwara
2017-08-29 11:16     ` David Laight
2017-09-08 17:04   ` Eduardo Valentin
2017-09-08 17:16     ` David Miller
2017-09-08 17:23       ` David Woodhouse
2017-09-08 17:26         ` David Miller
2017-09-08 18:55           ` Eduardo Valentin
2017-09-08 19:11             ` Eric Dumazet [this message]
2017-09-16  9:47               ` Thomas Gleixner
2017-09-20 22:48                 ` Vallish Vaidyeshwara
2017-09-25 20:42                   ` Thomas Gleixner
2017-09-08 21:44             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504897909.15310.89.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=anchalag@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=dwmw@amazon.com \
    --cc=eduval@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vallish@amazon.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.