All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] test_bitmap: Use ULL suffix for 64-bit constants
@ 2017-09-10 10:48 Geert Uytterhoeven
  2017-09-10 13:33 ` Yury Norov
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-09-10 10:48 UTC (permalink / raw)
  To: Andrew Morton, Yury Norov; +Cc: linux-kernel, Geert Uytterhoeven

With gcc 4.1.2:

    lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
    lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
    lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
    lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type

Add the missing "ULL" suffix to fix this.

Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 lib/test_bitmap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
 	BITMAP_FROM_U64(0x22222222),
 	BITMAP_FROM_U64(0xffffffff),
 	BITMAP_FROM_U64(0xfffffffe),
-	BITMAP_FROM_U64(0x3333333311111111),
-	BITMAP_FROM_U64(0xffffffff77777777)
+	BITMAP_FROM_U64(0x3333333311111111ULL),
+	BITMAP_FROM_U64(0xffffffff77777777ULL)
 };
 
 static const unsigned long exp2[] __initconst = {
-	BITMAP_FROM_U64(0x3333333311111111),
-	BITMAP_FROM_U64(0xffffffff77777777)
+	BITMAP_FROM_U64(0x3333333311111111ULL),
+	BITMAP_FROM_U64(0xffffffff77777777ULL)
 };
 
 static const struct test_bitmap_parselist parselist_tests[] __initconst = {
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] test_bitmap: Use ULL suffix for 64-bit constants
  2017-09-10 10:48 [PATCH] test_bitmap: Use ULL suffix for 64-bit constants Geert Uytterhoeven
@ 2017-09-10 13:33 ` Yury Norov
  0 siblings, 0 replies; 2+ messages in thread
From: Yury Norov @ 2017-09-10 13:33 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Andrew Morton, linux-kernel

On Sun, Sep 10, 2017 at 12:48:43PM +0200, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> 
>     lib/test_bitmap.c:189: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:190: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:194: warning: integer constant is too large for ‘long’ type
>     lib/test_bitmap.c:195: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "ULL" suffix to fix this.
> 
> Fixes: 60ef690018b262dd ("bitmap: introduce BITMAP_FROM_U64()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks.
Acked-by: Yury Norov <ynorov@caviumnetworks.com>

> ---
>  lib/test_bitmap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 599c6713f2a2aaa8..aa1f2669bdd5d836 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -186,13 +186,13 @@ static const unsigned long exp[] __initconst = {
>  	BITMAP_FROM_U64(0x22222222),
>  	BITMAP_FROM_U64(0xffffffff),
>  	BITMAP_FROM_U64(0xfffffffe),
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const unsigned long exp2[] __initconst = {
> -	BITMAP_FROM_U64(0x3333333311111111),
> -	BITMAP_FROM_U64(0xffffffff77777777)
> +	BITMAP_FROM_U64(0x3333333311111111ULL),
> +	BITMAP_FROM_U64(0xffffffff77777777ULL)
>  };
>  
>  static const struct test_bitmap_parselist parselist_tests[] __initconst = {
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-09-10 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-10 10:48 [PATCH] test_bitmap: Use ULL suffix for 64-bit constants Geert Uytterhoeven
2017-09-10 13:33 ` Yury Norov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.