From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3 2/2] drm/i915: Simplify i915_reg_read_ioctl Date: Mon, 11 Sep 2017 10:32:49 +0100 Message-ID: <150512236991.16759.8960771288556271008@mail.alporthouse.com> References: <20170911075719.4665-1-joonas.lahtinen@linux.intel.com> <20170911075719.4665-2-joonas.lahtinen@linux.intel.com> <150512153124.16759.16477753851308745846@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D2FE6E33E for ; Mon, 11 Sep 2017 09:33:00 +0000 (UTC) In-Reply-To: <150512153124.16759.16477753851308745846@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , Intel graphics driver community testing & development Cc: Jani Nikula , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBDaHJpcyBXaWxzb24gKDIwMTctMDktMTEgMTA6MTg6NTEpCj4gUXVvdGluZyBKb29u YXMgTGFodGluZW4gKDIwMTctMDktMTEgMDg6NTc6MTkpCj4gPiArICAgICAgIGVudHJ5ID0gcmVn X3JlYWRfd2hpdGVsaXN0Owo+ID4gKyAgICAgICByZW1haW4gPSBBUlJBWV9TSVpFKHJlZ19yZWFk X3doaXRlbGlzdCk7Cj4gPiArICAgICAgIHdoaWxlIChyZW1haW4pIHsKPiA+ICsgICAgICAgICAg ICAgICBHRU1fQlVHX09OKCFpc19wb3dlcl9vZl8yKGVudHJ5LT5zaXplKSk7Cj4gPiArICAgICAg ICAgICAgICAgR0VNX0JVR19PTihlbnRyeS0+c2l6ZSA+IDgpOwo+ID4gKwo+ID4gKyAgICAgICAg ICAgICAgIGlmIChJTlRFTF9JTkZPKGRldl9wcml2KS0+Z2VuX21hc2sgJiBlbnRyeS0+Z2VuX21h c2sgJiYKPiA+ICsgICAgICAgICAgICAgICAgICAgaTkxNV9tbWlvX3JlZ19vZmZzZXQoZW50cnkt Pm9mZnNldF9sZHcpID09Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJlZy0+b2Zm c2V0ICYgLWVudHJ5LT5zaXplKSkKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwo+ ID4gKyAgICAgICAgICAgICAgIGVudHJ5Kys7Cj4gPiArICAgICAgICAgICAgICAgcmVtYWluLS07 Cj4gPiAgICAgICAgIH0KPiA+ICAKPiA+IC0gICAgICAgaWYgKGkgPT0gQVJSQVlfU0laRSh3aGl0 ZWxpc3QpKQo+ID4gKyAgICAgICBpZiAoIXJlbWFpbikKPiA+ICAgICAgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiA+ICAKPiA+IC0gICAgICAgLyogV2UgdXNlIHRoZSBsb3cgYml0cyB0byBl bmNvZGUgZXh0cmEgZmxhZ3MgYXMgdGhlIHJlZ2lzdGVyIHNob3VsZAo+ID4gLSAgICAgICAgKiBi ZSBuYXR1cmFsbHkgYWxpZ25lZCAoYW5kIHRob3NlIHRoYXQgYXJlIG5vdCBzbyBhbGlnbmVkIG1l cmVseQo+ID4gLSAgICAgICAgKiBsaW1pdCB0aGUgYXZhaWxhYmxlIGZsYWdzIGZvciB0aGF0IHJl Z2lzdGVyKS4KPiA+IC0gICAgICAgICovCj4gPiAtICAgICAgIG9mZnNldF9sZHcgPSBlbnRyeS0+ b2Zmc2V0X2xkdzsKPiA+IC0gICAgICAgb2Zmc2V0X3VkdyA9IGVudHJ5LT5vZmZzZXRfdWR3Owo+ ID4gLSAgICAgICBzaXplID0gZW50cnktPnNpemU7Cj4gPiAtICAgICAgIHNpemUgfD0gcmVnLT5v ZmZzZXQgXiBpOTE1X21taW9fcmVnX29mZnNldChvZmZzZXRfbGR3KTsKPiA+ICsgICAgICAgZmxh Z3MgPSByZWctPm9mZnNldCAmIH5pOTE1X21taW9fcmVnX29mZnNldChlbnRyeS0+b2Zmc2V0X2xk dyk7Cj4gCj4gVGhlIG1taW8gb2Zmc2V0IGlzIG5vdCBhIG1hc2ssIHNvIH5ub3RfYV9tYXNrIGlz IGFuIGludGVyZXN0aW5nIG1peCBvZgo+IGJpdHMuIFNvIEkgc3RpbGwgdGhpbmsgXiBpcyBjbGVh cmVyIHRvIGV4dHJhY3QgdGhlIGJpdHMgdGhhdCBkaWZmZXIgaW4KPiB0aGUgdXNlciBvZmZzZXQu IElmIHlvdSB3YW50IHRvIGVudW5jaWF0ZSB0aGUgaW50ZXJmYWNlIGNsZWFybHkgdGhlbgo+IHVz ZSBmbGFncyA9IHJlZy0+b2Zmc2V0ICYgKGVudHJ5LT5zaXplIC0gMSk7CgpXaXRoIGEgR0VNX0JV R19PTihlbnRyeS0+b2Zmc2V0X2xkdyAmIC1lbnRyeS0+c2l6ZSk7IGZvciBzYW5pdHkuCi1DaHJp cwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK