From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Cleanup error paths through eb_lookup_vma()
Date: Tue, 12 Sep 2017 21:04:58 +0100 [thread overview]
Message-ID: <150524669820.18386.2393627452673779762@mail.alporthouse.com> (raw)
In-Reply-To: <337c3384-c152-0e99-3cf2-5637b6f945ba@linux.intel.com>
Quoting Tvrtko Ursulin (2017-09-12 16:21:06)
>
> On 12/09/2017 16:07, Chris Wilson wrote:
> > Following the simplification to a single lookup loop in commit
> > 170fa29b14fa ("drm/i915: Simplify eb_lookup_vmas()") and commit
> > d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr"), we can go
> > one setup further and reorder the error paths so that the state of the
> > local variable obj is always known to the compiler and doesn't need the
> > uninitialized_var markup to squelch a compiler warning.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
[snip]
> Looks good to me.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Ta, and pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-12 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:07 [PATCH] drm/i915: Cleanup error paths through eb_lookup_vma() Chris Wilson
2017-09-12 15:21 ` Tvrtko Ursulin
2017-09-12 20:04 ` Chris Wilson [this message]
2017-09-12 15:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-12 19:32 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150524669820.18386.2393627452673779762@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.