From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH i-g-t] lib/igt_kmod: Allow specifying libkmod config via environment variables
Date: Wed, 13 Sep 2017 15:40:29 +0300 [thread overview]
Message-ID: <1505306429.10157.7.camel@linux.intel.com> (raw)
In-Reply-To: <150529904721.16779.4093283639746353595@mail.alporthouse.com>
On Wed, 2017-09-13 at 11:37 +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2017-09-12 16:51:40)
> > Quoting Joonas Lahtinen (2017-09-12 16:44:10)
> > > Allow specifying the kernel module configuration via environment
> > > variables. This allows enumerating the subtests of the kselftest
> > > wrappers from sysroot directory.
> > >
> > > IGT_KMOD_CONFIG_PATHS="" \
> > > IGT_KMOD_DIRNAME="/path/to/sysroot/lib/modules/X.Y.Z" \
> > > tests/drm_mm --list-subtests
> >
> > Just one quibble, but shouldn't it be PATH? E.g.
>
> On reflection, they match the libkmod names, so who am I to judge?
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Yeah, I was considering IGT_MODULE_PATH and IGT_MODULE_CONFIG_PATH, but
that would have indicated they might be used in other ways too,
strictly sticking to KMOD convention seemed would cause least
confusion.
This is now pushed, thanks for the review.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:44 [PATCH i-g-t] lib/igt_kmod: Allow specifying libkmod config via environment variables Joonas Lahtinen
2017-09-12 15:51 ` Chris Wilson
2017-09-13 10:37 ` Chris Wilson
2017-09-13 12:40 ` Joonas Lahtinen [this message]
2017-09-12 17:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-13 0:16 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505306429.10157.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.